feat: add injection metadata fields to telemetry forwarder #9094

sydney-tung · 2025-07-03T14:58:20Z

What Does This Do

This change adds additional fields to the telemetry forwarder used during injection. These fields will be used to add additional context that will be surfaced to the end user in the following Figma:

See Injection Metadata for more details.

Motivation

Adding addition information for telemetry forwarder during injection.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: INPLAT-614

AlexeyKuznetsov-DD

Looks like you accidentally committed bunch of binaries

dd-java-agent/src/main/java/datadog/trace/bootstrap/BootstrapInitializationTelemetry.java

dd-java-agent/src/main/java6/datadog/trace/bootstrap/AgentPreCheck.java

dd-java-agent/src/main/java/datadog/trace/bootstrap/BootstrapInitializationTelemetry.java

dd-java-agent/src/main/java6/datadog/trace/bootstrap/AgentPreCheck.java

dd-java-agent/src/main/java/datadog/trace/bootstrap/BootstrapInitializationTelemetry.java

AlexeyKuznetsov-DD

Almost LGTM, just some tests polishing left.

...va-agent/src/test/groovy/datadog/trace/bootstrap/BootstrapInitializationTelemetryTest.groovy

AlexeyKuznetsov-DD

LGTM, but minor cleanup required.

dd-java-agent/src/main/java/datadog/trace/bootstrap/BootstrapInitializationTelemetry.java

...va-agent/src/test/groovy/datadog/trace/bootstrap/BootstrapInitializationTelemetryTest.groovy

dd-java-agent/src/main/java/datadog/trace/bootstrap/BootstrapInitializationTelemetry.java

PerfectSlayer

Left a bunch of comments.
The request for change is only for the .gitignore to avoid the PR to be merged without the fix for 🙏

PerfectSlayer · 2025-07-15T07:17:18Z

.gitignore

@@ -60,6 +60,7 @@ replay_pid*
 .bsp/
 **/src/*/generated/*
 !dd-java-agent/benchmark/releases/*.jar
+*.jar


We do want jar, like maven and gradle wrappers. Can you revert this part please?

PerfectSlayer · 2025-07-15T07:31:04Z

dd-java-agent/src/main/java/datadog/trace/bootstrap/BootstrapInitializationTelemetry.java

+      setMetadata("error", mapResultClass(reasonCode), reasonCode);
+    }
+
+    private void setMetadata(String result, String resultClass, String resultReason) {


I would rename the result helper method and use overloading for clarity. Something like:

Suggested change

private void setMetadata(String result, String resultClass, String resultReason) {

private void setMetaResult(String result, String resultCode) {

setMetaResult(result, mapResultClass(reasonCode), reasonCode);

}

private void setMetaResult(String result, String resultClass, String resultReason) {

}

WDYT?

PerfectSlayer · 2025-07-15T07:34:40Z

...va-agent/src/test/groovy/datadog/trace/bootstrap/BootstrapInitializationTelemetryTest.groovy

@@ -26,19 +26,47 @@ class BootstrapInitializationTelemetryTest extends Specification {
    initTelemetryProxy.setAdaptee(initTelemetry)

    this.initTelemetry = initTelemetryProxy
+    this.initTelemetry.initMetaInfo("runtime_name", "java")
+    this.initTelemetry.initMetaInfo("runtime_version", "1.8.0_382")


If this version is coming from you current setup or the current CI JDK version, you can rely on it for testing

This is 100% synthetic test, no need in real data.

PerfectSlayer · 2025-07-15T07:34:56Z

...va-agent/src/test/groovy/datadog/trace/bootstrap/BootstrapInitializationTelemetryTest.groovy

@@ -76,6 +106,10 @@ class BootstrapInitializationTelemetryTest extends Specification {
    !capture.json().contains("library_entrypoint.complete")
  }

+  private String json(String result, String resultClass, String resultReason, List points) {
+    return """{"metadata":{"runtime_name":"java","runtime_version":"1.8.0_382","result":"${result}","result_class":"${resultClass}","result_reason":"${resultReason}"},"points":${new groovy.json.JsonBuilder(points)}}"""


added result, result_class, and result_reason to injection metadata

67f321b

AlexeyKuznetsov-DD requested changes Jul 3, 2025

View reviewed changes

dd-java-agent/src/main/java/datadog/trace/bootstrap/BootstrapInitializationTelemetry.java Outdated Show resolved Hide resolved

sydney-tung added 2 commits July 3, 2025 12:51

remove binaries

8a1b47d

Merge branch 'master' into INPLAT-614

dfbdeb4

sydney-tung force-pushed the INPLAT-614 branch from 70aa798 to dfbdeb4 Compare July 7, 2025 17:18

sydney-tung added 10 commits July 7, 2025 13:22

undo again

5fe42f8

update

f39625a

update

9765824

Merge branch 'master' into INPLAT-614

ddb245a

added tests

13cf611

fixing error reasons

e1b9b30

update

1e2dbd2

fixed success case

53e6b52

added more tests

8c2ee53

Merge branch 'master' into INPLAT-614

96f08bb

sydney-tung marked this pull request as ready for review July 8, 2025 17:47

sydney-tung requested a review from a team as a code owner July 8, 2025 17:47

sydney-tung requested review from dougqh and AlexeyKuznetsov-DD July 8, 2025 17:47

fixed formatting

e9f57fe

AlexeyKuznetsov-DD requested changes Jul 8, 2025

View reviewed changes

sydney-tung added 3 commits July 9, 2025 10:51

more concise

38dbfef

update

7868c63

Merge branch 'master' into INPLAT-614

2444bf3

AlexeyKuznetsov-DD requested changes Jul 9, 2025

View reviewed changes

dd-java-agent/src/main/java/datadog/trace/bootstrap/BootstrapInitializationTelemetry.java Outdated Show resolved Hide resolved

dd-java-agent/src/main/java/datadog/trace/bootstrap/BootstrapInitializationTelemetry.java Outdated Show resolved Hide resolved

sydney-tung added 2 commits July 9, 2025 13:23

update ordering

93a74f7

Merge branch 'master' into INPLAT-614

20fafe3

AlexeyKuznetsov-DD requested changes Jul 9, 2025

View reviewed changes

changed tests

d8fe228

sydney-tung added 2 commits July 9, 2025 16:43

fix formatting

0b9a9c7

changed tests

9080656

sydney-tung requested a review from AlexeyKuznetsov-DD July 9, 2025 21:20

AlexeyKuznetsov-DD requested changes Jul 9, 2025

View reviewed changes

sydney-tung added 2 commits July 9, 2025 17:31

fixed format

a601a06

Merge branch 'master' into INPLAT-614

07eb21e

AlexeyKuznetsov-DD approved these changes Jul 9, 2025

View reviewed changes

AlexeyKuznetsov-DD added type: enhancement Enhancements and improvements comp: core Tracer core labels Jul 9, 2025

sydney-tung added 2 commits July 10, 2025 09:37

Merge branch 'master' into INPLAT-614

ed1c6a2

Merge branch 'master' into INPLAT-614

2e9b812

dougqh reviewed Jul 10, 2025

View reviewed changes

dd-java-agent/src/main/java/datadog/trace/bootstrap/BootstrapInitializationTelemetry.java Show resolved Hide resolved

fix

fa08696

sydney-tung requested a review from dougqh July 10, 2025 15:57

sydney-tung and others added 6 commits July 10, 2025 15:34

Merge branch 'master' into INPLAT-614

4fe3d47

Merge branch 'master' into INPLAT-614

b5afa83

add incompatible_library

032fbff

Merge branch 'master' into INPLAT-614

ba2423d

Merge branch 'master' into INPLAT-614

6232eb0

Merge branch 'master' into INPLAT-614

b59dd8a

PerfectSlayer requested changes Jul 15, 2025

View reviewed changes

-    private void setMetadata(String result, String resultClass, String resultReason) {
+    private void setMetaResult(String result, String resultCode) {
+      setMetaResult(result,  mapResultClass(reasonCode), reasonCode);
+    }
+    private void setMetaResult(String result, String resultClass, String resultReason) {
+    }

feat: add injection metadata fields to telemetry forwarder #9094

Are you sure you want to change the base?

feat: add injection metadata fields to telemetry forwarder #9094

Conversation

sydney-tung commented Jul 3, 2025 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

AlexeyKuznetsov-DD left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexeyKuznetsov-DD left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexeyKuznetsov-DD left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PerfectSlayer left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

AlexeyKuznetsov-DD Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sydney-tung commented Jul 3, 2025 •

edited by jira bot

Loading

PerfectSlayer left a comment •

edited

Loading