-
Notifications
You must be signed in to change notification settings - Fork 309
Migrate libddwaf to maven central #9095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
manuel-alvarez-alvarez
wants to merge
2
commits into
master
Choose a base branch
from
malvarez/migrate-libddwaf-sonatype
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~be6b634c13, baseline=1.51.0-SNAPSHOT~9ad6afd361
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.003 s) : 0, 1002751
Total [baseline] (8.574 s) : 0, 8573663
Agent [candidate] (1.003 s) : 0, 1003277
Total [candidate] (8.568 s) : 0, 8567930
section iast
Agent [baseline] (1.142 s) : 0, 1141731
Total [baseline] (9.271 s) : 0, 9270807
Agent [candidate] (1.15 s) : 0, 1149738
Total [candidate] (9.286 s) : 0, 9286348
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~be6b634c13, baseline=1.51.0-SNAPSHOT~9ad6afd361
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.805 ms) : 0, 692805
BytebuddyAgent [candidate] (692.768 ms) : 0, 692768
GlobalTracer [baseline] (242.809 ms) : 0, 242809
GlobalTracer [candidate] (243.335 ms) : 0, 243335
AppSec [baseline] (30.511 ms) : 0, 30511
AppSec [candidate] (30.594 ms) : 0, 30594
Debugger [baseline] (6.091 ms) : 0, 6091
Debugger [candidate] (6.106 ms) : 0, 6106
Remote Config [baseline] (676.793 µs) : 0, 677
Remote Config [candidate] (688.658 µs) : 0, 689
Telemetry [baseline] (8.333 ms) : 0, 8333
Telemetry [candidate] (8.323 ms) : 0, 8323
section iast
BytebuddyAgent [baseline] (814.185 ms) : 0, 814185
BytebuddyAgent [candidate] (820.966 ms) : 0, 820966
GlobalTracer [baseline] (234.164 ms) : 0, 234164
GlobalTracer [candidate] (235.007 ms) : 0, 235007
IAST [baseline] (28.61 ms) : 0, 28610
IAST [candidate] (26.463 ms) : 0, 26463
AppSec [baseline] (28.835 ms) : 0, 28835
AppSec [candidate] (31.37 ms) : 0, 31370
Debugger [baseline] (5.882 ms) : 0, 5882
Debugger [candidate] (5.816 ms) : 0, 5816
Remote Config [baseline] (580.598 µs) : 0, 581
Remote Config [candidate] (588.108 µs) : 0, 588
Telemetry [baseline] (7.99 ms) : 0, 7990
Telemetry [candidate] (8.023 ms) : 0, 8023
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~be6b634c13, baseline=1.51.0-SNAPSHOT~9ad6afd361
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (996.996 ms) : 0, 996996
Total [baseline] (10.597 s) : 0, 10596787
Agent [candidate] (1.003 s) : 0, 1003123
Total [candidate] (10.561 s) : 0, 10561480
section appsec
Agent [baseline] (1.177 s) : 0, 1176712
Total [baseline] (10.773 s) : 0, 10772649
Agent [candidate] (1.177 s) : 0, 1176608
Total [candidate] (10.735 s) : 0, 10735398
section iast
Agent [baseline] (1.135 s) : 0, 1135031
Total [baseline] (10.83 s) : 0, 10829599
Agent [candidate] (1.135 s) : 0, 1134720
Total [candidate] (10.801 s) : 0, 10801009
section profiling
Agent [baseline] (1.249 s) : 0, 1248610
Total [baseline] (10.953 s) : 0, 10952805
Agent [candidate] (1.246 s) : 0, 1245871
Total [candidate] (10.911 s) : 0, 10910523
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~be6b634c13, baseline=1.51.0-SNAPSHOT~9ad6afd361
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (688.1 ms) : 0, 688100
BytebuddyAgent [candidate] (692.884 ms) : 0, 692884
GlobalTracer [baseline] (242.296 ms) : 0, 242296
GlobalTracer [candidate] (243.421 ms) : 0, 243421
AppSec [baseline] (30.273 ms) : 0, 30273
AppSec [candidate] (30.389 ms) : 0, 30389
Debugger [baseline] (6.032 ms) : 0, 6032
Debugger [candidate] (6.116 ms) : 0, 6116
Remote Config [baseline] (674.017 µs) : 0, 674
Remote Config [candidate] (680.127 µs) : 0, 680
Telemetry [baseline] (8.202 ms) : 0, 8202
Telemetry [candidate] (8.313 ms) : 0, 8313
section appsec
BytebuddyAgent [baseline] (710.342 ms) : 0, 710342
BytebuddyAgent [candidate] (710.634 ms) : 0, 710634
GlobalTracer [baseline] (235.082 ms) : 0, 235082
GlobalTracer [candidate] (235.823 ms) : 0, 235823
IAST [baseline] (23.577 ms) : 0, 23577
IAST [candidate] (23.222 ms) : 0, 23222
AppSec [baseline] (171.814 ms) : 0, 171814
AppSec [candidate] (171.162 ms) : 0, 171162
Debugger [baseline] (5.785 ms) : 0, 5785
Debugger [candidate] (5.733 ms) : 0, 5733
Remote Config [baseline] (604.103 µs) : 0, 604
Remote Config [candidate] (597.854 µs) : 0, 598
Telemetry [baseline] (8.061 ms) : 0, 8061
Telemetry [candidate] (8.094 ms) : 0, 8094
section iast
BytebuddyAgent [baseline] (808.549 ms) : 0, 808549
BytebuddyAgent [candidate] (808.329 ms) : 0, 808329
GlobalTracer [baseline] (233.144 ms) : 0, 233144
GlobalTracer [candidate] (233.138 ms) : 0, 233138
IAST [baseline] (29.652 ms) : 0, 29652
IAST [candidate] (25.244 ms) : 0, 25244
AppSec [baseline] (27.877 ms) : 0, 27877
AppSec [candidate] (31.196 ms) : 0, 31196
Debugger [baseline] (5.856 ms) : 0, 5856
Debugger [candidate] (6.75 ms) : 0, 6750
Remote Config [baseline] (588.209 µs) : 0, 588
Remote Config [candidate] (587.562 µs) : 0, 588
Telemetry [baseline] (8.02 ms) : 0, 8020
Telemetry [candidate] (8.021 ms) : 0, 8021
section profiling
BytebuddyAgent [baseline] (680.642 ms) : 0, 680642
BytebuddyAgent [candidate] (679.086 ms) : 0, 679086
GlobalTracer [baseline] (361.798 ms) : 0, 361798
GlobalTracer [candidate] (360.604 ms) : 0, 360604
AppSec [baseline] (34.741 ms) : 0, 34741
AppSec [candidate] (31.639 ms) : 0, 31639
Debugger [baseline] (8.424 ms) : 0, 8424
Debugger [candidate] (11.397 ms) : 0, 11397
Remote Config [baseline] (668.207 µs) : 0, 668
Remote Config [candidate] (661.158 µs) : 0, 661
Telemetry [baseline] (9.454 ms) : 0, 9454
Telemetry [candidate] (8.735 ms) : 0, 8735
ProfilingAgent [baseline] (103.604 ms) : 0, 103604
ProfilingAgent [candidate] (103.956 ms) : 0, 103956
Profiling [baseline] (103.628 ms) : 0, 103628
Profiling [candidate] (103.98 ms) : 0, 103980
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~be6b634c13, baseline=1.51.0-SNAPSHOT~9ad6afd361
dateFormat X
axisFormat %s
section baseline
no_agent (4.49 ms) : 4440, 4539
. : milestone, 4490,
iast (9.502 ms) : 9344, 9660
. : milestone, 9502,
iast_FULL (14.222 ms) : 13937, 14507
. : milestone, 14222,
iast_GLOBAL (10.501 ms) : 10315, 10686
. : milestone, 10501,
profiling (8.823 ms) : 8689, 8956
. : milestone, 8823,
tracing (7.606 ms) : 7498, 7714
. : milestone, 7606,
section candidate
no_agent (4.375 ms) : 4326, 4424
. : milestone, 4375,
iast (9.156 ms) : 9009, 9303
. : milestone, 9156,
iast_FULL (13.947 ms) : 13662, 14232
. : milestone, 13947,
iast_GLOBAL (10.559 ms) : 10368, 10751
. : milestone, 10559,
profiling (8.754 ms) : 8620, 8887
. : milestone, 8754,
tracing (7.788 ms) : 7678, 7898
. : milestone, 7788,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~be6b634c13, baseline=1.51.0-SNAPSHOT~9ad6afd361
dateFormat X
axisFormat %s
section baseline
no_agent (36.986 ms) : 36686, 37287
. : milestone, 36986,
appsec (47.934 ms) : 47517, 48350
. : milestone, 47934,
code_origins (46.765 ms) : 46357, 47173
. : milestone, 46765,
iast (44.543 ms) : 44153, 44933
. : milestone, 44543,
profiling (48.61 ms) : 48110, 49110
. : milestone, 48610,
tracing (43.64 ms) : 43271, 44009
. : milestone, 43640,
section candidate
no_agent (36.647 ms) : 36348, 36946
. : milestone, 36647,
appsec (48.424 ms) : 48006, 48841
. : milestone, 48424,
code_origins (47.413 ms) : 47002, 47824
. : milestone, 47413,
iast (43.972 ms) : 43579, 44365
. : milestone, 43972,
profiling (50.131 ms) : 49669, 50593
. : milestone, 50131,
tracing (44.648 ms) : 44277, 45018
. : milestone, 44648,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~be6b634c13, baseline=1.51.0-SNAPSHOT~9ad6afd361
dateFormat X
axisFormat %s
section baseline
no_agent (15.024 s) : 15024000, 15024000
. : milestone, 15024000,
appsec (14.877 s) : 14877000, 14877000
. : milestone, 14877000,
iast (18.271 s) : 18271000, 18271000
. : milestone, 18271000,
iast_GLOBAL (17.885 s) : 17885000, 17885000
. : milestone, 17885000,
profiling (15.323 s) : 15323000, 15323000
. : milestone, 15323000,
tracing (14.899 s) : 14899000, 14899000
. : milestone, 14899000,
section candidate
no_agent (15.537 s) : 15537000, 15537000
. : milestone, 15537000,
appsec (14.848 s) : 14848000, 14848000
. : milestone, 14848000,
iast (18.46 s) : 18460000, 18460000
. : milestone, 18460000,
iast_GLOBAL (18.181 s) : 18181000, 18181000
. : milestone, 18181000,
profiling (15.22 s) : 15220000, 15220000
. : milestone, 15220000,
tracing (15.017 s) : 15017000, 15017000
. : milestone, 15017000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~be6b634c13, baseline=1.51.0-SNAPSHOT~9ad6afd361
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1470, 1494
. : milestone, 1482,
appsec (2.41 ms) : 2361, 2459
. : milestone, 2410,
iast (2.206 ms) : 2144, 2268
. : milestone, 2206,
iast_GLOBAL (2.257 ms) : 2194, 2319
. : milestone, 2257,
profiling (2.041 ms) : 1991, 2090
. : milestone, 2041,
tracing (2.017 ms) : 1969, 2065
. : milestone, 2017,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (2.414 ms) : 2365, 2464
. : milestone, 2414,
iast (2.204 ms) : 2142, 2267
. : milestone, 2204,
iast_GLOBAL (2.247 ms) : 2184, 2310
. : milestone, 2247,
profiling (2.042 ms) : 1992, 2092
. : milestone, 2042,
tracing (2.021 ms) : 1973, 2070
. : milestone, 2021,
|
AlexeyKuznetsov-DD
requested changes
Jul 3, 2025
dd-java-agent/instrumentation/akka-http/akka-http-10.0/gradle.lockfile
Outdated
Show resolved
Hide resolved
dd-java-agent/instrumentation/akka-http/akka-http-10.0/gradle.lockfile
Outdated
Show resolved
Hide resolved
d4c3950
to
bbe74cf
Compare
bbe74cf
to
be6b634
Compare
AlexeyKuznetsov-DD
approved these changes
Jul 7, 2025
smola
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: asm waf
Application Security Management (WAF)
tag: dependencies
Dependencies related changes
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Migrate the libddwaf artifact from an S3 bucket to Maven Central by:
https://sqreen-ci-java.s3.amazonaws.com/jars/
io.sqreen
group to the existing Maven Central Sonatype snapshots repositorylibsqreen
dependency version from15.0.0
to15.0.1
Motivation
The account owning the S3 bucket with the Ivy repository needs to be removed.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: APPSEC-9858