-
Notifications
You must be signed in to change notification settings - Fork 310
New Migrate build.gradle to kotlin dsl #9103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~f17ad49fc6, baseline=1.52.0-SNAPSHOT~847275bcc2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1044693
Total [baseline] (10.618 s) : 0, 10617981
Agent [candidate] (1.044 s) : 0, 1043841
Total [candidate] (10.601 s) : 0, 10600528
section appsec
Agent [baseline] (1.212 s) : 0, 1212490
Total [baseline] (10.777 s) : 0, 10776695
Agent [candidate] (1.225 s) : 0, 1225471
Total [candidate] (10.797 s) : 0, 10797471
section iast
Agent [baseline] (1.171 s) : 0, 1171415
Total [baseline] (10.855 s) : 0, 10855300
Agent [candidate] (1.186 s) : 0, 1185897
Total [candidate] (10.936 s) : 0, 10935559
section profiling
Agent [baseline] (1.186 s) : 0, 1186102
Total [baseline] (10.869 s) : 0, 10868539
Agent [candidate] (1.181 s) : 0, 1180539
Total [candidate] (10.897 s) : 0, 10897152
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~f17ad49fc6, baseline=1.52.0-SNAPSHOT~847275bcc2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.438 ms) : 0, 1438
crashtracking [candidate] (1.434 ms) : 0, 1434
BytebuddyAgent [baseline] (733.816 ms) : 0, 733816
BytebuddyAgent [candidate] (733.869 ms) : 0, 733869
GlobalTracer [baseline] (242.669 ms) : 0, 242669
GlobalTracer [candidate] (242.061 ms) : 0, 242061
AppSec [baseline] (30.745 ms) : 0, 30745
AppSec [candidate] (30.595 ms) : 0, 30595
Debugger [baseline] (6.054 ms) : 0, 6054
Debugger [candidate] (6.024 ms) : 0, 6024
Remote Config [baseline] (654.283 µs) : 0, 654
Remote Config [candidate] (647.62 µs) : 0, 648
Telemetry [baseline] (8.279 ms) : 0, 8279
Telemetry [candidate] (8.219 ms) : 0, 8219
section appsec
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (748.121 ms) : 0, 748121
BytebuddyAgent [candidate] (756.782 ms) : 0, 756782
GlobalTracer [baseline] (233.505 ms) : 0, 233505
GlobalTracer [candidate] (236.019 ms) : 0, 236019
IAST [baseline] (23.662 ms) : 0, 23662
IAST [candidate] (23.634 ms) : 0, 23634
AppSec [baseline] (168.206 ms) : 0, 168206
AppSec [candidate] (165.93 ms) : 0, 165930
Debugger [baseline] (7.696 ms) : 0, 7696
Debugger [candidate] (10.789 ms) : 0, 10789
Remote Config [baseline] (618.759 µs) : 0, 619
Remote Config [candidate] (606.565 µs) : 0, 607
Telemetry [baseline] (8.122 ms) : 0, 8122
Telemetry [candidate] (8.896 ms) : 0, 8896
section iast
crashtracking [baseline] (1.429 ms) : 0, 1429
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (846.07 ms) : 0, 846070
BytebuddyAgent [candidate] (857.956 ms) : 0, 857956
GlobalTracer [baseline] (230.591 ms) : 0, 230591
GlobalTracer [candidate] (232.453 ms) : 0, 232453
IAST [baseline] (30.065 ms) : 0, 30065
IAST [candidate] (30.028 ms) : 0, 30028
AppSec [baseline] (26.401 ms) : 0, 26401
AppSec [candidate] (26.821 ms) : 0, 26821
Debugger [baseline] (7.465 ms) : 0, 7465
Debugger [candidate] (7.554 ms) : 0, 7554
Remote Config [baseline] (585.291 µs) : 0, 585
Remote Config [candidate] (601.891 µs) : 0, 602
Telemetry [baseline] (7.926 ms) : 0, 7926
Telemetry [candidate] (8.001 ms) : 0, 8001
section profiling
crashtracking [baseline] (1.382 ms) : 0, 1382
crashtracking [candidate] (1.391 ms) : 0, 1391
BytebuddyAgent [baseline] (759.628 ms) : 0, 759628
BytebuddyAgent [candidate] (757.58 ms) : 0, 757580
GlobalTracer [baseline] (220.907 ms) : 0, 220907
GlobalTracer [candidate] (219.782 ms) : 0, 219782
AppSec [baseline] (30.618 ms) : 0, 30618
AppSec [candidate] (30.255 ms) : 0, 30255
Debugger [baseline] (6.268 ms) : 0, 6268
Debugger [candidate] (6.287 ms) : 0, 6287
Remote Config [baseline] (672.273 µs) : 0, 672
Remote Config [candidate] (659.22 µs) : 0, 659
Telemetry [baseline] (13.536 ms) : 0, 13536
Telemetry [candidate] (13.219 ms) : 0, 13219
ProfilingAgent [baseline] (104.758 ms) : 0, 104758
ProfilingAgent [candidate] (103.16 ms) : 0, 103160
Profiling [baseline] (104.782 ms) : 0, 104782
Profiling [candidate] (103.183 ms) : 0, 103183
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~f17ad49fc6, baseline=1.52.0-SNAPSHOT~847275bcc2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043554
Total [baseline] (8.63 s) : 0, 8630401
Agent [candidate] (1.041 s) : 0, 1041150
Total [candidate] (8.624 s) : 0, 8623515
section iast
Agent [baseline] (1.171 s) : 0, 1171237
Total [baseline] (9.22 s) : 0, 9220346
Agent [candidate] (1.172 s) : 0, 1172478
Total [candidate] (9.211 s) : 0, 9211475
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~f17ad49fc6, baseline=1.52.0-SNAPSHOT~847275bcc2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.442 ms) : 0, 1442
crashtracking [candidate] (1.429 ms) : 0, 1429
BytebuddyAgent [baseline] (733.335 ms) : 0, 733335
BytebuddyAgent [candidate] (730.526 ms) : 0, 730526
GlobalTracer [baseline] (242.316 ms) : 0, 242316
GlobalTracer [candidate] (242.597 ms) : 0, 242597
AppSec [baseline] (30.535 ms) : 0, 30535
AppSec [candidate] (30.752 ms) : 0, 30752
Debugger [baseline] (6.043 ms) : 0, 6043
Debugger [candidate] (6.043 ms) : 0, 6043
Remote Config [baseline] (654.575 µs) : 0, 655
Remote Config [candidate] (655.737 µs) : 0, 656
Telemetry [baseline] (8.292 ms) : 0, 8292
Telemetry [candidate] (8.294 ms) : 0, 8294
section iast
crashtracking [baseline] (1.427 ms) : 0, 1427
crashtracking [candidate] (1.428 ms) : 0, 1428
BytebuddyAgent [baseline] (846.03 ms) : 0, 846030
BytebuddyAgent [candidate] (846.892 ms) : 0, 846892
GlobalTracer [baseline] (230.533 ms) : 0, 230533
GlobalTracer [candidate] (231.039 ms) : 0, 231039
AppSec [baseline] (28.041 ms) : 0, 28041
AppSec [candidate] (26.656 ms) : 0, 26656
Debugger [baseline] (7.598 ms) : 0, 7598
Debugger [candidate] (7.528 ms) : 0, 7528
Remote Config [baseline] (589.149 µs) : 0, 589
Remote Config [candidate] (581.967 µs) : 0, 582
Telemetry [baseline] (7.947 ms) : 0, 7947
Telemetry [candidate] (7.873 ms) : 0, 7873
IAST [baseline] (28.249 ms) : 0, 28249
IAST [candidate] (29.654 ms) : 0, 29654
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~f17ad49fc6, baseline=1.52.0-SNAPSHOT~847275bcc2
dateFormat X
axisFormat %s
section baseline
no_agent (36.006 ms) : 35716, 36295
. : milestone, 36006,
appsec (47.508 ms) : 47082, 47934
. : milestone, 47508,
code_origins (44.345 ms) : 43941, 44750
. : milestone, 44345,
iast (43.225 ms) : 42857, 43594
. : milestone, 43225,
profiling (48.279 ms) : 47834, 48724
. : milestone, 48279,
tracing (45.144 ms) : 44767, 45520
. : milestone, 45144,
section candidate
no_agent (36.2 ms) : 35895, 36504
. : milestone, 36200,
appsec (45.839 ms) : 45425, 46252
. : milestone, 45839,
code_origins (45.2 ms) : 44786, 45614
. : milestone, 45200,
iast (46.665 ms) : 46261, 47068
. : milestone, 46665,
profiling (49.672 ms) : 49202, 50142
. : milestone, 49672,
tracing (44.921 ms) : 44537, 45305
. : milestone, 44921,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~f17ad49fc6, baseline=1.52.0-SNAPSHOT~847275bcc2
dateFormat X
axisFormat %s
section baseline
no_agent (4.331 ms) : 4283, 4379
. : milestone, 4331,
iast (9.279 ms) : 9128, 9429
. : milestone, 9279,
iast_FULL (14.476 ms) : 14185, 14767
. : milestone, 14476,
iast_GLOBAL (10.574 ms) : 10389, 10758
. : milestone, 10574,
profiling (8.423 ms) : 8295, 8551
. : milestone, 8423,
tracing (7.389 ms) : 7287, 7491
. : milestone, 7389,
section candidate
no_agent (4.315 ms) : 4261, 4369
. : milestone, 4315,
iast (9.549 ms) : 9389, 9709
. : milestone, 9549,
iast_FULL (13.987 ms) : 13703, 14271
. : milestone, 13987,
iast_GLOBAL (10.351 ms) : 10170, 10533
. : milestone, 10351,
profiling (9.111 ms) : 8972, 9250
. : milestone, 9111,
tracing (7.518 ms) : 7404, 7633
. : milestone, 7518,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~f17ad49fc6, baseline=1.52.0-SNAPSHOT~847275bcc2
dateFormat X
axisFormat %s
section baseline
no_agent (15.476 s) : 15476000, 15476000
. : milestone, 15476000,
appsec (14.854 s) : 14854000, 14854000
. : milestone, 14854000,
iast (18.809 s) : 18809000, 18809000
. : milestone, 18809000,
iast_GLOBAL (17.98 s) : 17980000, 17980000
. : milestone, 17980000,
profiling (15.161 s) : 15161000, 15161000
. : milestone, 15161000,
tracing (14.912 s) : 14912000, 14912000
. : milestone, 14912000,
section candidate
no_agent (15.179 s) : 15179000, 15179000
. : milestone, 15179000,
appsec (14.728 s) : 14728000, 14728000
. : milestone, 14728000,
iast (18.275 s) : 18275000, 18275000
. : milestone, 18275000,
iast_GLOBAL (18.005 s) : 18005000, 18005000
. : milestone, 18005000,
profiling (15.341 s) : 15341000, 15341000
. : milestone, 15341000,
tracing (14.916 s) : 14916000, 14916000
. : milestone, 14916000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~f17ad49fc6, baseline=1.52.0-SNAPSHOT~847275bcc2
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.665 ms) : 3449, 3880
. : milestone, 3665,
iast (2.212 ms) : 2149, 2274
. : milestone, 2212,
iast_GLOBAL (2.241 ms) : 2179, 2304
. : milestone, 2241,
profiling (2.061 ms) : 2011, 2111
. : milestone, 2061,
tracing (2.017 ms) : 1968, 2065
. : milestone, 2017,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.66 ms) : 3443, 3877
. : milestone, 3660,
iast (2.211 ms) : 2148, 2273
. : milestone, 2211,
iast_GLOBAL (2.249 ms) : 2187, 2312
. : milestone, 2249,
profiling (2.063 ms) : 2012, 2114
. : milestone, 2063,
tracing (2.022 ms) : 1973, 2070
. : milestone, 2022,
|
49c8d60
to
b97c404
Compare
cd09c82
to
aab29bc
Compare
# Conflicts: # dd-trace-api/build.gradle
aab29bc
to
f7b9c9b
Compare
chore(build): Migrate :internal-api:internal-api-9 to Kotlin DSL
# Conflicts: # internal-api/build.gradle.kts # Conflicts: # internal-api/build.gradle.kts # Conflicts: # internal-api/build.gradle
f7b9c9b
to
f17ad49
Compare
* chore(build): Migrate :dd-trace-api to Kotlin DSL # Conflicts: # dd-trace-api/build.gradle * chore(gradle): Convert :internal-api:internal-api-9 to kotlin dsl chore(build): Migrate :internal-api:internal-api-9 to Kotlin DSL * chore(build): Migrate :internal-api to Kotlin DSL # Conflicts: # internal-api/build.gradle.kts # Conflicts: # internal-api/build.gradle.kts # Conflicts: # internal-api/build.gradle * chore(build): Migrate :dd-trace-ot to Kotlin DSL * chore(build): Migrate :dd-trace-ot:correlation-id-injection to Kotlin DSL * chore(build): Migrate :communication to Kotlin DSL
What Does This Do
Migrates new build.gradle to kotlin DSL
Motivation
Improves type checking, and symbol lookup in the IDE
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]