-
Notifications
You must be signed in to change notification settings - Fork 309
Unify truncation limits between ObjectIntrospection and WAFModule #9168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~2f8a8ff169, baseline=1.52.0-SNAPSHOT~61685915b3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (993.295 ms) : 0, 993295
Total [baseline] (10.653 s) : 0, 10653283
Agent [candidate] (1.0 s) : 0, 1000401
Total [candidate] (10.734 s) : 0, 10733668
section appsec
Agent [baseline] (1.178 s) : 0, 1178232
Total [baseline] (10.766 s) : 0, 10766434
Agent [candidate] (1.172 s) : 0, 1171829
Total [candidate] (10.765 s) : 0, 10765116
section iast
Agent [baseline] (1.144 s) : 0, 1144129
Total [baseline] (10.901 s) : 0, 10901018
Agent [candidate] (1.132 s) : 0, 1132411
Total [candidate] (10.906 s) : 0, 10906300
section profiling
Agent [baseline] (1.241 s) : 0, 1241027
Total [baseline] (11.057 s) : 0, 11057022
Agent [candidate] (1.249 s) : 0, 1248790
Total [candidate] (11.017 s) : 0, 11017172
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~2f8a8ff169, baseline=1.52.0-SNAPSHOT~61685915b3
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.253 ms) : 0, 685253
BytebuddyAgent [candidate] (690.514 ms) : 0, 690514
GlobalTracer [baseline] (242.072 ms) : 0, 242072
GlobalTracer [candidate] (243.388 ms) : 0, 243388
AppSec [baseline] (30.266 ms) : 0, 30266
AppSec [candidate] (30.565 ms) : 0, 30565
Debugger [baseline] (5.965 ms) : 0, 5965
Debugger [candidate] (5.987 ms) : 0, 5987
Remote Config [baseline] (664.832 µs) : 0, 665
Remote Config [candidate] (674.319 µs) : 0, 674
Telemetry [baseline] (8.214 ms) : 0, 8214
Telemetry [candidate] (8.294 ms) : 0, 8294
section appsec
BytebuddyAgent [baseline] (713.312 ms) : 0, 713312
BytebuddyAgent [candidate] (706.931 ms) : 0, 706931
GlobalTracer [baseline] (235.123 ms) : 0, 235123
GlobalTracer [candidate] (234.753 ms) : 0, 234753
AppSec [baseline] (171.081 ms) : 0, 171081
AppSec [candidate] (171.52 ms) : 0, 171520
Debugger [baseline] (5.692 ms) : 0, 5692
Debugger [candidate] (5.734 ms) : 0, 5734
Remote Config [baseline] (597.522 µs) : 0, 598
Remote Config [candidate] (598.519 µs) : 0, 599
Telemetry [baseline] (7.951 ms) : 0, 7951
Telemetry [candidate] (8.029 ms) : 0, 8029
IAST [baseline] (23.436 ms) : 0, 23436
IAST [candidate] (23.427 ms) : 0, 23427
section iast
BytebuddyAgent [baseline] (814.926 ms) : 0, 814926
BytebuddyAgent [candidate] (805.853 ms) : 0, 805853
GlobalTracer [baseline] (235.02 ms) : 0, 235020
GlobalTracer [candidate] (233.077 ms) : 0, 233077
AppSec [baseline] (29.301 ms) : 0, 29301
AppSec [candidate] (30.015 ms) : 0, 30015
Debugger [baseline] (6.694 ms) : 0, 6694
Debugger [candidate] (7.278 ms) : 0, 7278
Remote Config [baseline] (602.539 µs) : 0, 603
Remote Config [candidate] (593.876 µs) : 0, 594
Telemetry [baseline] (7.969 ms) : 0, 7969
Telemetry [candidate] (7.899 ms) : 0, 7899
IAST [baseline] (28.582 ms) : 0, 28582
IAST [candidate] (26.776 ms) : 0, 26776
section profiling
BytebuddyAgent [baseline] (675.458 ms) : 0, 675458
BytebuddyAgent [candidate] (680.176 ms) : 0, 680176
GlobalTracer [baseline] (361.227 ms) : 0, 361227
GlobalTracer [candidate] (362.52 ms) : 0, 362520
AppSec [baseline] (30.803 ms) : 0, 30803
AppSec [candidate] (31.749 ms) : 0, 31749
Debugger [baseline] (13.366 ms) : 0, 13366
Debugger [candidate] (11.295 ms) : 0, 11295
Remote Config [baseline] (659.21 µs) : 0, 659
Remote Config [candidate] (677.964 µs) : 0, 678
Telemetry [baseline] (8.026 ms) : 0, 8026
Telemetry [candidate] (9.501 ms) : 0, 9501
ProfilingAgent [baseline] (102.887 ms) : 0, 102887
ProfilingAgent [candidate] (104.076 ms) : 0, 104076
Profiling [baseline] (102.91 ms) : 0, 102910
Profiling [candidate] (104.102 ms) : 0, 104102
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~2f8a8ff169, baseline=1.52.0-SNAPSHOT~61685915b3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (994.287 ms) : 0, 994287
Total [baseline] (8.597 s) : 0, 8596643
Agent [candidate] (993.514 ms) : 0, 993514
Total [candidate] (8.591 s) : 0, 8590981
section iast
Agent [baseline] (1.139 s) : 0, 1139430
Total [baseline] (9.307 s) : 0, 9307053
Agent [candidate] (1.128 s) : 0, 1127675
Total [candidate] (9.281 s) : 0, 9281433
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~2f8a8ff169, baseline=1.52.0-SNAPSHOT~61685915b3
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.152 ms) : 0, 686152
BytebuddyAgent [candidate] (685.469 ms) : 0, 685469
GlobalTracer [baseline] (242.206 ms) : 0, 242206
GlobalTracer [candidate] (242.056 ms) : 0, 242056
AppSec [baseline] (30.257 ms) : 0, 30257
AppSec [candidate] (30.315 ms) : 0, 30315
Debugger [baseline] (5.971 ms) : 0, 5971
Debugger [candidate] (6.004 ms) : 0, 6004
Remote Config [baseline] (689.82 µs) : 0, 690
Remote Config [candidate] (686.695 µs) : 0, 687
Telemetry [baseline] (8.228 ms) : 0, 8228
Telemetry [candidate] (8.234 ms) : 0, 8234
section iast
BytebuddyAgent [baseline] (811.703 ms) : 0, 811703
BytebuddyAgent [candidate] (803.137 ms) : 0, 803137
GlobalTracer [baseline] (233.916 ms) : 0, 233916
GlobalTracer [candidate] (231.928 ms) : 0, 231928
AppSec [baseline] (29.294 ms) : 0, 29294
AppSec [candidate] (28.676 ms) : 0, 28676
Debugger [baseline] (7.553 ms) : 0, 7553
Debugger [candidate] (6.694 ms) : 0, 6694
Remote Config [baseline] (586.612 µs) : 0, 587
Remote Config [candidate] (588.856 µs) : 0, 589
Telemetry [baseline] (7.96 ms) : 0, 7960
Telemetry [candidate] (7.857 ms) : 0, 7857
IAST [baseline] (27.552 ms) : 0, 27552
IAST [candidate] (28.099 ms) : 0, 28099
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 5 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~2f8a8ff169, baseline=1.52.0-SNAPSHOT~61685915b3
dateFormat X
axisFormat %s
section baseline
no_agent (4.262 ms) : 4211, 4314
. : milestone, 4262,
iast (9.171 ms) : 9023, 9318
. : milestone, 9171,
iast_FULL (13.629 ms) : 13362, 13897
. : milestone, 13629,
iast_GLOBAL (9.936 ms) : 9761, 10111
. : milestone, 9936,
profiling (8.518 ms) : 8388, 8648
. : milestone, 8518,
tracing (7.752 ms) : 7641, 7862
. : milestone, 7752,
section candidate
no_agent (4.606 ms) : 4552, 4659
. : milestone, 4606,
iast (9.281 ms) : 9124, 9438
. : milestone, 9281,
iast_FULL (13.839 ms) : 13563, 14116
. : milestone, 13839,
iast_GLOBAL (10.072 ms) : 9896, 10248
. : milestone, 10072,
profiling (9.184 ms) : 9043, 9326
. : milestone, 9184,
tracing (7.626 ms) : 7519, 7733
. : milestone, 7626,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~2f8a8ff169, baseline=1.52.0-SNAPSHOT~61685915b3
dateFormat X
axisFormat %s
section baseline
no_agent (36.652 ms) : 36349, 36956
. : milestone, 36652,
appsec (45.659 ms) : 45254, 46065
. : milestone, 45659,
code_origins (47.64 ms) : 47226, 48053
. : milestone, 47640,
iast (44.923 ms) : 44525, 45321
. : milestone, 44923,
profiling (46.936 ms) : 46512, 47361
. : milestone, 46936,
tracing (42.272 ms) : 41936, 42608
. : milestone, 42272,
section candidate
no_agent (37.14 ms) : 36831, 37448
. : milestone, 37140,
appsec (47.321 ms) : 46898, 47745
. : milestone, 47321,
code_origins (45.339 ms) : 44950, 45728
. : milestone, 45339,
iast (44.014 ms) : 43626, 44402
. : milestone, 44014,
profiling (48.482 ms) : 48042, 48923
. : milestone, 48482,
tracing (44.535 ms) : 44162, 44908
. : milestone, 44535,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~2f8a8ff169, baseline=1.52.0-SNAPSHOT~61685915b3
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (2.424 ms) : 2374, 2474
. : milestone, 2424,
iast (2.212 ms) : 2150, 2275
. : milestone, 2212,
iast_GLOBAL (2.246 ms) : 2183, 2308
. : milestone, 2246,
profiling (2.056 ms) : 2005, 2107
. : milestone, 2056,
tracing (2.018 ms) : 1970, 2066
. : milestone, 2018,
section candidate
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (2.411 ms) : 2362, 2461
. : milestone, 2411,
iast (2.196 ms) : 2133, 2258
. : milestone, 2196,
iast_GLOBAL (2.249 ms) : 2187, 2312
. : milestone, 2249,
profiling (2.07 ms) : 2018, 2122
. : milestone, 2070,
tracing (2.026 ms) : 1977, 2075
. : milestone, 2026,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~2f8a8ff169, baseline=1.52.0-SNAPSHOT~61685915b3
dateFormat X
axisFormat %s
section baseline
no_agent (15.047 s) : 15047000, 15047000
. : milestone, 15047000,
appsec (15.068 s) : 15068000, 15068000
. : milestone, 15068000,
iast (18.706 s) : 18706000, 18706000
. : milestone, 18706000,
iast_GLOBAL (18.101 s) : 18101000, 18101000
. : milestone, 18101000,
profiling (15.052 s) : 15052000, 15052000
. : milestone, 15052000,
tracing (15.006 s) : 15006000, 15006000
. : milestone, 15006000,
section candidate
no_agent (15.397 s) : 15397000, 15397000
. : milestone, 15397000,
appsec (14.596 s) : 14596000, 14596000
. : milestone, 14596000,
iast (18.597 s) : 18597000, 18597000
. : milestone, 18597000,
iast_GLOBAL (18.188 s) : 18188000, 18188000
. : milestone, 18188000,
profiling (15.301 s) : 15301000, 15301000
. : milestone, 15301000,
tracing (14.764 s) : 14764000, 14764000
. : milestone, 14764000,
|
What Does This Do
Unifies truncation limits to prevent using different thresholds, it also aligns them with what is specified in the API Security RFC.
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]