-
Notifications
You must be signed in to change notification settings - Fork 309
Added logic to unwind and surface the potential root cause when an error occurs during the agent's premain initialization phase. #9170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ror occurs during the agent's premain initialization phase.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~2956153fd0, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1040344
Total [baseline] (8.662 s) : 0, 8661797
Agent [candidate] (1.044 s) : 0, 1044037
Total [candidate] (8.594 s) : 0, 8593788
section iast
Agent [baseline] (1.172 s) : 0, 1171815
Total [baseline] (9.278 s) : 0, 9278131
Agent [candidate] (1.169 s) : 0, 1169494
Total [candidate] (9.253 s) : 0, 9253169
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~2956153fd0, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.435 ms) : 0, 1435
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (730.649 ms) : 0, 730649
BytebuddyAgent [candidate] (734.847 ms) : 0, 734847
GlobalTracer [baseline] (241.192 ms) : 0, 241192
GlobalTracer [candidate] (241.407 ms) : 0, 241407
AppSec [baseline] (30.459 ms) : 0, 30459
AppSec [candidate] (30.44 ms) : 0, 30440
Debugger [baseline] (6.022 ms) : 0, 6022
Debugger [candidate] (6.023 ms) : 0, 6023
Remote Config [baseline] (651.462 µs) : 0, 651
Remote Config [candidate] (661.486 µs) : 0, 661
Telemetry [baseline] (8.976 ms) : 0, 8976
Telemetry [candidate] (8.238 ms) : 0, 8238
section iast
crashtracking [baseline] (1.434 ms) : 0, 1434
crashtracking [candidate] (1.426 ms) : 0, 1426
BytebuddyAgent [baseline] (847.223 ms) : 0, 847223
BytebuddyAgent [candidate] (844.933 ms) : 0, 844933
GlobalTracer [baseline] (231.859 ms) : 0, 231859
GlobalTracer [candidate] (230.432 ms) : 0, 230432
IAST [baseline] (27.86 ms) : 0, 27860
IAST [candidate] (28.999 ms) : 0, 28999
AppSec [baseline] (28.431 ms) : 0, 28431
AppSec [candidate] (28.717 ms) : 0, 28717
Debugger [baseline] (5.753 ms) : 0, 5753
Debugger [candidate] (5.712 ms) : 0, 5712
Remote Config [baseline] (581.534 µs) : 0, 582
Remote Config [candidate] (575.04 µs) : 0, 575
Telemetry [baseline] (7.883 ms) : 0, 7883
Telemetry [candidate] (7.901 ms) : 0, 7901
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~2956153fd0, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1043453
Total [baseline] (10.623 s) : 0, 10622910
Agent [candidate] (1.039 s) : 0, 1039305
Total [candidate] (10.691 s) : 0, 10691337
section appsec
Agent [baseline] (1.216 s) : 0, 1215776
Total [baseline] (10.728 s) : 0, 10727503
Agent [candidate] (1.217 s) : 0, 1217410
Total [candidate] (10.778 s) : 0, 10777828
section iast
Agent [baseline] (1.179 s) : 0, 1179390
Total [baseline] (10.835 s) : 0, 10834947
Agent [candidate] (1.183 s) : 0, 1182756
Total [candidate] (10.934 s) : 0, 10934440
section profiling
Agent [baseline] (1.182 s) : 0, 1181851
Total [baseline] (10.872 s) : 0, 10871723
Agent [candidate] (1.191 s) : 0, 1190831
Total [candidate] (10.86 s) : 0, 10859801
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~2956153fd0, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.427 ms) : 0, 1427
BytebuddyAgent [baseline] (733.533 ms) : 0, 733533
BytebuddyAgent [candidate] (730.523 ms) : 0, 730523
GlobalTracer [baseline] (242.024 ms) : 0, 242024
GlobalTracer [candidate] (240.997 ms) : 0, 240997
AppSec [baseline] (30.538 ms) : 0, 30538
AppSec [candidate] (30.63 ms) : 0, 30630
Debugger [baseline] (6.03 ms) : 0, 6030
Debugger [candidate] (6.009 ms) : 0, 6009
Remote Config [baseline] (654.544 µs) : 0, 655
Remote Config [candidate] (653.017 µs) : 0, 653
Telemetry [baseline] (8.224 ms) : 0, 8224
Telemetry [candidate] (8.177 ms) : 0, 8177
section appsec
crashtracking [baseline] (1.428 ms) : 0, 1428
crashtracking [candidate] (1.438 ms) : 0, 1438
BytebuddyAgent [baseline] (751.838 ms) : 0, 751838
BytebuddyAgent [candidate] (752.004 ms) : 0, 752004
GlobalTracer [baseline] (233.239 ms) : 0, 233239
GlobalTracer [candidate] (233.705 ms) : 0, 233705
IAST [baseline] (23.546 ms) : 0, 23546
IAST [candidate] (23.439 ms) : 0, 23439
AppSec [baseline] (168.064 ms) : 0, 168064
AppSec [candidate] (166.749 ms) : 0, 166749
Debugger [baseline] (7.149 ms) : 0, 7149
Debugger [candidate] (9.348 ms) : 0, 9348
Remote Config [baseline] (600.35 µs) : 0, 600
Remote Config [candidate] (601.04 µs) : 0, 601
Telemetry [baseline] (8.782 ms) : 0, 8782
Telemetry [candidate] (8.902 ms) : 0, 8902
section iast
crashtracking [baseline] (1.446 ms) : 0, 1446
crashtracking [candidate] (1.438 ms) : 0, 1438
BytebuddyAgent [baseline] (852.794 ms) : 0, 852794
BytebuddyAgent [candidate] (854.43 ms) : 0, 854430
GlobalTracer [baseline] (232.683 ms) : 0, 232683
GlobalTracer [candidate] (232.629 ms) : 0, 232629
IAST [baseline] (27.54 ms) : 0, 27540
IAST [candidate] (28.59 ms) : 0, 28590
AppSec [baseline] (28.044 ms) : 0, 28044
AppSec [candidate] (26.723 ms) : 0, 26723
Debugger [baseline] (7.46 ms) : 0, 7460
Debugger [candidate] (9.288 ms) : 0, 9288
Remote Config [baseline] (583.815 µs) : 0, 584
Remote Config [candidate] (592.852 µs) : 0, 593
Telemetry [baseline] (7.858 ms) : 0, 7858
Telemetry [candidate] (8.016 ms) : 0, 8016
section profiling
crashtracking [baseline] (1.4 ms) : 0, 1400
crashtracking [candidate] (1.407 ms) : 0, 1407
BytebuddyAgent [baseline] (758.52 ms) : 0, 758520
BytebuddyAgent [candidate] (763.929 ms) : 0, 763929
GlobalTracer [baseline] (220.084 ms) : 0, 220084
GlobalTracer [candidate] (221.393 ms) : 0, 221393
AppSec [baseline] (30.196 ms) : 0, 30196
AppSec [candidate] (30.663 ms) : 0, 30663
Debugger [baseline] (6.276 ms) : 0, 6276
Debugger [candidate] (6.415 ms) : 0, 6415
Remote Config [baseline] (655.641 µs) : 0, 656
Remote Config [candidate] (683.088 µs) : 0, 683
Telemetry [baseline] (13.381 ms) : 0, 13381
Telemetry [candidate] (11.927 ms) : 0, 11927
ProfilingAgent [baseline] (102.986 ms) : 0, 102986
ProfilingAgent [candidate] (105.747 ms) : 0, 105747
Profiling [baseline] (103.008 ms) : 0, 103008
Profiling [candidate] (105.769 ms) : 0, 105769
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~2956153fd0, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section baseline
no_agent (36.892 ms) : 36590, 37195
. : milestone, 36892,
appsec (48.469 ms) : 48032, 48905
. : milestone, 48469,
code_origins (44.489 ms) : 44108, 44869
. : milestone, 44489,
iast (45.7 ms) : 45295, 46105
. : milestone, 45700,
profiling (48.166 ms) : 47731, 48601
. : milestone, 48166,
tracing (43.232 ms) : 42879, 43585
. : milestone, 43232,
section candidate
no_agent (37.05 ms) : 36753, 37347
. : milestone, 37050,
appsec (48.23 ms) : 47802, 48657
. : milestone, 48230,
code_origins (45.861 ms) : 45453, 46269
. : milestone, 45861,
iast (43.987 ms) : 43611, 44362
. : milestone, 43987,
profiling (48.268 ms) : 47797, 48738
. : milestone, 48268,
tracing (44.601 ms) : 44227, 44974
. : milestone, 44601,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~2956153fd0, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section baseline
no_agent (4.465 ms) : 4414, 4515
. : milestone, 4465,
iast (9.367 ms) : 9214, 9521
. : milestone, 9367,
iast_FULL (14.126 ms) : 13847, 14405
. : milestone, 14126,
iast_GLOBAL (9.978 ms) : 9802, 10155
. : milestone, 9978,
profiling (8.738 ms) : 8605, 8871
. : milestone, 8738,
tracing (7.328 ms) : 7224, 7432
. : milestone, 7328,
section candidate
no_agent (4.348 ms) : 4299, 4396
. : milestone, 4348,
iast (9.364 ms) : 9210, 9517
. : milestone, 9364,
iast_FULL (14.076 ms) : 13800, 14352
. : milestone, 14076,
iast_GLOBAL (10.219 ms) : 10028, 10410
. : milestone, 10219,
profiling (8.94 ms) : 8787, 9092
. : milestone, 8940,
tracing (7.225 ms) : 7125, 7324
. : milestone, 7225,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~2956153fd0, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.651 ms) : 3435, 3867
. : milestone, 3651,
iast (2.198 ms) : 2135, 2261
. : milestone, 2198,
iast_GLOBAL (2.245 ms) : 2182, 2308
. : milestone, 2245,
profiling (2.042 ms) : 1992, 2093
. : milestone, 2042,
tracing (2.014 ms) : 1966, 2063
. : milestone, 2014,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.665 ms) : 3451, 3880
. : milestone, 3665,
iast (2.197 ms) : 2135, 2260
. : milestone, 2197,
iast_GLOBAL (2.247 ms) : 2184, 2310
. : milestone, 2247,
profiling (2.061 ms) : 2010, 2113
. : milestone, 2061,
tracing (2.012 ms) : 1964, 2061
. : milestone, 2012,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~2956153fd0, baseline=1.52.0-SNAPSHOT~2fe6aa2d23
dateFormat X
axisFormat %s
section baseline
no_agent (15.646 s) : 15646000, 15646000
. : milestone, 15646000,
appsec (14.754 s) : 14754000, 14754000
. : milestone, 14754000,
iast (18.302 s) : 18302000, 18302000
. : milestone, 18302000,
iast_GLOBAL (18.227 s) : 18227000, 18227000
. : milestone, 18227000,
profiling (15.924 s) : 15924000, 15924000
. : milestone, 15924000,
tracing (14.649 s) : 14649000, 14649000
. : milestone, 14649000,
section candidate
no_agent (14.924 s) : 14924000, 14924000
. : milestone, 14924000,
appsec (15.002 s) : 15002000, 15002000
. : milestone, 15002000,
iast (18.421 s) : 18421000, 18421000
. : milestone, 18421000,
iast_GLOBAL (18.012 s) : 18012000, 18012000
. : milestone, 18012000,
profiling (15.507 s) : 15507000, 15507000
. : milestone, 15507000,
tracing (14.994 s) : 14994000, 14994000
. : milestone, 14994000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! To check my understanding -- this now returns the "top cause" (i.e. what was originally returned) along with the most root causes (max 4 levels of this).
@sarahchen6 Yes, by default it will return the top one (as before) and up to 4 from the most root. |
components/environment/src/main/java/datadog/environment/EnvironmentVariables.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comment about the keeping the environment component with a single responsibility and avoiding to create another config system.
What Does This Do
Added logic to unwind and surface the potential root cause when an error occurs during the agent's pre-main initialization phase.
Motivation
Add more context in case of error during pre-main step.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]