-
Notifications
You must be signed in to change notification settings - Fork 309
🍒 9165 - Fix NPE in AppSecConfigServiceImpl #9172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
manuel-alvarez-alvarez
merged 1 commit into
release/v1.51.x
from
malvarez/backport-pr-9165
Jul 15, 2025
Merged
🍒 9165 - Fix NPE in AppSecConfigServiceImpl #9172
manuel-alvarez-alvarez
merged 1 commit into
release/v1.51.x
from
malvarez/backport-pr-9165
Jul 15, 2025
+80
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 9a188f8)
amarziali
approved these changes
Jul 15, 2025
jandro996
approved these changes
Jul 15, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~9c11cc2fb0, baseline=1.52.0-SNAPSHOT~51532a82ba
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (993.769 ms) : 0, 993769
Total [baseline] (8.577 s) : 0, 8576685
Agent [candidate] (1.002 s) : 0, 1002355
Total [candidate] (8.567 s) : 0, 8567350
section iast
Agent [baseline] (1.129 s) : 0, 1129166
Total [baseline] (9.281 s) : 0, 9280927
Agent [candidate] (1.134 s) : 0, 1134262
Total [candidate] (9.278 s) : 0, 9278199
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~9c11cc2fb0, baseline=1.52.0-SNAPSHOT~51532a82ba
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.989 ms) : 0, 685989
BytebuddyAgent [candidate] (692.465 ms) : 0, 692465
GlobalTracer [baseline] (241.836 ms) : 0, 241836
GlobalTracer [candidate] (243.228 ms) : 0, 243228
AppSec [baseline] (30.409 ms) : 0, 30409
AppSec [candidate] (30.807 ms) : 0, 30807
Debugger [baseline] (5.956 ms) : 0, 5956
Debugger [candidate] (6.034 ms) : 0, 6034
Remote Config [baseline] (674.887 µs) : 0, 675
Remote Config [candidate] (683.954 µs) : 0, 684
Telemetry [baseline] (8.212 ms) : 0, 8212
Telemetry [candidate] (8.291 ms) : 0, 8291
section iast
BytebuddyAgent [baseline] (804.056 ms) : 0, 804056
BytebuddyAgent [candidate] (810.779 ms) : 0, 810779
GlobalTracer [baseline] (232.534 ms) : 0, 232534
GlobalTracer [candidate] (230.974 ms) : 0, 230974
IAST [baseline] (26.32 ms) : 0, 26320
IAST [candidate] (27.704 ms) : 0, 27704
AppSec [baseline] (31.45 ms) : 0, 31450
AppSec [candidate] (29.835 ms) : 0, 29835
Debugger [baseline] (5.691 ms) : 0, 5691
Debugger [candidate] (5.723 ms) : 0, 5723
Remote Config [baseline] (576.489 µs) : 0, 576
Remote Config [candidate] (575.242 µs) : 0, 575
Telemetry [baseline] (7.913 ms) : 0, 7913
Telemetry [candidate] (7.874 ms) : 0, 7874
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~9c11cc2fb0, baseline=1.52.0-SNAPSHOT~51532a82ba
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (995.874 ms) : 0, 995874
Total [baseline] (10.746 s) : 0, 10745755
Agent [candidate] (995.63 ms) : 0, 995630
Total [candidate] (10.61 s) : 0, 10610425
section appsec
Agent [baseline] (1.174 s) : 0, 1173922
Total [baseline] (10.897 s) : 0, 10897034
Agent [candidate] (1.173 s) : 0, 1172649
Total [candidate] (10.799 s) : 0, 10798832
section iast
Agent [baseline] (1.138 s) : 0, 1138215
Total [baseline] (10.838 s) : 0, 10837576
Agent [candidate] (1.133 s) : 0, 1133111
Total [candidate] (10.835 s) : 0, 10834544
section profiling
Agent [baseline] (1.243 s) : 0, 1242530
Total [baseline] (10.984 s) : 0, 10984466
Agent [candidate] (1.251 s) : 0, 1251390
Total [candidate] (10.947 s) : 0, 10946794
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~9c11cc2fb0, baseline=1.52.0-SNAPSHOT~51532a82ba
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.226 ms) : 0, 687226
BytebuddyAgent [candidate] (687.869 ms) : 0, 687869
GlobalTracer [baseline] (242.457 ms) : 0, 242457
GlobalTracer [candidate] (241.767 ms) : 0, 241767
AppSec [baseline] (30.52 ms) : 0, 30520
AppSec [candidate] (30.446 ms) : 0, 30446
Debugger [baseline] (5.952 ms) : 0, 5952
Debugger [candidate] (5.946 ms) : 0, 5946
Remote Config [baseline] (674.846 µs) : 0, 675
Remote Config [candidate] (672.898 µs) : 0, 673
Telemetry [baseline] (8.232 ms) : 0, 8232
Telemetry [candidate] (8.222 ms) : 0, 8222
section appsec
BytebuddyAgent [baseline] (708.729 ms) : 0, 708729
BytebuddyAgent [candidate] (709.071 ms) : 0, 709071
GlobalTracer [baseline] (234.947 ms) : 0, 234947
GlobalTracer [candidate] (234.615 ms) : 0, 234615
IAST [baseline] (23.614 ms) : 0, 23614
IAST [candidate] (23.29 ms) : 0, 23290
AppSec [baseline] (171.295 ms) : 0, 171295
AppSec [candidate] (170.429 ms) : 0, 170429
Debugger [baseline] (5.767 ms) : 0, 5767
Debugger [candidate] (5.702 ms) : 0, 5702
Remote Config [baseline] (617.47 µs) : 0, 617
Remote Config [candidate] (597.832 µs) : 0, 598
Telemetry [baseline] (8.12 ms) : 0, 8120
Telemetry [candidate] (8.04 ms) : 0, 8040
section iast
BytebuddyAgent [baseline] (810.801 ms) : 0, 810801
BytebuddyAgent [candidate] (807.924 ms) : 0, 807924
GlobalTracer [baseline] (233.725 ms) : 0, 233725
GlobalTracer [candidate] (232.319 ms) : 0, 232319
IAST [baseline] (29.083 ms) : 0, 29083
IAST [candidate] (27.899 ms) : 0, 27899
AppSec [baseline] (29.385 ms) : 0, 29385
AppSec [candidate] (29.898 ms) : 0, 29898
Debugger [baseline] (5.778 ms) : 0, 5778
Debugger [candidate] (5.772 ms) : 0, 5772
Remote Config [baseline] (599.576 µs) : 0, 600
Remote Config [candidate] (584.34 µs) : 0, 584
Telemetry [baseline] (7.977 ms) : 0, 7977
Telemetry [candidate] (7.95 ms) : 0, 7950
section profiling
BytebuddyAgent [baseline] (676.843 ms) : 0, 676843
BytebuddyAgent [candidate] (682.119 ms) : 0, 682119
GlobalTracer [baseline] (360.916 ms) : 0, 360916
GlobalTracer [candidate] (362.829 ms) : 0, 362829
AppSec [baseline] (34.669 ms) : 0, 34669
AppSec [candidate] (34.865 ms) : 0, 34865
Debugger [baseline] (9.76 ms) : 0, 9760
Debugger [candidate] (8.352 ms) : 0, 8352
Remote Config [baseline] (667.833 µs) : 0, 668
Remote Config [candidate] (666.922 µs) : 0, 667
Telemetry [baseline] (7.975 ms) : 0, 7975
Telemetry [candidate] (9.528 ms) : 0, 9528
ProfilingAgent [baseline] (103.157 ms) : 0, 103157
ProfilingAgent [candidate] (104.192 ms) : 0, 104192
Profiling [baseline] (103.182 ms) : 0, 103182
Profiling [candidate] (104.217 ms) : 0, 104217
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~9c11cc2fb0, baseline=1.52.0-SNAPSHOT~51532a82ba
dateFormat X
axisFormat %s
section baseline
no_agent (36.82 ms) : 36525, 37115
. : milestone, 36820,
appsec (48.362 ms) : 47932, 48792
. : milestone, 48362,
code_origins (45.271 ms) : 44885, 45657
. : milestone, 45271,
iast (45.786 ms) : 45388, 46185
. : milestone, 45786,
profiling (46.992 ms) : 46559, 47425
. : milestone, 46992,
tracing (44.96 ms) : 44580, 45340
. : milestone, 44960,
section candidate
no_agent (37.441 ms) : 37144, 37738
. : milestone, 37441,
appsec (48.301 ms) : 47859, 48744
. : milestone, 48301,
code_origins (46.503 ms) : 46118, 46889
. : milestone, 46503,
iast (43.74 ms) : 43366, 44114
. : milestone, 43740,
profiling (48.096 ms) : 47638, 48553
. : milestone, 48096,
tracing (42.562 ms) : 42210, 42915
. : milestone, 42562,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~9c11cc2fb0, baseline=1.52.0-SNAPSHOT~51532a82ba
dateFormat X
axisFormat %s
section baseline
no_agent (4.404 ms) : 4355, 4453
. : milestone, 4404,
iast (9.068 ms) : 8914, 9222
. : milestone, 9068,
iast_FULL (13.97 ms) : 13691, 14249
. : milestone, 13970,
iast_GLOBAL (10.403 ms) : 10220, 10586
. : milestone, 10403,
profiling (8.808 ms) : 8671, 8945
. : milestone, 8808,
tracing (7.511 ms) : 7405, 7617
. : milestone, 7511,
section candidate
no_agent (4.444 ms) : 4395, 4493
. : milestone, 4444,
iast (9.118 ms) : 8969, 9267
. : milestone, 9118,
iast_FULL (14.323 ms) : 14033, 14613
. : milestone, 14323,
iast_GLOBAL (10.329 ms) : 10134, 10524
. : milestone, 10329,
profiling (8.668 ms) : 8522, 8814
. : milestone, 8668,
tracing (7.273 ms) : 7172, 7375
. : milestone, 7273,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~9c11cc2fb0, baseline=1.52.0-SNAPSHOT~51532a82ba
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1489
. : milestone, 1477,
appsec (2.413 ms) : 2363, 2463
. : milestone, 2413,
iast (2.197 ms) : 2135, 2260
. : milestone, 2197,
iast_GLOBAL (2.252 ms) : 2189, 2315
. : milestone, 2252,
profiling (2.065 ms) : 2014, 2117
. : milestone, 2065,
tracing (2.028 ms) : 1979, 2077
. : milestone, 2028,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.417 ms) : 2367, 2467
. : milestone, 2417,
iast (2.209 ms) : 2146, 2272
. : milestone, 2209,
iast_GLOBAL (2.249 ms) : 2186, 2312
. : milestone, 2249,
profiling (2.061 ms) : 2008, 2113
. : milestone, 2061,
tracing (2.031 ms) : 1981, 2080
. : milestone, 2031,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~9c11cc2fb0, baseline=1.52.0-SNAPSHOT~51532a82ba
dateFormat X
axisFormat %s
section baseline
no_agent (15.803 s) : 15803000, 15803000
. : milestone, 15803000,
appsec (15.012 s) : 15012000, 15012000
. : milestone, 15012000,
iast (18.484 s) : 18484000, 18484000
. : milestone, 18484000,
iast_GLOBAL (17.701 s) : 17701000, 17701000
. : milestone, 17701000,
profiling (14.828 s) : 14828000, 14828000
. : milestone, 14828000,
tracing (14.87 s) : 14870000, 14870000
. : milestone, 14870000,
section candidate
no_agent (15.588 s) : 15588000, 15588000
. : milestone, 15588000,
appsec (14.642 s) : 14642000, 14642000
. : milestone, 14642000,
iast (18.418 s) : 18418000, 18418000
. : milestone, 18418000,
iast_GLOBAL (17.671 s) : 17671000, 17671000
. : milestone, 17671000,
profiling (15.745 s) : 15745000, 15745000
. : milestone, 15745000,
tracing (14.788 s) : 14788000, 14788000
. : milestone, 14788000,
|
svc-squareup-copybara
pushed a commit
to cashapp/misk
that referenced
this pull request
Jul 16, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [app.cash.tempest:tempest-bom](https://github.com/cashapp/tempest) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2025.07.08.171526-e297588` -> `2025.07.15.155806-c1415e3` | | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `6.97.0` -> `6.97.1` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.51.0` -> `1.51.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.31.78` -> `2.32.1` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.31.78` -> `2.32.1` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.31.78` -> `2.32.1` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.31.78` -> `2.32.1` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.31.78` -> `2.32.1` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.31.78` -> `2.32.1` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.31.78` -> `2.32.1` | | [com.amazonaws:aws-java-sdk-sqs](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.787` -> `1.12.788` | | [com.amazonaws:aws-java-sdk-s3](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.787` -> `1.12.788` | | [com.amazonaws:aws-java-sdk-dynamodb](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.787` -> `1.12.788` | | [com.amazonaws:aws-java-sdk-core](https://aws.amazon.com/sdkforjava) ([source](https://github.com/aws/aws-sdk-java)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.12.787` -> `1.12.788` | --- ### Release Notes <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.97.1`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6971-2025-07-15) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.50.1 ([#​3992](googleapis/java-spanner#3992)) ([69ffd72](googleapis/java-spanner@69ffd72)) - Update googleapis/sdk-platform-java action to v2.60.1 ([#​3926](googleapis/java-spanner#3926)) ([7001b7f](googleapis/java-spanner@7001b7f)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.51.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.51.1): 1.51.1 ### Components #### Application Security Management (WAF) - 🐛 Fix NPE in AppSecConfigServiceImpl ([#​9172](DataDog/dd-trace-java#9172) - [@​manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) #### Tracer core - 🐛 Avoid race conditions on feature discovery ([#​9175](DataDog/dd-trace-java#9175), [#​9177](DataDog/dd-trace-java#9177) - [@​daniel-mohedano](https://github.com/daniel-mohedano), [@​amarziali](https://github.com/amarziali) ) </details> <details> <summary>aws/aws-sdk-java (com.amazonaws:aws-java-sdk-sqs)</summary> ### [`v1.12.788`](https://github.com/aws/aws-sdk-java/blob/HEAD/CHANGELOG.md#112788-2025-07-11) [Compare Source](aws/aws-sdk-java@1.12.787...1.12.788) #### **AWS SDK for Java** - ### Features - Add account endpoint caching #### **Amazon DynamoDB** - ### Features - Cache account endpoint URIs </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 27a8b093249f74e7c13544759c5baf5d1acdc371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #9165 to release/v1.51.x