test: ignore Node http socketErrorListener leak#8177
Merged
Conversation
This stops `MaxListenersExceededWarning` from crashing the test process on Node v24.15.0, which leaks an internal `socketErrorListener` on every keep-alive agent socket reuse. Tests that issue several requests through the same socket — `instrumentation-http` and the RASP fastify blocking suite are the current victims — pile up enough listeners to trip our strict `defaultMaxListeners=6` and crash via the warning rethrow. Detect the leak by its stable signature: two or more listeners named `socketErrorListener` on the same emitter for event `error`. The upstream fix is merged on Node `main` but not yet released in v24.x; once it ships the duplicates disappear and the detector returns false again, so real listener leaks resume throwing. Refs: nodejs/node#61770 Refs: nodejs/node#62872
Contributor
Overall package sizeSelf size: 5.67 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.1 | 82.56 kB | 817.39 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: caf535b | Docs | Datadog PR Page | Give us feedback! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0a0267646
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
BenchmarksBenchmark execution time: 2026-04-29 20:56:51 Comparing candidate commit caf535b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1346 metrics, 98 unstable metrics. |
rochdev
previously approved these changes
Apr 29, 2026
BridgeAR
force-pushed
the
BridgeAR/2026-04-29-work-around-event-leak
branch
from
274ead6 to
caf535b
Compare
rochdev
approved these changes
Apr 29, 2026
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Apr 30, 2026
This stops `MaxListenersExceededWarning` from crashing the test process on Node v24.15.0, which leaks an internal `socketErrorListener` on every keep-alive agent socket reuse. Tests that issue several requests through the same socket — `instrumentation-http` and the RASP fastify blocking suite are the current victims — pile up enough listeners to trip our strict `defaultMaxListeners=6` and crash via the warning rethrow. Detect the leak by its stable signature: two or more listeners named `socketErrorListener` on the same emitter for event `error`. The upstream fix is merged on Node `main` but not yet released in v24.x; once it ships the duplicates disappear and the detector returns false again, so real listener leaks resume throwing. Refs: nodejs/node#61770 Refs: nodejs/node#62872
Merged
BridgeAR
added a commit
that referenced
this pull request
Apr 30, 2026
This stops `MaxListenersExceededWarning` from crashing the test process on Node v24.15.0, which leaks an internal `socketErrorListener` on every keep-alive agent socket reuse. Tests that issue several requests through the same socket — `instrumentation-http` and the RASP fastify blocking suite are the current victims — pile up enough listeners to trip our strict `defaultMaxListeners=6` and crash via the warning rethrow. Detect the leak by its stable signature: two or more listeners named `socketErrorListener` on the same emitter for event `error`. The upstream fix is merged on Node `main` but not yet released in v24.x; once it ships the duplicates disappear and the detector returns false again, so real listener leaks resume throwing. Refs: nodejs/node#61770 Refs: nodejs/node#62872
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stops
MaxListenersExceededWarningfrom crashing the test process on Node v24.15.0, which leaks an internalsocketErrorListeneron every keep-alive agent socket reuse. Tests that issue several requests through the same socket —instrumentation-httpand the RASP fastify blocking suite are the current victims — pile up enough listeners to trip our strictdefaultMaxListeners=6and crash via the warning rethrow.Detect the leak by its stable signature: two or more listeners named
socketErrorListeneron the same emitter for eventerror. The upstream fix is merged on Nodemainbut not yet released in v24.x; once it ships the duplicates disappear and the detector returns false again, so real listener leaks resume throwing.Refs: nodejs/node#61770
Refs: nodejs/node#62872