Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: auto opt in all PRs to backport to 2.21 #12967

Merged
merged 5 commits into from
Apr 2, 2025

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Mar 29, 2025

Quick GitHub workflow to always label PRs with backport 2.21 so backporting to the 2.21 branch is an opt OUT, not an opt IN. This should help prevent critical backports from being missed in the 2.21 branch.

It will only skip PRs that are already backports, but by depending on the PR title.

Tested with this PR.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

.github/workflows/add-2x-backport-tag.yml                               @DataDog/python-guild @DataDog/apm-core-python

@erikayasuda erikayasuda changed the title chore: auto opt in all PRs to backport to 2.21 chore: auto opt in all PRs to backport to 2.21 [backport 3.0] Mar 29, 2025
@erikayasuda erikayasuda reopened this Mar 29, 2025
@erikayasuda erikayasuda changed the title chore: auto opt in all PRs to backport to 2.21 [backport 3.0] chore: auto opt in all PRs to backport to 2.21 Mar 29, 2025
@erikayasuda erikayasuda reopened this Mar 29, 2025
@erikayasuda erikayasuda marked this pull request as ready for review March 29, 2025 03:16
@erikayasuda erikayasuda requested review from a team as code owners March 29, 2025 03:16
@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Mar 29, 2025
Copy link
Contributor

github-actions bot commented Mar 29, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 232 ± 5 ms.

The average import time from base is: 234 ± 4 ms.

The import time difference between this PR and base is: -1.5 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.914 ms (0.82%)
ddtrace.bootstrap.sitecustomize 1.269 ms (0.55%)
ddtrace.bootstrap.preload 1.269 ms (0.55%)
ddtrace.internal.products 1.269 ms (0.55%)
ddtrace.internal.remoteconfig.client 0.624 ms (0.27%)
ddtrace 0.645 ms (0.28%)

@pr-commenter
Copy link

pr-commenter bot commented Mar 29, 2025

Benchmarks

Benchmark execution time: 2025-04-02 17:50:26

Comparing candidate commit 513efe9 in PR branch erikayasuda/auto-backport-2.21 with baseline commit 4c46271 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 498 metrics, 2 unstable metrics.

@erikayasuda erikayasuda requested a review from P403n1x87 April 1, 2025 15:15
@erikayasuda erikayasuda enabled auto-merge (squash) April 1, 2025 15:16
@erikayasuda erikayasuda merged commit 306489d into main Apr 2, 2025
332 of 333 checks passed
@erikayasuda erikayasuda deleted the erikayasuda/auto-backport-2.21 branch April 2, 2025 17:51
chojomok pushed a commit that referenced this pull request Apr 7, 2025
Quick GitHub workflow to always label PRs with `backport 2.21` so
backporting to the 2.21 branch is an opt OUT, not an opt IN. This should
help prevent critical backports from being missed in the 2.21 branch.

It will only skip PRs that are already backports, but by depending on
the PR title.

Tested with this PR.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants