Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(asm): add waf and rasp errors span tags #12981

Merged
merged 5 commits into from
Apr 1, 2025

Conversation

christophe-papazian
Copy link
Contributor

@christophe-papazian christophe-papazian commented Mar 31, 2025

APPSEC-56592

  • add waf error and rasp error (private) span tags
  • update relevant tests

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@christophe-papazian christophe-papazian added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Mar 31, 2025
Copy link
Contributor

github-actions bot commented Mar 31, 2025

CODEOWNERS have been resolved as:

ddtrace/appsec/_constants.py                                            @DataDog/asm-python
ddtrace/appsec/_processor.py                                            @DataDog/asm-python
tests/appsec/appsec/test_processor.py                                   @DataDog/asm-python
tests/appsec/appsec/test_telemetry.py                                   @DataDog/asm-python

Copy link
Contributor

github-actions bot commented Mar 31, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 232 ± 4 ms.

The average import time from base is: 233 ± 3 ms.

The import time difference between this PR and base is: -1.5 ± 0.2 ms.

Import time breakdown

The following import paths have grown:

ddtrace.auto 1.062 ms (0.46%)
ddtrace.bootstrap.sitecustomize 0.981 ms (0.42%)
ddtrace.bootstrap.preload 0.981 ms (0.42%)
ddtrace.internal.products 0.981 ms (0.42%)
importlib.metadata 0.905 ms (0.39%)
importlib.abc 0.797 ms (0.34%)
importlib.resources 0.069 ms (0.03%)
csv 0.108 ms (0.05%)
_csv 0.108 ms (0.05%)
ddtrace.internal.remoteconfig._connectors 0.076 ms (0.03%)
ctypes 0.076 ms (0.03%)
ddtrace 0.080 ms (0.03%)
ddtrace.trace 0.080 ms (0.03%)
ddtrace._trace.tracer 0.080 ms (0.03%)
ddtrace.internal.schema.processor 0.080 ms (0.03%)

The following import paths have shrunk:

ddtrace.auto 3.020 ms (1.30%)
ddtrace.bootstrap.sitecustomize 2.276 ms (0.98%)
ddtrace.bootstrap.preload 2.276 ms (0.98%)
ddtrace.internal.products 2.276 ms (0.98%)
importlib.metadata 0.910 ms (0.39%)
importlib.abc 0.730 ms (0.32%)
importlib.resources 0.730 ms (0.32%)
importlib.resources._legacy 0.730 ms (0.32%)
csv 0.111 ms (0.05%)
importlib.metadata._itertools 0.069 ms (0.03%)
ddtrace.internal.remoteconfig.client 0.624 ms (0.27%)
ddtrace.debugging._config 0.079 ms (0.03%)
ddtrace.settings.exception_replay 0.079 ms (0.03%)
ddtrace.internal.remoteconfig._connectors 0.077 ms (0.03%)
ctypes 0.077 ms (0.03%)
_ctypes 0.077 ms (0.03%)
ddtrace 0.744 ms (0.32%)
ddtrace.trace 0.086 ms (0.04%)
ddtrace._trace.tracer 0.086 ms (0.04%)
ddtrace.internal.processor.endpoint_call_counter 0.086 ms (0.04%)

@pr-commenter
Copy link

pr-commenter bot commented Mar 31, 2025

Benchmarks

Benchmark execution time: 2025-04-01 09:11:14

Comparing candidate commit b49dc46 in PR branch christophe-papazian/waf_error_tags with baseline commit 961a8dc in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 498 metrics, 2 unstable metrics.

Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/appsec/_constants.py                                            @DataDog/asm-python
ddtrace/appsec/_processor.py                                            @DataDog/asm-python
tests/appsec/appsec/test_processor.py                                   @DataDog/asm-python

1 similar comment
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/appsec/_constants.py                                            @DataDog/asm-python
ddtrace/appsec/_processor.py                                            @DataDog/asm-python
tests/appsec/appsec/test_processor.py                                   @DataDog/asm-python

@christophe-papazian christophe-papazian marked this pull request as ready for review April 1, 2025 09:10
@christophe-papazian christophe-papazian requested a review from a team as a code owner April 1, 2025 09:10
@avara1986 avara1986 merged commit 294ea72 into main Apr 1, 2025
469 checks passed
@avara1986 avara1986 deleted the christophe-papazian/waf_error_tags branch April 1, 2025 11:09
chojomok pushed a commit that referenced this pull request Apr 7, 2025
APPSEC-56592

- add waf error and rasp error (private) span tags
- update relevant tests

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants