refactor: configuration instance [recreated] #12991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We move the creation of the configuration instance in the module where the class itself is defined. We then update the imports to grab a reference directly from the settings module, instead of the root module ddtrace. This way we remove a substantial number of circular import paths within the library.
|
|
P403n1x87
approved these changes
Mar 31, 2025
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 230 ± 5 ms. The average import time from base is: 234 ± 5 ms. The import time difference between this PR and base is: -4.1 ± 0.2 ms. Import time breakdownThe following import paths have appeared:
|
erikayasuda
added
the
changelog/no-changelog
emmettbutler
approved these changes
Apr 1, 2025
juanjux
approved these changes
Apr 2, 2025
avara1986
approved these changes
Apr 3, 2025
|
|
wantsui
approved these changes
Apr 3, 2025
mabdinur
approved these changes
Apr 3, 2025
gnufede
approved these changes
Apr 3, 2025
chojomok
pushed a commit
that referenced
this pull request
Apr 7, 2025
Recreating #12970 because we needed to revert PRs that were accidentally merged prematurely due to required status checks getting deleted. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: Gabriele N. Tornetta <[email protected]> Co-authored-by: Gabriele N. Tornetta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreating #12970 because we needed to revert PRs that were accidentally merged prematurely due to required status checks getting deleted.
Checklist
Reviewer Checklist