Skip to content

chore(ci_visibility): fetch test data concurrently [recreated] #12993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Mar 31, 2025

Recreating #12972 because we needed to revert PRs that were accidentally merged prematurely due to required status checks getting deleted.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/internal/ci_visibility/recorder.py                              @DataDog/ci-app-libraries

Copy link
Contributor

github-actions bot commented Mar 31, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 229 ± 3 ms.

The average import time from base is: 238 ± 7 ms.

The import time difference between this PR and base is: -9.3 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 4.373 ms (1.91%)
ddtrace.bootstrap.sitecustomize 2.656 ms (1.16%)
ddtrace.bootstrap.preload 2.560 ms (1.12%)
ddtrace.internal.products 2.014 ms (0.88%)
ddtrace.internal.remoteconfig.client 0.769 ms (0.34%)
importlib.metadata 0.157 ms (0.07%)
importlib.abc 0.157 ms (0.07%)
importlib.resources 0.157 ms (0.07%)
importlib.resources._legacy 0.157 ms (0.07%)
ddtrace.internal.symbol_db.remoteconfig 0.066 ms (0.03%)
ddtrace.internal.symbol_db.symbols 0.066 ms (0.03%)
gzip 0.044 ms (0.02%)
ddtrace.internal.utils.inspection 0.022 ms (0.01%)
ddtrace.internal.remoteconfig.worker 0.036 ms (0.02%)
ddtrace.settings.profiling 0.307 ms (0.13%)
ddtrace.vendor.psutil 0.307 ms (0.13%)
ddtrace.vendor.psutil._common 0.307 ms (0.13%)
ddtrace.internal.flare.flare 0.070 ms (0.03%)
ddtrace.internal.runtime.runtime_metrics 0.031 ms (0.01%)
ddtrace._trace.trace_handlers 0.096 ms (0.04%)
ddtrace._trace._inferred_proxy 0.030 ms (0.01%)
ddtrace.propagation.http 0.030 ms (0.01%)
ddtrace.internal._tagset 0.030 ms (0.01%)
ddtrace 1.717 ms (0.75%)
ddtrace._logger 0.588 ms (0.26%)
ddtrace.internal.telemetry 0.460 ms (0.20%)
ddtrace.internal.telemetry.writer 0.406 ms (0.18%)
http.client 0.223 ms (0.10%)
ssl 0.066 ms (0.03%)
_ssl 0.066 ms (0.03%)
email.parser 0.022 ms (0.01%)
email.feedparser 0.022 ms (0.01%)
email._policybase 0.022 ms (0.01%)
email.header 0.022 ms (0.01%)
binascii 0.022 ms (0.01%)
ddtrace.internal.encoding 0.140 ms (0.06%)
ddtrace.settings._agent 0.031 ms (0.01%)
ddtrace.settings._core 0.031 ms (0.01%)
ddtrace.internal.native 0.031 ms (0.01%)
ddtrace.internal.native._native 0.031 ms (0.01%)
ddtrace.internal.telemetry.data 0.012 ms (0.01%)
ddtrace.internal.hostname 0.012 ms (0.01%)
logging 0.127 ms (0.06%)
traceback 0.127 ms (0.06%)
contextlib 0.127 ms (0.06%)
ddtrace.trace 0.120 ms (0.05%)
ddtrace._trace.filters 0.059 ms (0.03%)
ddtrace._trace.processor 0.059 ms (0.03%)
ddtrace._trace.sampler 0.059 ms (0.03%)
ddtrace._trace.span 0.059 ms (0.03%)
ddtrace.internal._rand 0.037 ms (0.02%)
ddtrace._trace._span_pointer 0.022 ms (0.01%)
ddtrace.settings._config 0.076 ms (0.03%)
ddtrace.internal.gitmetadata 0.076 ms (0.03%)
ddtrace.ext.ci 0.076 ms (0.03%)
ddtrace.ext.git 0.076 ms (0.03%)
subprocess 0.049 ms (0.02%)
shutil 0.027 ms (0.01%)
zlib 0.027 ms (0.01%)
ddtrace._monkey 0.061 ms (0.03%)
ddtrace.appsec 0.061 ms (0.03%)
ddtrace.internal.core 0.061 ms (0.03%)
ddtrace.internal.core.event_hub 0.061 ms (0.03%)

@pr-commenter
Copy link

pr-commenter bot commented Mar 31, 2025

Benchmarks

Benchmark execution time: 2025-04-02 18:41:23

Comparing candidate commit c8b99e8 in PR branch vitor-de-araujo/SDTEST-1791/concurrent-fetch-settings with baseline commit 306489d in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 498 metrics, 2 unstable metrics.

@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Mar 31, 2025
@erikayasuda erikayasuda marked this pull request as ready for review March 31, 2025 21:25
@erikayasuda erikayasuda requested a review from a team as a code owner March 31, 2025 21:25
@vitor-de-araujo vitor-de-araujo enabled auto-merge (squash) April 2, 2025 10:02
@vitor-de-araujo vitor-de-araujo merged commit fef9fb6 into main Apr 2, 2025
375 of 376 checks passed
@vitor-de-araujo vitor-de-araujo deleted the vitor-de-araujo/SDTEST-1791/concurrent-fetch-settings branch April 2, 2025 18:43
chojomok pushed a commit that referenced this pull request Apr 7, 2025
Recreating #12972 because we
needed to revert PRs that were accidentally merged prematurely due to
required status checks getting deleted.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Vítor De Araújo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants