-
Notifications
You must be signed in to change notification settings - Fork 431
fix(llmobs): fix parsing errors for bedrock converse stream #13238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 249 ± 8 ms. The average import time from base is: 257 ± 7 ms. The import time difference between this PR and base is: -7.8 ± 0.3 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-04-23 14:06:33 Comparing candidate commit d87e981 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 495 metrics, 3 unstable metrics. scenario:iast_aspects-ospathsplitext_aspect
scenario:telemetryaddmetric-1-distribution-metric-1-times
|
Fixing a noop test discovered a couple bugs for parsing out the response from converse stream
[{"role": "assistant"}]
message that didn't contain any content blocks to be parsed out - the fix is to only try to extract a message if it contains associated content block indicestoolName
->name
Checklist
Reviewer Checklist