Skip to content

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Apr 21, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@mabdinur mabdinur requested a review from a team as a code owner April 21, 2025 18:46
@mabdinur mabdinur requested a review from emmettbutler April 21, 2025 18:46
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/internal/native/__init__.py                                     @DataDog/apm-core-python
tests/internal/test_native.py                                           @DataDog/apm-core-python

Copy link
Contributor

github-actions bot commented Apr 21, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 239 ± 3 ms.

The average import time from base is: 242 ± 5 ms.

The import time difference between this PR and base is: -2.9 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.049 ms (0.86%)
ddtrace.bootstrap.sitecustomize 1.375 ms (0.57%)
ddtrace.bootstrap.preload 1.375 ms (0.57%)
ddtrace.internal.products 1.375 ms (0.57%)
ddtrace.internal.remoteconfig.client 0.662 ms (0.28%)
ddtrace 0.674 ms (0.28%)

@pr-commenter
Copy link

pr-commenter bot commented Apr 21, 2025

Benchmarks

Benchmark execution time: 2025-05-01 14:10:28

Comparing candidate commit aec3ed3 in PR branch munir/enable-sc-debug-logs with baseline commit 5aa32d1 in branch main.

Found 0 performance improvements and 6 performance regressions! Performance is the same for 489 metrics, 5 unstable metrics.

scenario:iast_aspects-format_map_aspect

  • 🟥 execution_time [+412.624ns; +483.385ns] or [+12.455%; +14.591%]

scenario:iast_aspects-lower_aspect

  • 🟥 execution_time [+278.887ns; +308.784ns] or [+12.623%; +13.976%]

scenario:iast_aspects-modulo_aspect_for_bytearray_bytearray

  • 🟥 execution_time [+89.942ns; +109.397ns] or [+7.049%; +8.574%]

scenario:iast_aspects-ospathjoin_aspect

  • 🟥 execution_time [+850.897ns; +929.278ns] or [+13.954%; +15.239%]

scenario:iast_aspects-ospathsplitext_aspect

  • 🟥 execution_time [+327.473ns; +549.688ns] or [+7.338%; +12.317%]

scenario:telemetryaddmetric-1-distribution-metric-1-times

  • 🟥 execution_time [+251.897ns; +314.940ns] or [+8.430%; +10.540%]

@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 21, 2025
@mabdinur mabdinur enabled auto-merge (squash) April 25, 2025 17:09
@mabdinur mabdinur merged commit 8fe0cfa into main May 2, 2025
695 checks passed
@mabdinur mabdinur deleted the munir/enable-sc-debug-logs branch May 2, 2025 13:44
brettlangdon pushed a commit that referenced this pull request May 6, 2025
…13247)

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants