Nicole cybul/flaky test investigation2 #13264
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 80ee6c6.
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| @@ -284,6 +292,187 @@ def get_messages_from_converse_content(role: str, content: list): | |||
| return messages | |||
|
|
|||
|
|
|||
| def openai_set_meta_tags_from_completion(span: Span, kwargs: Dict[str, Any], completions: Any) -> None: | |||
There was a problem hiding this comment.
🟠 Code Quality Violation
do not use Any, use a concrete type (...read more)
Use the Any type very carefully. Most of the time, the Any type is used because we do not know exactly what type is being used. If you want to specify that a value can be of any type, use object instead of Any.
Learn More
| ) | ||
|
|
||
| @staticmethod | ||
| def _extract_llmobs_metrics(resp: Any) -> Dict[str, Any]: |
There was a problem hiding this comment.
🟠 Code Quality Violation
do not use Any, use a concrete type (...read more)
Use the Any type very carefully. Most of the time, the Any type is used because we do not know exactly what type is being used. If you want to specify that a value can be of any type, use object instead of Any.
Learn More
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 244 ± 5 ms. The average import time from base is: 237 ± 3 ms. The import time difference between this PR and base is: 7.1 ± 0.2 ms. Import time breakdownThe following import paths have grown:
|
BenchmarksBenchmark execution time: 2025-04-24 13:07:33 Comparing candidate commit 507cc91 in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 497 metrics, 8 unstable metrics. scenario:iast_aspects-lower_aspect
scenario:iast_aspects-ospathjoin_aspect
scenario:iast_aspects-ospathsplitdrive_aspect
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Reviewer Checklist