Skip to content

chore(build): remove unused build-dist* files #13281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Apr 25, 2025

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@taegyunkim taegyunkim added the changelog/no-changelog A changelog entry is not required for this PR. label Apr 25, 2025
@taegyunkim taegyunkim changed the title chore(build): remove unused build-dist-* files chore(build): remove unused build-dist* files Apr 25, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

scripts/gen_gitlab_config.py                                            @DataDog/apm-core-python

Copy link
Contributor

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 237 ± 5 ms.

The average import time from base is: 239 ± 7 ms.

The import time difference between this PR and base is: -2.0 ± 0.3 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.995 ms (0.84%)
ddtrace.bootstrap.sitecustomize 1.321 ms (0.56%)
ddtrace.bootstrap.preload 1.321 ms (0.56%)
ddtrace.internal.products 1.321 ms (0.56%)
ddtrace.internal.remoteconfig.client 0.638 ms (0.27%)
ddtrace 0.675 ms (0.28%)

@taegyunkim taegyunkim added changelog/no-changelog A changelog entry is not required for this PR. and removed changelog/no-changelog A changelog entry is not required for this PR. labels Apr 25, 2025
@taegyunkim taegyunkim marked this pull request as ready for review April 25, 2025 20:16
@taegyunkim taegyunkim requested a review from a team as a code owner April 25, 2025 20:16
@taegyunkim taegyunkim requested a review from juanjux April 25, 2025 20:16
@pr-commenter
Copy link

pr-commenter bot commented Apr 25, 2025

Benchmarks

Benchmark execution time: 2025-04-25 20:27:33

Comparing candidate commit f4ad727 in PR branch taegyunkim/remove-build-dist with baseline commit ea64efc in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 500 metrics, 8 unstable metrics.

@taegyunkim taegyunkim enabled auto-merge (squash) April 25, 2025 20:35
@taegyunkim taegyunkim merged commit 5c7228a into main Apr 28, 2025
280 of 283 checks passed
@taegyunkim taegyunkim deleted the taegyunkim/remove-build-dist branch April 28, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants