-
Notifications
You must be signed in to change notification settings - Fork 441
feat(azure_servicebus): add azure servicebus integration and function trigger distributed tracing #13691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ced directly from the context
… related to service bus
…ctions and azure_servicebus
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 277 ± 3 ms. The average import time from base is: 277 ± 2 ms. The import time difference between this PR and base is: 0.0 ± 0.1 ms. The difference is not statistically significant (z = 0.41). Import time breakdownThe following import paths have appeared:
|
BenchmarksBenchmark execution time: 2025-06-23 22:25:31 Comparing candidate commit 7a55f4d in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 558 metrics, 3 unstable metrics. scenario:iastaspects-upper_aspect
scenario:iastaspectsospath-ospathbasename_aspect
scenario:iastaspectsospath-ospathjoin_aspect
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice use of ddtrace.internal.core
!
…'t reuse service bus messages
This PR adds an integration for tracing the producer of the azure-servicebus package and adds support for distributed tracing for Azure Functions consuming the service bus messages.
Instrumentation details:
azure.servicebus
andazure.servicebus.aio
(async package) are patchedServiceBusSender.send_messages
ServiceBusSender.schedule_messages
application_properties
of each service bus message passed to above methodsServiceBusMessage
orAmqpAnnotatedMessage
in addition to a list ofServiceBusMessage
orAmqpAnnotatedMessage
ServiceBusMessageBatch
in a future PRapplication_properties
in Azure Function service bus consumercomponent: azure_servicebus
span.kind: producer
span.type: worker
operation: azure.servicebus.produce
messaging.destination_kind
- not set, instances ofServiceBusSender
don't specify whether it is a queue or topic they are sending tomessaging.destination.name: <queue/topic name>
messaging.destination.system: servicebus
messaging.operation: send
network.destination.name: <fully qualified host name for Service Bus namespace>
network.destination.port
- not set, no port specified on instances ofServiceBusSender
Additional Notes:
azureservicebusemulator
andazuresqledge
services to run Azure Service Bus locally and in CI for testsazure_functions
integration to usectx.span
instead of addingreq_span
andtrigger_span
properties to the contextChecklist
Reviewer Checklist