fix(tracer): error when encoding bytes and adding a string [backport 3.9] #13718

github-actions · 2025-06-18T23:41:11Z

Backport 2e13f18 from #13419 to 3.9.

fixes error when we try to concat the string 'truncated' to bytes

Checklist

PR author has checked that all the criteria below are met
The PR description includes an overview of the change
The PR description articulates the motivation for the change
The change includes tests OR the PR description describes a testing strategy
The PR description notes risks associated with the change, if any
Newly-added code is easy to change
The change follows the library release note guidelines
The change includes or references documentation updates if necessary
Backport labels are set (if applicable)

Reviewer Checklist

Reviewer has checked that all the criteria below are met
Title is accurate
All changes are related to the pull request's stated goal
Avoids breaking API changes
Testing strategy adequately addresses listed risks
Newly-added code is easy to change
Release note makes sense to a user of the library
If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
Backport labels are set in a manner that is consistent with the release branch maintenance policy

fixes error when we try to concat the string 'truncated' to bytes ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Quinna Halim <[email protected]> Co-authored-by: Brett Langdon <[email protected]> (cherry picked from commit 2e13f18)

quinna-h · 2025-06-20T19:44:23Z

/merge

dd-devflow · 2025-06-20T19:44:27Z

View all feedbacks in Devflow UI.

2025-06-20 19:44:26 UTC ℹ️ Start processing command /merge

2025-06-20 19:44:34 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-20 20:40:19 UTC ⚠️ MergeQueue: This merge request was unqueued

This pull request was closed.

quinna-h · 2025-06-20T19:44:38Z

/merge

dd-devflow · 2025-06-20T19:44:41Z

View all feedbacks in Devflow UI.

2025-06-20 19:44:41 UTC ℹ️ Start processing command /merge

2025-06-20 19:44:44 UTC ❌ MergeQueue

PR already in the queue with status waiting

github-actions · 2025-06-20T20:40:41Z

CODEOWNERS have been resolved as:

releasenotes/notes/encode-bytes-974d93cec3725455.yaml                   @DataDog/apm-python
tests/snapshots/tests.integration.test_integration_snapshots.test_encode_span_with_large_bytes_attributes[v0.4].json  @DataDog/apm-python
tests/snapshots/tests.integration.test_integration_snapshots.test_encode_span_with_large_bytes_attributes[v0.5].json  @DataDog/apm-python
ddtrace/internal/_encoding.pyx                                          @DataDog/apm-core-python
tests/integration/test_integration_snapshots.py                         @DataDog/apm-core-python

github-actions · 2025-06-20T21:01:26Z

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 273 ± 2 ms.

The average import time from base is: 280 ± 20 ms.

The import time difference between this PR and base is: -5.0 ± 0.7 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.310 ms (0.48%)

ddtrace.bootstrap.sitecustomize 0.658 ms (0.24%)

ddtrace.bootstrap.preload 0.658 ms (0.24%)

ddtrace.internal.remoteconfig.client 0.658 ms (0.24%)

ddtrace 0.653 ms (0.24%)

pr-commenter · 2025-06-20T21:30:01Z

Benchmarks

Benchmark execution time: 2025-06-23 15:31:02

Comparing candidate commit a4d1e11 in PR branch backport-13419-to-3.9 with baseline commit 03c93b7 in branch 3.9.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 505 metrics, 3 unstable metrics.

scenario:iastaspects-lstrip_aspect

🟥 execution_time [+1.418µs; +1.506µs] or [+10.943%; +11.623%]

scenario:iastaspectsospath-ospathsplitdrive_aspect

🟥 execution_time [+347.765ns; +417.705ns] or [+9.570%; +11.495%]

quinna-h · 2025-06-23T15:09:08Z

/merge

dd-devflow · 2025-06-23T15:09:17Z

View all feedbacks in Devflow UI.

2025-06-23 15:09:17 UTC ℹ️ Start processing command /merge

2025-06-23 15:09:43 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-23 15:32:16 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

github-actions bot requested review from a team as code owners June 18, 2025 23:41

github-actions bot requested review from juanjux and duncanista June 18, 2025 23:41

quinna-h approved these changes Jun 19, 2025

View reviewed changes

emmettbutler approved these changes Jun 20, 2025

View reviewed changes

emmettbutler enabled auto-merge (squash) June 20, 2025 15:28

dd-devflow bot added the mergequeue-status: waiting label Jun 20, 2025

quinna-h closed this Jun 20, 2025

auto-merge was automatically disabled June 20, 2025 20:40
Pull request was closed

quinna-h reopened this Jun 20, 2025

dd-devflow bot added mergequeue-status: removed and removed mergequeue-status: waiting labels Jun 20, 2025

quinna-h enabled auto-merge (squash) June 20, 2025 20:53

quinna-h disabled auto-merge June 20, 2025 22:37

quinna-h enabled auto-merge (squash) June 20, 2025 22:37

Merge branch '3.9' into backport-13419-to-3.9

a4d1e11

dd-devflow bot added mergequeue-status: waiting and removed mergequeue-status: removed labels Jun 23, 2025

quinna-h merged commit 593d5d5 into 3.9 Jun 23, 2025
831 of 834 checks passed

quinna-h deleted the backport-13419-to-3.9 branch June 23, 2025 15:32

dd-devflow bot added mergequeue-status: done and removed mergequeue-status: waiting labels Jun 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(tracer): error when encoding bytes and adding a string [backport 3.9] #13718

fix(tracer): error when encoding bytes and adding a string [backport 3.9] #13718

Uh oh!

github-actions bot commented Jun 18, 2025 •

edited by quinna-h

Loading

Uh oh!

quinna-h commented Jun 20, 2025

Uh oh!

dd-devflow bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

quinna-h commented Jun 20, 2025

Uh oh!

dd-devflow bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jun 20, 2025

Uh oh!

github-actions bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

quinna-h commented Jun 23, 2025

Uh oh!

dd-devflow bot commented Jun 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

fix(tracer): error when encoding bytes and adding a string [backport 3.9] #13718

fix(tracer): error when encoding bytes and adding a string [backport 3.9] #13718

Uh oh!

Conversation

github-actions bot commented Jun 18, 2025 • edited by quinna-h Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Reviewer Checklist

Uh oh!

quinna-h commented Jun 20, 2025

Uh oh!

dd-devflow bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

quinna-h commented Jun 20, 2025

Uh oh!

dd-devflow bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 20, 2025

Uh oh!

github-actions bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bootstrap import analysis

Summary

Import time breakdown

Uh oh!

pr-commenter bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

scenario:iastaspects-lstrip_aspect

scenario:iastaspectsospath-ospathsplitdrive_aspect

Uh oh!

quinna-h commented Jun 23, 2025

Uh oh!

dd-devflow bot commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jun 18, 2025 •

edited by quinna-h

Loading

dd-devflow bot commented Jun 20, 2025 •

edited

Loading

dd-devflow bot commented Jun 20, 2025 •

edited

Loading

github-actions bot commented Jun 20, 2025 •

edited

Loading

pr-commenter bot commented Jun 20, 2025 •

edited

Loading

dd-devflow bot commented Jun 23, 2025 •

edited

Loading