Skip to content

ci(gitlab): disable sccache #13723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

ci(gitlab): disable sccache #13723

wants to merge 3 commits into from

Conversation

P403n1x87
Copy link
Contributor

We disable sccache in GitLab base venv building to save some extra time. Because we now use cached artifacts and incremental builds, the use of sccache in those jobs has become redundant. By not installing sccache we now save some extra bit of time.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 19, 2025
Copy link
Contributor

CODEOWNERS have been resolved as:

scripts/gen_ext_cache_scripts.py                                        @DataDog/apm-core-python
scripts/gen_gitlab_config.py                                            @DataDog/apm-core-python

We disable sccache in GitLab base venv building to save some extra time.
Because we now use cached artifacts and incremental builds, the use of
sccache in those jobs has become redundant. By not installing sccache we
now save some extra bit of time.
@P403n1x87 P403n1x87 force-pushed the ci/gitlab-remove-sccache branch from 15ffa4f to 9d8476b Compare June 19, 2025 10:41
Copy link
Contributor

github-actions bot commented Jun 19, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 279 ± 3 ms.

The average import time from base is: 281 ± 3 ms.

The import time difference between this PR and base is: -1.9 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.991 ms (0.71%)
ddtrace.bootstrap.sitecustomize 1.316 ms (0.47%)
ddtrace.bootstrap.preload 1.316 ms (0.47%)
ddtrace.internal.remoteconfig.client 0.634 ms (0.23%)
ddtrace 0.675 ms (0.24%)
ddtrace.internal._unpatched 0.032 ms (0.01%)
json 0.032 ms (0.01%)
json.decoder 0.032 ms (0.01%)
re 0.032 ms (0.01%)
enum 0.032 ms (0.01%)
types 0.032 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 19, 2025

Benchmarks

Benchmark execution time: 2025-06-20 20:47:34

Comparing candidate commit 0fe9f62 in PR branch ci/gitlab-remove-sccache with baseline commit 6931943 in branch main.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 558 metrics, 3 unstable metrics.

scenario:iastaspects-lower_aspect

  • 🟥 execution_time [+183.247ns; +218.783ns] or [+8.161%; +9.743%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+822.921ns; +904.895ns] or [+19.450%; +21.387%]

scenario:iastaspectsospath-ospathnormcase_aspect

  • 🟥 execution_time [+386.013ns; +437.188ns] or [+11.150%; +12.628%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant