Skip to content

chore(llmobs): make mlapp error message more helpful [backport 3.9] #13735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 20, 2025

Backport 6931943 from #13714 to 3.9.

Makes the (lack of) ML App error message more detailed, specifically to state the env var / config that needs to be set to avoid the error in the future.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Makes the (lack of) ML App error message more detailed, specifically to
state the env var / config that needs to be set to avoid the error in
the future.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 6931943)
@github-actions github-actions bot added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 20, 2025
@github-actions github-actions bot requested a review from a team as a code owner June 20, 2025 21:01
@Yun-Kim Yun-Kim closed this Jun 23, 2025
@Yun-Kim Yun-Kim reopened this Jun 23, 2025
Copy link
Contributor Author

CODEOWNERS have been resolved as:

ddtrace/llmobs/_llmobs.py                                               @DataDog/ml-observability

Copy link
Contributor Author

github-actions bot commented Jun 23, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 272 ± 2 ms.

The average import time from base is: 274 ± 2 ms.

The import time difference between this PR and base is: -2.03 ± 0.08 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.977 ms (0.73%)
ddtrace.bootstrap.sitecustomize 1.307 ms (0.48%)
ddtrace.bootstrap.preload 1.307 ms (0.48%)
ddtrace.internal.remoteconfig.client 0.652 ms (0.24%)
ddtrace 0.670 ms (0.25%)
ddtrace.internal._unpatched 0.030 ms (0.01%)
json 0.030 ms (0.01%)
json.decoder 0.030 ms (0.01%)
re 0.030 ms (0.01%)
enum 0.030 ms (0.01%)
types 0.030 ms (0.01%)

@Yun-Kim Yun-Kim enabled auto-merge (squash) June 23, 2025 15:08
@pr-commenter
Copy link

pr-commenter bot commented Jun 23, 2025

Benchmarks

Benchmark execution time: 2025-06-23 15:55:24

Comparing candidate commit 1d6ddd2 in PR branch backport-13714-to-3.9 with baseline commit 03c93b7 in branch 3.9.

Found 0 performance improvements and 6 performance regressions! Performance is the same for 547 metrics, 3 unstable metrics.

scenario:iastaspects-format_map_aspect

  • 🟥 execution_time [+466.534ns; +523.034ns] or [+14.610%; +16.380%]

scenario:iastaspects-lstrip_aspect

  • 🟥 execution_time [+1.377µs; +1.559µs] or [+10.615%; +12.024%]

scenario:iastaspects-strip_aspect

  • 🟥 execution_time [+1.400µs; +1.576µs] or [+10.803%; +12.157%]

scenario:iastaspects-translate_aspect

  • 🟥 execution_time [+235.003ns; +275.108ns] or [+7.057%; +8.261%]

scenario:iastaspectsospath-ospathnormcase_aspect

  • 🟥 execution_time [+413.802ns; +461.026ns] or [+11.976%; +13.343%]

scenario:iastaspectsospath-ospathsplitext_aspect

  • 🟥 execution_time [+601.363ns; +672.261ns] or [+13.253%; +14.816%]

@Yun-Kim
Copy link
Contributor

Yun-Kim commented Jun 23, 2025

Closing as this isn't a fix and doesn't need to be backported.

@Yun-Kim Yun-Kim closed this Jun 23, 2025
auto-merge was automatically disabled June 23, 2025 16:59

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant