-
Notifications
You must be signed in to change notification settings - Fork 441
chore(llmobs): make mlapp error message more helpful [backport 3.9] #13735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Makes the (lack of) ML App error message more detailed, specifically to state the env var / config that needs to be set to avoid the error in the future. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit 6931943)
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 272 ± 2 ms. The average import time from base is: 274 ± 2 ms. The import time difference between this PR and base is: -2.03 ± 0.08 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-06-23 15:55:24 Comparing candidate commit 1d6ddd2 in PR branch Found 0 performance improvements and 6 performance regressions! Performance is the same for 547 metrics, 3 unstable metrics. scenario:iastaspects-format_map_aspect
scenario:iastaspects-lstrip_aspect
scenario:iastaspects-strip_aspect
scenario:iastaspects-translate_aspect
scenario:iastaspectsospath-ospathnormcase_aspect
scenario:iastaspectsospath-ospathsplitext_aspect
|
Closing as this isn't a fix and doesn't need to be backported. |
Pull request was closed
Backport 6931943 from #13714 to 3.9.
Makes the (lack of) ML App error message more detailed, specifically to state the env var / config that needs to be set to avoid the error in the future.
Checklist
Reviewer Checklist