[MLOB-3112] make shared base classes for llmobs traced streams #13736
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 286 ± 4 ms. The average import time from base is: 293 ± 7 ms. The import time difference between this PR and base is: -7.3 ± 0.3 ms. Import time breakdownThe following import paths have shrunk:
|
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
|
|
||
| def __exit__(self, exc_type, exc_val, exc_tb): | ||
| self.__wrapped__.__exit__(exc_type, exc_val, exc_tb) | ||
| class BaseOpenAIStreamHandler: |
There was a problem hiding this comment.
⚪ Code Quality Violation
Class BaseOpenAIStreamHandler should have an init method (...read more)
Ensure that a class has an __init__ method. This check is bypassed when the class is a data class (annotated with @dataclass).
BenchmarksBenchmark execution time: 2025-06-23 20:03:58 Comparing candidate commit 7626f40 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 499 metrics, 3 unstable metrics. scenario:iastaspects-lower_aspect
scenario:iastaspects-upper_aspect
|
| ) | ||
| self._dd_span.finish() | ||
|
|
||
| class BaseVertexAIStreamHandler: |
There was a problem hiding this comment.
⚪ Code Quality Violation
Class BaseVertexAIStreamHandler should have an init method (...read more)
Ensure that a class has an __init__ method. This check is bypassed when the class is a data class (annotated with @dataclass).
| from ddtrace.llmobs._integrations.utils import get_generation_config_google | ||
| from ddtrace.llmobs._integrations.utils import get_system_instructions_from_google_model | ||
| from ddtrace.llmobs._integrations.utils import tag_request_content_part_google | ||
| from ddtrace.llmobs._integrations.utils import tag_response_part_google | ||
|
|
||
| class BaseGoogleGenerativeAIStramHandler: |
There was a problem hiding this comment.
⚪ Code Quality Violation
Class BaseGoogleGenerativeAIStramHandler should have an init method (...read more)
Ensure that a class has an __init__ method. This check is bypassed when the class is a data class (annotated with @dataclass).
| return traced_stream | ||
|
|
||
| async def __aexit__(self, exc_type, exc_val, exc_tb): | ||
| await self.__wrapped__.__aexit__(exc_type, exc_val, exc_tb) | ||
| class BaseAnthropicStreamHandler: |
There was a problem hiding this comment.
⚪ Code Quality Violation
Class BaseAnthropicStreamHandler should have an init method (...read more)
Ensure that a class has an __init__ method. This check is bypassed when the class is a data class (annotated with @dataclass).
ncybul
changed the title
| from ddtrace.llmobs._integrations.base_stream_handler import make_traced_stream | ||
| from ddtrace.llmobs._integrations.base_stream_handler import StreamHandler | ||
|
|
||
| class BaseLangchainStreamHandler: |
There was a problem hiding this comment.
⚪ Code Quality Violation
Class BaseLangchainStreamHandler should have an init method (...read more)
Ensure that a class has an __init__ method. This check is bypassed when the class is a data class (annotated with @dataclass).
ncybul
changed the title
This PR attempts to create shared base classes for tracing streams in our LLMObs integrations. The Anthropic, Gemini, Langchain, LiteLLM, Open AI / Azure Open AI, and Vertex AI integrations were all refactored to use this new standardized interface.
How it works
todo
Checklist
Reviewer Checklist