Skip to content

feat(llmobs): allow span processor to return None to omit spans #13739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

amir-mic-lin
Copy link

@amir-mic-lin amir-mic-lin commented Jun 22, 2025

Allow users to omit any traces they want by returning none in the user_span_processor method.

Motivation:
I am trying to prevent some auto traces from cluttering my Datadog observability dashboards. These traces create noise and make it harder to focus on the more critical traces. My LLM observability overview is filled with what is clustered as empty input which is incorrect.
e.g. all embedding traces are are just a spammer.

To do that, I am using the new span_processor, and the new way to omit specific spans, will be to return null by the relevant span processor.

I have added a test for that.

The only risk is that there is no indication that span was omitted but I was afraid that a debug log would be too spammy. But please let me know if that will help.
Also there are some telemetric collected about sent span which might also need to be changed, will be great to hear your thoughts

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

- Update span_processor type annotation to Optional[LLMObsSpan]
- Add support for returning None from span processors to omit spans
- Update documentation and examples with omit functionality
- Add test case for span omission functionality
@amir-mic-lin amir-mic-lin requested a review from a team as a code owner June 22, 2025 04:03
@amir-mic-lin amir-mic-lin marked this pull request as draft June 22, 2025 06:39
@amir-mic-lin
Copy link
Author

I am also making another change where instead of having LLMObsSpan - I will use the original Span - that way the user can have more inputs on the span and filter only relevant

@amir-mic-lin amir-mic-lin marked this pull request as ready for review June 22, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant