Skip to content

fix(aap): track user default arguments must not generate security event #13742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025

Conversation

christophe-papazian
Copy link
Contributor

@christophe-papazian christophe-papazian commented Jun 23, 2025

Ensure track_user to not generate additional security events when used with expected metadata (name, email, scope or role).

Also:

  • update (and fix) related unit tests

APPSEC-58040

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@christophe-papazian christophe-papazian changed the title removing set user arguments from custom event auth_sdk fix(aap): removing set user arguments from custom event Jun 23, 2025
@christophe-papazian christophe-papazian added the ASM Application Security Monitoring label Jun 23, 2025
Copy link
Contributor

github-actions bot commented Jun 23, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/ato_sdk2_track_user_fix_no_keep-b6b5206a81da6b36.yaml  @DataDog/apm-python
ddtrace/appsec/track_user_sdk.py                                        @DataDog/asm-python
tests/appsec/appsec/test_appsec_trace_utils.py                          @DataDog/asm-python

Copy link
Contributor

github-actions bot commented Jun 23, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 276 ± 2 ms.

The average import time from base is: 278 ± 2 ms.

The import time difference between this PR and base is: -2.1 ± 0.1 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.013 ms (0.73%)
ddtrace.bootstrap.sitecustomize 1.337 ms (0.48%)
ddtrace.bootstrap.preload 1.337 ms (0.48%)
ddtrace.internal.remoteconfig.client 0.644 ms (0.23%)
ddtrace 0.676 ms (0.25%)
ddtrace.internal._unpatched 0.030 ms (0.01%)
json 0.030 ms (0.01%)
json.decoder 0.030 ms (0.01%)
re 0.030 ms (0.01%)
enum 0.030 ms (0.01%)
types 0.030 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 23, 2025

Benchmarks

Benchmark execution time: 2025-06-23 14:30:49

Comparing candidate commit 51e1edc in PR branch christophe-papazian/track_user_metadata_as_setuser with baseline commit 6fae86b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 561 metrics, 3 unstable metrics.

@christophe-papazian christophe-papazian marked this pull request as ready for review June 23, 2025 14:17
@christophe-papazian christophe-papazian requested review from a team as code owners June 23, 2025 14:17
@christophe-papazian christophe-papazian changed the title fix(aap): removing set user arguments from custom event fix(aap): track user default arguments must not generate security event Jun 23, 2025
@avara1986 avara1986 enabled auto-merge (squash) June 23, 2025 14:24
@avara1986 avara1986 merged commit 0940d73 into main Jun 23, 2025
602 of 605 checks passed
@avara1986 avara1986 deleted the christophe-papazian/track_user_metadata_as_setuser branch June 23, 2025 14:32
github-actions bot pushed a commit that referenced this pull request Jun 23, 2025
…nt (#13742)

Ensure track_user to not generate additional security events when used
with expected metadata (name, email, scope or role).

Also:
- update (and fix) related unit tests

APPSEC-58040

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit 0940d73)
christophe-papazian added a commit that referenced this pull request Jun 23, 2025
…nt [backport 3.9] (#13743)

Backport 0940d73 from #13742 to 3.9.

Ensure track_user to not generate additional security events when used
with expected metadata (name, email, scope or role).

Also:
- update (and fix) related unit tests

APPSEC-58040

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

Co-authored-by: Christophe Papazian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring backport 3.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants