Skip to content

ci: move DI exploration tests to GitLab #13783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

P403n1x87
Copy link
Contributor

We extract the exploration tests from the rest of the framework tests and move them to GitLab.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@P403n1x87 P403n1x87 added changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger labels Jun 26, 2025
Copy link
Contributor

github-actions bot commented Jun 26, 2025

CODEOWNERS have been resolved as:

.gitlab/debugging/exploration.yml                                       @DataDog/python-guild @DataDog/apm-core-python
.gitlab-ci.yml                                                          @DataDog/apm-core-python
tests/debugging/exploration/_config.py                                  @DataDog/debugger-python
tests/debugging/exploration/_coverage.py                                @DataDog/debugger-python
tests/debugging/exploration/_profiler.py                                @DataDog/debugger-python
tests/debugging/exploration/debugger.py                                 @DataDog/debugger-python
tests/debugging/exploration/utils.py                                    @DataDog/debugger-python

@P403n1x87 P403n1x87 force-pushed the ci/extract-di-exploration-tests branch from 7e53e44 to 1b0c445 Compare June 26, 2025 10:37
Copy link
Contributor

github-actions bot commented Jun 26, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 284 ± 4 ms.

The average import time from base is: 289 ± 5 ms.

The import time difference between this PR and base is: -4.9 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.137 ms (0.75%)
ddtrace.bootstrap.sitecustomize 1.449 ms (0.51%)
ddtrace.bootstrap.preload 1.449 ms (0.51%)
ddtrace.internal.remoteconfig.client 0.690 ms (0.24%)
ddtrace 0.687 ms (0.24%)
ddtrace.internal._unpatched 0.035 ms (0.01%)
json 0.035 ms (0.01%)
json.decoder 0.035 ms (0.01%)
re 0.035 ms (0.01%)
enum 0.035 ms (0.01%)
types 0.035 ms (0.01%)

@pr-commenter
Copy link

pr-commenter bot commented Jun 26, 2025

Benchmarks

Benchmark execution time: 2025-06-26 17:32:22

Comparing candidate commit 7cf3da3 in PR branch ci/extract-di-exploration-tests with baseline commit c335af9 in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 559 metrics, 3 unstable metrics.

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+852.088ns; +917.936ns] or [+20.105%; +21.658%]

scenario:iastaspectsospath-ospathjoin_aspect

  • 🟥 execution_time [+671.902ns; +880.817ns] or [+10.877%; +14.260%]

@P403n1x87 P403n1x87 force-pushed the ci/extract-di-exploration-tests branch 3 times, most recently from 2f76f0e to 24bb307 Compare June 26, 2025 16:19
We extract the exploration tests from the rest of the framework tests
and move them to GitLab.
@P403n1x87 P403n1x87 force-pushed the ci/extract-di-exploration-tests branch from 24bb307 to 7cf3da3 Compare June 26, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.21 changelog/no-changelog A changelog entry is not required for this PR. Dynamic Instrumentation Dynamic Instrumentation/Live Debugger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant