-
Notifications
You must be signed in to change notification settings - Fork 468
ci: replace slotscheck with PLW0244 #15257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 251 ± 3 ms. The average import time from base is: 258 ± 3 ms. The import time difference between this PR and base is: -7.0 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate brettlangdon/replace.slotscheck (cfd4f1b) with baseline main (73f2611) 🟡 Near SLO Breach (1 suite)🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.592ms (SLO: <4.750ms -3.3%) vs baseline: -0.2% Memory: ✅ 64.080MB (SLO: <66.500MB -3.6%) vs baseline: +4.9% ✅ appsec-postTime: ✅ 6.622ms (SLO: <6.750ms 🟡 -1.9%) vs baseline: ~same Memory: ✅ 64.140MB (SLO: <66.500MB -3.5%) vs baseline: +4.9% ✅ appsec-telemetryTime: ✅ 4.582ms (SLO: <4.750ms -3.5%) vs baseline: -0.3% Memory: ✅ 64.109MB (SLO: <66.500MB -3.6%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.855ms (SLO: <2.000ms -7.2%) vs baseline: +0.2% Memory: ✅ 47.896MB (SLO: <49.500MB -3.2%) vs baseline: +4.7% ✅ iast-getTime: ✅ 1.857ms (SLO: <2.000ms -7.1%) vs baseline: -0.2% Memory: ✅ 44.447MB (SLO: <49.000MB -9.3%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.928ms (SLO: <2.100ms -8.2%) vs baseline: -0.3% Memory: ✅ 48.699MB (SLO: <50.000MB -2.6%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 3.369ms (SLO: <3.650ms -7.7%) vs baseline: ~same Memory: ✅ 54.277MB (SLO: <56.000MB -3.1%) vs baseline: +4.6% ✅ tracerTime: ✅ 3.350ms (SLO: <3.650ms -8.2%) vs baseline: -0.2% Memory: ✅ 54.364MB (SLO: <56.500MB -3.8%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.358ms (SLO: <3.650ms -8.0%) vs baseline: +0.5% Memory: ✅ 54.261MB (SLO: <60.000MB -9.6%) vs baseline: +4.8%
|
Description
PLW0244 provides us the same type of check that
slotscheckgives us. The only main difference is ruff/PLW0244 is a static analysis check andslotscheckactually imports the code to validate the final evaluated properties/class hierarchy.Testing
Risks
Additional Notes