-
Notifications
You must be signed in to change notification settings - Fork 470
chore(profiling): merge profiling tests #15310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 273 ± 5 ms. The average import time from base is: 285 ± 6 ms. The import time difference between this PR and base is: -12.0 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate taegyunkim/prof-12836-test-cleanup (6afa0da) with baseline main (dbe8eb7) 🟡 Near SLO Breach (3 suites)🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.592ms (SLO: <4.750ms -3.3%) vs baseline: -0.2% Memory: ✅ 64.033MB (SLO: <66.500MB -3.7%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.639ms (SLO: <6.750ms 🟡 -1.6%) vs baseline: +0.4% Memory: ✅ 64.368MB (SLO: <66.500MB -3.2%) vs baseline: +4.7% ✅ appsec-telemetryTime: ✅ 4.587ms (SLO: <4.750ms -3.4%) vs baseline: -0.1% Memory: ✅ 64.031MB (SLO: <66.500MB -3.7%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.857ms (SLO: <2.000ms -7.1%) vs baseline: +0.2% Memory: ✅ 47.950MB (SLO: <49.500MB -3.1%) vs baseline: +5.0% ✅ iast-getTime: ✅ 1.858ms (SLO: <2.000ms -7.1%) vs baseline: ~same Memory: ✅ 44.426MB (SLO: <49.000MB -9.3%) vs baseline: +4.9% ✅ profilerTime: ✅ 1.931ms (SLO: <2.100ms -8.1%) vs baseline: +0.3% Memory: ✅ 48.456MB (SLO: <50.000MB -3.1%) vs baseline: +5.0% ✅ resource-renamingTime: ✅ 3.369ms (SLO: <3.650ms -7.7%) vs baseline: +0.1% Memory: ✅ 54.738MB (SLO: <56.000MB -2.3%) vs baseline: +4.7% ✅ tracerTime: ✅ 3.367ms (SLO: <3.650ms -7.8%) vs baseline: +0.4% Memory: ✅ 54.299MB (SLO: <56.500MB -3.9%) vs baseline: +4.4% ✅ tracer-nativeTime: ✅ 3.363ms (SLO: <3.650ms -7.9%) vs baseline: ~same Memory: ✅ 54.632MB (SLO: <60.000MB -8.9%) vs baseline: +4.9% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 39.373ms (SLO: <47.150ms 📉 -16.5%) vs baseline: +1.5% Memory: ✅ 39.032MB (SLO: <47.000MB 📉 -17.0%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 258.433ms (SLO: <344.800ms 📉 -25.0%) vs baseline: +0.6% Memory: ✅ 43.352MB (SLO: <47.500MB -8.7%) vs baseline: +5.0% ✅ add-tagsTime: ✅ 315.199ms (SLO: <321.000ms 🟡 -1.8%) vs baseline: ~same Memory: ✅ 43.391MB (SLO: <47.500MB -8.6%) vs baseline: +5.0% ✅ get-contextTime: ✅ 79.030ms (SLO: <92.350ms 📉 -14.4%) vs baseline: +0.8% Memory: ✅ 39.318MB (SLO: <46.500MB 📉 -15.4%) vs baseline: +4.9% ✅ is-recordingTime: ✅ 36.405ms (SLO: <44.500ms 📉 -18.2%) vs baseline: +1.0% Memory: ✅ 38.839MB (SLO: <47.500MB 📉 -18.2%) vs baseline: +4.8% ✅ record-exceptionTime: ✅ 56.956ms (SLO: <67.650ms 📉 -15.8%) vs baseline: -0.9% Memory: ✅ 39.349MB (SLO: <47.000MB 📉 -16.3%) vs baseline: +4.6% ✅ set-statusTime: ✅ 42.396ms (SLO: <50.400ms 📉 -15.9%) vs baseline: -0.6% Memory: ✅ 38.773MB (SLO: <47.000MB 📉 -17.5%) vs baseline: +4.8% ✅ startTime: ✅ 35.526ms (SLO: <43.450ms 📉 -18.2%) vs baseline: +1.1% Memory: ✅ 38.790MB (SLO: <47.000MB 📉 -17.5%) vs baseline: +4.4% ✅ start-finishTime: ✅ 82.053ms (SLO: <88.000ms -6.8%) vs baseline: +0.8% Memory: ✅ 36.569MB (SLO: <46.500MB 📉 -21.4%) vs baseline: +5.0% ✅ start-finish-telemetryTime: ✅ 83.319ms (SLO: <89.000ms -6.4%) vs baseline: ~same Memory: ✅ 36.667MB (SLO: <46.500MB 📉 -21.1%) vs baseline: +4.9% ✅ update-nameTime: ✅ 37.021ms (SLO: <45.150ms 📉 -18.0%) vs baseline: ~same Memory: ✅ 39.049MB (SLO: <47.000MB 📉 -16.9%) vs baseline: +5.1% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.033µs (SLO: <20.000µs 📉 -84.8%) vs baseline: +3.1% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.8% ✅ 1-count-metrics-100-timesTime: ✅ 199.680µs (SLO: <220.000µs -9.2%) vs baseline: -0.5% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.360µs (SLO: <20.000µs 📉 -83.2%) vs baseline: +0.2% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +4.8% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.235µs (SLO: <220.000µs 🟡 -1.3%) vs baseline: +0.2% Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +4.7% ✅ 1-gauge-metric-1-timesTime: ✅ 2.175µs (SLO: <20.000µs 📉 -89.1%) vs baseline: -0.4% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +5.3% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.241µs (SLO: <150.000µs -9.2%) vs baseline: -0.7% Memory: ✅ 34.426MB (SLO: <35.500MB -3.0%) vs baseline: +4.7% ✅ 1-rate-metric-1-timesTime: ✅ 3.121µs (SLO: <20.000µs 📉 -84.4%) vs baseline: +0.7% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 213.936µs (SLO: <250.000µs 📉 -14.4%) vs baseline: +0.2% Memory: ✅ 34.583MB (SLO: <35.500MB -2.6%) vs baseline: +5.2% ✅ 100-count-metrics-100-timesTime: ✅ 19.908ms (SLO: <22.000ms -9.5%) vs baseline: -0.3% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.268ms (SLO: <2.300ms 🟡 -1.4%) vs baseline: -1.9% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.8% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.410ms (SLO: <1.550ms -9.0%) vs baseline: +0.2% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +5.1% ✅ 100-rate-metrics-100-timesTime: ✅ 2.177ms (SLO: <2.550ms 📉 -14.6%) vs baseline: ~same Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.696µs (SLO: <20.000µs 📉 -76.5%) vs baseline: +1.5% Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 174.760µs (SLO: <250.000µs 📉 -30.1%) vs baseline: -0.3% Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.121ms (SLO: <2.500ms 📉 -15.2%) vs baseline: +0.5% Memory: ✅ 35.271MB (SLO: <36.500MB -3.4%) vs baseline: +4.7%
|
KowalskiThomas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me!
@taegyunkim , I'm not sure of the entire plan to cleanup naming, but seems to me you could reduce some of that work by doing this PR in reverse (i.e. move all test files from Any thoughts? |
815c150 to
cdc171a
Compare
cdc171a to
dbcdc56
Compare
|
@vlad-scherbich updated the PR by removing |
6a0f467 to
61a69b0
Compare
Description
For each
test_*.pyintests/profiling/directory, moved each test into file with same name intests/profiling_v2/directory.I'll do another round of cleanup PR to remove
_v2suffixes from riotfile and possibly from stack_v2 moduleTesting
Risks
Additional Notes
PROF-12836