-
Notifications
You must be signed in to change notification settings - Fork 469
chore: drop 3.8 support in bytecode instrumentation #15314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We clean up sources by removing CPython 3.8 support from bytecode instrumentation.
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 258 ± 5 ms. The average import time from base is: 265 ± 5 ms. The import time difference between this PR and base is: -6.7 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate chore/bytecode-injection-drop-38 (80d8806) with baseline main (c9b3088) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.411µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +2.0% Memory: ✅ 39.833MB (SLO: <41.500MB -4.0%) vs baseline: +4.8% ✅ add_inplace_aspectTime: ✅ 0.414µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +2.9% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +4.9% ✅ add_inplace_noaspectTime: ✅ 0.317µs (SLO: <10.000µs 📉 -96.8%) vs baseline: ~same Memory: ✅ 39.911MB (SLO: <41.500MB -3.8%) vs baseline: +5.8% ✅ add_noaspectTime: ✅ 0.280µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.8% Memory: ✅ 39.400MB (SLO: <41.500MB -5.1%) vs baseline: +4.5% ✅ bytearray_aspectTime: ✅ 1.318µs (SLO: <10.000µs 📉 -86.8%) vs baseline: +0.7% Memory: ✅ 39.852MB (SLO: <41.500MB -4.0%) vs baseline: +4.9% ✅ bytearray_extend_aspectTime: ✅ 1.518µs (SLO: <10.000µs 📉 -84.8%) vs baseline: +1.7% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.5% ✅ bytearray_extend_noaspectTime: ✅ 0.613µs (SLO: <10.000µs 📉 -93.9%) vs baseline: -1.1% Memory: ✅ 39.813MB (SLO: <41.500MB -4.1%) vs baseline: +4.7% ✅ bytearray_noaspectTime: ✅ 0.485µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.5% Memory: ✅ 39.911MB (SLO: <41.500MB -3.8%) vs baseline: +5.8% ✅ bytes_aspectTime: ✅ 1.409µs (SLO: <10.000µs 📉 -85.9%) vs baseline: 📈 +10.2% Memory: ✅ 39.852MB (SLO: <41.500MB -4.0%) vs baseline: +4.9% ✅ bytes_noaspectTime: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: ~same Memory: ✅ 39.813MB (SLO: <41.500MB -4.1%) vs baseline: +5.1% ✅ bytesio_aspectTime: ✅ 1.284µs (SLO: <10.000µs 📉 -87.2%) vs baseline: -2.8% Memory: ✅ 39.892MB (SLO: <41.500MB -3.9%) vs baseline: +5.1% ✅ bytesio_noaspectTime: ✅ 0.495µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.2% Memory: ✅ 39.911MB (SLO: <41.500MB -3.8%) vs baseline: +4.9% ✅ capitalize_aspectTime: ✅ 0.743µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +1.1% Memory: ✅ 39.813MB (SLO: <41.500MB -4.1%) vs baseline: +5.7% ✅ capitalize_noaspectTime: ✅ 0.434µs (SLO: <10.000µs 📉 -95.7%) vs baseline: +0.4% Memory: ✅ 39.911MB (SLO: <41.500MB -3.8%) vs baseline: +6.0% ✅ casefold_aspectTime: ✅ 0.739µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.8% Memory: ✅ 39.754MB (SLO: <41.500MB -4.2%) vs baseline: +4.4% ✅ casefold_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.5% Memory: ✅ 39.872MB (SLO: <41.500MB -3.9%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 0.730µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +0.4% Memory: ✅ 39.793MB (SLO: <41.500MB -4.1%) vs baseline: +5.4% ✅ decode_noaspectTime: ✅ 0.420µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.2% Memory: ✅ 39.872MB (SLO: <41.500MB -3.9%) vs baseline: +4.8% ✅ encode_aspectTime: ✅ 0.711µs (SLO: <10.000µs 📉 -92.9%) vs baseline: ~same Memory: ✅ 39.793MB (SLO: <41.500MB -4.1%) vs baseline: +6.0% ✅ encode_noaspectTime: ✅ 0.402µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +0.1% Memory: ✅ 39.852MB (SLO: <41.500MB -4.0%) vs baseline: +4.5% ✅ format_aspectTime: ✅ 3.370µs (SLO: <10.000µs 📉 -66.3%) vs baseline: ~same Memory: ✅ 39.852MB (SLO: <41.500MB -4.0%) vs baseline: +5.9% ✅ format_map_aspectTime: ✅ 3.484µs (SLO: <10.000µs 📉 -65.2%) vs baseline: -1.8% Memory: ✅ 39.892MB (SLO: <41.500MB -3.9%) vs baseline: +6.1% ✅ format_map_noaspectTime: ✅ 0.780µs (SLO: <10.000µs 📉 -92.2%) vs baseline: +1.1% Memory: ✅ 39.872MB (SLO: <41.500MB -3.9%) vs baseline: +5.6% ✅ format_noaspectTime: ✅ 0.597µs (SLO: <10.000µs 📉 -94.0%) vs baseline: +0.4% Memory: ✅ 39.931MB (SLO: <41.500MB -3.8%) vs baseline: +4.9% ✅ index_aspectTime: ✅ 0.359µs (SLO: <10.000µs 📉 -96.4%) vs baseline: -1.6% Memory: ✅ 39.833MB (SLO: <41.500MB -4.0%) vs baseline: +4.7% ✅ index_noaspectTime: ✅ 0.279µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.8% Memory: ✅ 39.951MB (SLO: <41.500MB -3.7%) vs baseline: +5.0% ✅ join_aspectTime: ✅ 1.392µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +0.2% Memory: ✅ 39.931MB (SLO: <41.500MB -3.8%) vs baseline: +5.0% ✅ join_noaspectTime: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.5% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.7% ✅ ljust_aspectTime: ✅ 2.507µs (SLO: <20.000µs 📉 -87.5%) vs baseline: ~same Memory: ✅ 39.813MB (SLO: <41.500MB -4.1%) vs baseline: +5.6% ✅ ljust_noaspectTime: ✅ 0.407µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.2% Memory: ✅ 39.911MB (SLO: <41.500MB -3.8%) vs baseline: +4.6% ✅ lower_aspectTime: ✅ 2.195µs (SLO: <10.000µs 📉 -78.1%) vs baseline: +0.6% Memory: ✅ 39.852MB (SLO: <41.500MB -4.0%) vs baseline: +6.1% ✅ lower_noaspectTime: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.7% Memory: ✅ 39.833MB (SLO: <41.500MB -4.0%) vs baseline: +4.7% ✅ lstrip_aspectTime: ✅ 2.230µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +0.7% Memory: ✅ 39.754MB (SLO: <41.500MB -4.2%) vs baseline: +5.4% ✅ lstrip_noaspectTime: ✅ 0.377µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -1.5% Memory: ✅ 39.931MB (SLO: <41.500MB -3.8%) vs baseline: +5.1% ✅ modulo_aspectTime: ✅ 1.045µs (SLO: <10.000µs 📉 -89.6%) vs baseline: +1.2% Memory: ✅ 39.793MB (SLO: <41.500MB -4.1%) vs baseline: +5.5% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.639µs (SLO: <10.000µs 📉 -83.6%) vs baseline: +5.6% Memory: ✅ 39.872MB (SLO: <41.500MB -3.9%) vs baseline: +5.9% ✅ modulo_aspect_for_bytesTime: ✅ 0.983µs (SLO: <10.000µs 📉 -90.2%) vs baseline: -1.9% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +4.6% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.247µs (SLO: <10.000µs 📉 -87.5%) vs baseline: -0.4% Memory: ✅ 39.911MB (SLO: <41.500MB -3.8%) vs baseline: +5.8% ✅ modulo_noaspectTime: ✅ 0.628µs (SLO: <10.000µs 📉 -93.7%) vs baseline: +0.5% Memory: ✅ 39.911MB (SLO: <41.500MB -3.8%) vs baseline: +4.9% ✅ replace_aspectTime: ✅ 4.855µs (SLO: <10.000µs 📉 -51.4%) vs baseline: +1.0% Memory: ✅ 39.833MB (SLO: <41.500MB -4.0%) vs baseline: +5.6% ✅ replace_noaspectTime: ✅ 0.462µs (SLO: <10.000µs 📉 -95.4%) vs baseline: ~same Memory: ✅ 39.951MB (SLO: <41.500MB -3.7%) vs baseline: +5.1% ✅ repr_aspectTime: ✅ 0.903µs (SLO: <10.000µs 📉 -91.0%) vs baseline: -0.5% Memory: ✅ 39.793MB (SLO: <41.500MB -4.1%) vs baseline: +4.8% ✅ repr_noaspectTime: ✅ 0.413µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.5% Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +5.0% ✅ rstrip_aspectTime: ✅ 1.876µs (SLO: <20.000µs 📉 -90.6%) vs baseline: +0.2% Memory: ✅ 39.931MB (SLO: <41.500MB -3.8%) vs baseline: +5.9% ✅ rstrip_noaspectTime: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.8% Memory: ✅ 39.833MB (SLO: <41.500MB -4.0%) vs baseline: +4.7% ✅ slice_aspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.5% Memory: ✅ 39.931MB (SLO: <41.500MB -3.8%) vs baseline: +4.8% ✅ slice_noaspectTime: ✅ 0.445µs (SLO: <10.000µs 📉 -95.6%) vs baseline: -0.9% Memory: ✅ 39.872MB (SLO: <41.500MB -3.9%) vs baseline: +5.0% ✅ stringio_aspectTime: ✅ 1.549µs (SLO: <10.000µs 📉 -84.5%) vs baseline: ~same Memory: ✅ 39.813MB (SLO: <41.500MB -4.1%) vs baseline: +4.7% ✅ stringio_noaspectTime: ✅ 0.727µs (SLO: <10.000µs 📉 -92.7%) vs baseline: +1.0% Memory: ✅ 39.852MB (SLO: <41.500MB -4.0%) vs baseline: +4.8% ✅ strip_aspectTime: ✅ 2.207µs (SLO: <20.000µs 📉 -89.0%) vs baseline: +1.1% Memory: ✅ 39.951MB (SLO: <41.500MB -3.7%) vs baseline: +6.3% ✅ strip_noaspectTime: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: +0.7% Memory: ✅ 39.833MB (SLO: <41.500MB -4.0%) vs baseline: +4.9% ✅ swapcase_aspectTime: ✅ 2.382µs (SLO: <10.000µs 📉 -76.2%) vs baseline: -0.2% Memory: ✅ 39.911MB (SLO: <41.500MB -3.8%) vs baseline: +5.7% ✅ swapcase_noaspectTime: ✅ 0.538µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +0.6% Memory: ✅ 39.833MB (SLO: <41.500MB -4.0%) vs baseline: +4.9% ✅ title_aspectTime: ✅ 2.310µs (SLO: <10.000µs 📉 -76.9%) vs baseline: -0.8% Memory: ✅ 39.852MB (SLO: <41.500MB -4.0%) vs baseline: +5.6% ✅ title_noaspectTime: ✅ 0.502µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.4% Memory: ✅ 39.911MB (SLO: <41.500MB -3.8%) vs baseline: +5.0% ✅ translate_aspectTime: ✅ 3.184µs (SLO: <10.000µs 📉 -68.2%) vs baseline: +0.3% Memory: ✅ 39.852MB (SLO: <41.500MB -4.0%) vs baseline: +5.6% ✅ translate_noaspectTime: ✅ 1.038µs (SLO: <10.000µs 📉 -89.6%) vs baseline: -0.7% Memory: ✅ 39.852MB (SLO: <41.500MB -4.0%) vs baseline: +5.8% ✅ upper_aspectTime: ✅ 2.202µs (SLO: <10.000µs 📉 -78.0%) vs baseline: +0.8% Memory: ✅ 39.872MB (SLO: <41.500MB -3.9%) vs baseline: +6.0% ✅ upper_noaspectTime: ✅ 0.369µs (SLO: <10.000µs 📉 -96.3%) vs baseline: ~same Memory: ✅ 39.833MB (SLO: <41.500MB -4.0%) vs baseline: +4.9% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.499µs (SLO: <10.000µs 📉 -55.0%) vs baseline: +5.0% Memory: ✅ 39.911MB (SLO: <41.000MB -2.7%) vs baseline: +4.9% ✅ ospathbasename_noaspectTime: ✅ 1.088µs (SLO: <10.000µs 📉 -89.1%) vs baseline: +0.7% Memory: ✅ 39.931MB (SLO: <41.000MB -2.6%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 7.093µs (SLO: <10.000µs 📉 -29.1%) vs baseline: 📈 +15.3% Memory: ✅ 39.892MB (SLO: <41.000MB -2.7%) vs baseline: +4.9% ✅ ospathjoin_noaspectTime: ✅ 2.284µs (SLO: <10.000µs 📉 -77.2%) vs baseline: -0.6% Memory: ✅ 39.872MB (SLO: <41.000MB -2.8%) vs baseline: +4.8% ✅ ospathnormcase_aspectTime: ✅ 4.004µs (SLO: <10.000µs 📉 -60.0%) vs baseline: 📈 +13.5% Memory: ✅ 39.793MB (SLO: <41.000MB -2.9%) vs baseline: +4.8% ✅ ospathnormcase_noaspectTime: ✅ 0.574µs (SLO: <10.000µs 📉 -94.3%) vs baseline: +1.3% Memory: ✅ 39.931MB (SLO: <41.000MB -2.6%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 4.862µs (SLO: <10.000µs 📉 -51.4%) vs baseline: -0.6% Memory: ✅ 39.931MB (SLO: <41.000MB -2.6%) vs baseline: +4.7% ✅ ospathsplit_noaspectTime: ✅ 1.594µs (SLO: <10.000µs 📉 -84.1%) vs baseline: +0.6% Memory: ✅ 39.852MB (SLO: <41.000MB -2.8%) vs baseline: +4.4% ✅ ospathsplitdrive_aspectTime: ✅ 4.202µs (SLO: <10.000µs 📉 -58.0%) vs baseline: 📈 +12.4% Memory: ✅ 39.872MB (SLO: <41.000MB -2.8%) vs baseline: +4.9% ✅ ospathsplitdrive_noaspectTime: ✅ 0.693µs (SLO: <10.000µs 📉 -93.1%) vs baseline: -0.7% Memory: ✅ 39.911MB (SLO: <41.000MB -2.7%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 5.348µs (SLO: <10.000µs 📉 -46.5%) vs baseline: 📈 +16.2% Memory: ✅ 39.813MB (SLO: <41.000MB -2.9%) vs baseline: +4.5% ✅ ospathsplitext_noaspectTime: ✅ 1.382µs (SLO: <10.000µs 📉 -86.2%) vs baseline: +0.2% Memory: ✅ 39.911MB (SLO: <41.000MB -2.7%) vs baseline: +4.8% 🟡 Near SLO Breach (1 suite)🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.595ms (SLO: <4.750ms -3.3%) vs baseline: +0.5% Memory: ✅ 64.022MB (SLO: <66.500MB -3.7%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.620ms (SLO: <6.750ms 🟡 -1.9%) vs baseline: ~same Memory: ✅ 64.438MB (SLO: <66.500MB -3.1%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.590ms (SLO: <4.750ms -3.4%) vs baseline: ~same Memory: ✅ 63.945MB (SLO: <66.500MB -3.8%) vs baseline: +4.7% ✅ debuggerTime: ✅ 1.855ms (SLO: <2.000ms -7.3%) vs baseline: +0.2% Memory: ✅ 47.944MB (SLO: <49.500MB -3.1%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.858ms (SLO: <2.000ms -7.1%) vs baseline: +0.2% Memory: ✅ 44.734MB (SLO: <49.000MB -8.7%) vs baseline: +4.9% ✅ profilerTime: ✅ 1.922ms (SLO: <2.100ms -8.5%) vs baseline: ~same Memory: ✅ 48.456MB (SLO: <50.000MB -3.1%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 3.371ms (SLO: <3.650ms -7.7%) vs baseline: -0.2% Memory: ✅ 54.687MB (SLO: <56.000MB -2.3%) vs baseline: +4.6% ✅ tracerTime: ✅ 3.364ms (SLO: <3.650ms -7.8%) vs baseline: +0.3% Memory: ✅ 54.824MB (SLO: <56.500MB -3.0%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.364ms (SLO: <3.650ms -7.8%) vs baseline: +0.2% Memory: ✅ 54.767MB (SLO: <60.000MB -8.7%) vs baseline: +5.0%
|
Description
We clean up sources by removing CPython 3.8 support from bytecode instrumentation.