-
Notifications
You must be signed in to change notification settings - Fork 469
ci: fail when we cannot get the computed library version #15326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 253 ± 2 ms. The average import time from base is: 259 ± 3 ms. The import time difference between this PR and base is: -5.9 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
1255ee4 to
354a934
Compare
Performance SLOsComparing candidate brettlangdon/compute.version.errors (7bff68c) with baseline main (2f7da21) 📈 Performance Regressions (1 suite)📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.298µs (SLO: <20.000µs 📉 -83.5%) vs baseline: 📈 +13.8% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 198.539µs (SLO: <220.000µs -9.8%) vs baseline: -0.2% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.6% ✅ 1-distribution-metric-1-timesTime: ✅ 3.325µs (SLO: <20.000µs 📉 -83.4%) vs baseline: +0.7% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.6% ✅ 1-distribution-metrics-100-timesTime: ✅ 215.741µs (SLO: <220.000µs 🟡 -1.9%) vs baseline: -0.8% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +5.0% ✅ 1-gauge-metric-1-timesTime: ✅ 2.168µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -1.3% Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +4.6% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.474µs (SLO: <150.000µs -8.4%) vs baseline: +0.6% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.300µs (SLO: <20.000µs 📉 -83.5%) vs baseline: +8.3% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +5.1% ✅ 1-rate-metrics-100-timesTime: ✅ 211.912µs (SLO: <250.000µs 📉 -15.2%) vs baseline: +0.4% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.146ms (SLO: <22.000ms -8.4%) vs baseline: +1.6% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.254ms (SLO: <2.300ms -2.0%) vs baseline: -1.3% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.418ms (SLO: <1.550ms -8.5%) vs baseline: +0.8% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +5.0% ✅ 100-rate-metrics-100-timesTime: ✅ 2.202ms (SLO: <2.550ms 📉 -13.6%) vs baseline: +0.8% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.944µs (SLO: <20.000µs 📉 -75.3%) vs baseline: +7.9% Memory: ✅ 34.505MB (SLO: <35.500MB -2.8%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 173.977µs (SLO: <250.000µs 📉 -30.4%) vs baseline: -0.5% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.134ms (SLO: <2.500ms 📉 -14.7%) vs baseline: +0.7% Memory: ✅ 35.291MB (SLO: <36.500MB -3.3%) vs baseline: +4.6% 🟡 Near SLO Breach (1 suite)🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.591ms (SLO: <4.750ms -3.3%) vs baseline: +0.1% Memory: ✅ 63.974MB (SLO: <66.500MB -3.8%) vs baseline: +4.7% ✅ appsec-postTime: ✅ 6.621ms (SLO: <6.750ms 🟡 -1.9%) vs baseline: -0.2% Memory: ✅ 64.268MB (SLO: <66.500MB -3.4%) vs baseline: +4.7% ✅ appsec-telemetryTime: ✅ 4.605ms (SLO: <4.750ms -3.0%) vs baseline: +0.2% Memory: ✅ 64.035MB (SLO: <66.500MB -3.7%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.859ms (SLO: <2.000ms -7.1%) vs baseline: -0.1% Memory: ✅ 47.911MB (SLO: <49.500MB -3.2%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.870ms (SLO: <2.000ms -6.5%) vs baseline: +0.7% Memory: ✅ 44.644MB (SLO: <49.000MB -8.9%) vs baseline: +5.4% ✅ profilerTime: ✅ 1.933ms (SLO: <2.100ms -8.0%) vs baseline: +0.2% Memory: ✅ 48.420MB (SLO: <50.000MB -3.2%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 3.377ms (SLO: <3.650ms -7.5%) vs baseline: ~same Memory: ✅ 54.715MB (SLO: <56.000MB -2.3%) vs baseline: +5.2% ✅ tracerTime: ✅ 3.361ms (SLO: <3.650ms -7.9%) vs baseline: ~same Memory: ✅ 54.737MB (SLO: <56.500MB -3.1%) vs baseline: +5.2% ✅ tracer-nativeTime: ✅ 3.363ms (SLO: <3.650ms -7.9%) vs baseline: +0.2% Memory: ✅ 54.630MB (SLO: <60.000MB -9.0%) vs baseline: +4.8%
|
Description
This is failing in CI sometimes, where we cannot get the artifact (unclear why), but it is causing issues for the s3 publish job instead of the compute job being the one which fails.
Testing
Risks
Additional Notes