-
Notifications
You must be signed in to change notification settings - Fork 469
chore(profiling): make memory alloc profiler tests more end-to-end #15330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 226 ± 3 ms. The average import time from base is: 229 ± 3 ms. The import time difference between this PR and base is: -3.6 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate dsn/memalloc-tests-take-2 (b3cae40) with baseline main (441fc1c) 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.297µs (SLO: <10.000µs 📉 -57.0%) vs baseline: -0.7% Memory: ✅ 39.793MB (SLO: <41.000MB -2.9%) vs baseline: +4.5% ✅ ospathbasename_noaspectTime: ✅ 1.079µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -0.9% Memory: ✅ 39.774MB (SLO: <41.000MB -3.0%) vs baseline: +4.6% ✅ ospathjoin_aspectTime: ✅ 6.170µs (SLO: <10.000µs 📉 -38.3%) vs baseline: +0.6% Memory: ✅ 39.754MB (SLO: <41.000MB -3.0%) vs baseline: +4.5% ✅ ospathjoin_noaspectTime: ✅ 2.292µs (SLO: <10.000µs 📉 -77.1%) vs baseline: +0.1% Memory: ✅ 39.734MB (SLO: <41.000MB -3.1%) vs baseline: +4.5% ✅ ospathnormcase_aspectTime: ✅ 4.007µs (SLO: <10.000µs 📉 -59.9%) vs baseline: 📈 +13.3% Memory: ✅ 39.872MB (SLO: <41.000MB -2.8%) vs baseline: +4.9% ✅ ospathnormcase_noaspectTime: ✅ 0.571µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -1.0% Memory: ✅ 39.813MB (SLO: <41.000MB -2.9%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 4.890µs (SLO: <10.000µs 📉 -51.1%) vs baseline: -0.4% Memory: ✅ 39.852MB (SLO: <41.000MB -2.8%) vs baseline: +4.8% ✅ ospathsplit_noaspectTime: ✅ 1.596µs (SLO: <10.000µs 📉 -84.0%) vs baseline: -0.7% Memory: ✅ 39.872MB (SLO: <41.000MB -2.8%) vs baseline: +4.7% ✅ ospathsplitdrive_aspectTime: ✅ 3.724µs (SLO: <10.000µs 📉 -62.8%) vs baseline: +0.3% Memory: ✅ 39.892MB (SLO: <41.000MB -2.7%) vs baseline: +5.0% ✅ ospathsplitdrive_noaspectTime: ✅ 0.702µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.2% Memory: ✅ 39.852MB (SLO: <41.000MB -2.8%) vs baseline: +5.1% ✅ ospathsplitext_aspectTime: ✅ 4.648µs (SLO: <10.000µs 📉 -53.5%) vs baseline: +1.5% Memory: ✅ 39.951MB (SLO: <41.000MB -2.6%) vs baseline: +4.8% ✅ ospathsplitext_noaspectTime: ✅ 1.372µs (SLO: <10.000µs 📉 -86.3%) vs baseline: -0.6% Memory: ✅ 39.931MB (SLO: <41.000MB -2.6%) vs baseline: +5.0% 🟡 Near SLO Breach (4 suites)🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.599ms (SLO: <4.750ms -3.2%) vs baseline: ~same Memory: ✅ 64.048MB (SLO: <66.500MB -3.7%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.617ms (SLO: <6.750ms 🟡 -2.0%) vs baseline: ~same Memory: ✅ 64.422MB (SLO: <66.500MB -3.1%) vs baseline: +5.0% ✅ appsec-telemetryTime: ✅ 4.598ms (SLO: <4.750ms -3.2%) vs baseline: ~same Memory: ✅ 63.968MB (SLO: <66.500MB -3.8%) vs baseline: +4.7% ✅ debuggerTime: ✅ 1.858ms (SLO: <2.000ms -7.1%) vs baseline: -0.3% Memory: ✅ 47.811MB (SLO: <49.500MB -3.4%) vs baseline: +4.7% ✅ iast-getTime: ✅ 1.858ms (SLO: <2.000ms -7.1%) vs baseline: ~same Memory: ✅ 44.621MB (SLO: <49.000MB -8.9%) vs baseline: +4.6% ✅ profilerTime: ✅ 1.927ms (SLO: <2.100ms -8.2%) vs baseline: -0.2% Memory: ✅ 48.360MB (SLO: <50.000MB -3.3%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 3.358ms (SLO: <3.650ms -8.0%) vs baseline: -0.2% Memory: ✅ 54.714MB (SLO: <56.000MB -2.3%) vs baseline: +4.9% ✅ tracerTime: ✅ 3.353ms (SLO: <3.650ms -8.1%) vs baseline: ~same Memory: ✅ 54.574MB (SLO: <56.500MB -3.4%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 3.353ms (SLO: <3.650ms -8.1%) vs baseline: +0.1% Memory: ✅ 54.632MB (SLO: <60.000MB -8.9%) vs baseline: +5.1% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 38.685ms (SLO: <47.150ms 📉 -18.0%) vs baseline: ~same Memory: ✅ 39.062MB (SLO: <47.000MB 📉 -16.9%) vs baseline: +4.6% ✅ add-metricsTime: ✅ 259.309ms (SLO: <344.800ms 📉 -24.8%) vs baseline: +0.7% Memory: ✅ 43.334MB (SLO: <47.500MB -8.8%) vs baseline: +4.9% ✅ add-tagsTime: ✅ 315.372ms (SLO: <321.000ms 🟡 -1.8%) vs baseline: ~same Memory: ✅ 43.273MB (SLO: <47.500MB -8.9%) vs baseline: +4.9% ✅ get-contextTime: ✅ 78.773ms (SLO: <92.350ms 📉 -14.7%) vs baseline: ~same Memory: ✅ 39.404MB (SLO: <46.500MB 📉 -15.3%) vs baseline: +5.0% ✅ is-recordingTime: ✅ 36.273ms (SLO: <44.500ms 📉 -18.5%) vs baseline: +0.2% Memory: ✅ 38.973MB (SLO: <47.500MB 📉 -18.0%) vs baseline: +4.9% ✅ record-exceptionTime: ✅ 57.331ms (SLO: <67.650ms 📉 -15.3%) vs baseline: +0.2% Memory: ✅ 39.550MB (SLO: <47.000MB 📉 -15.9%) vs baseline: +4.8% ✅ set-statusTime: ✅ 42.586ms (SLO: <50.400ms 📉 -15.5%) vs baseline: -0.1% Memory: ✅ 39.009MB (SLO: <47.000MB 📉 -17.0%) vs baseline: +4.7% ✅ startTime: ✅ 36.004ms (SLO: <43.450ms 📉 -17.1%) vs baseline: +1.4% Memory: ✅ 38.979MB (SLO: <47.000MB 📉 -17.1%) vs baseline: +4.7% ✅ start-finishTime: ✅ 81.729ms (SLO: <88.000ms -7.1%) vs baseline: -0.1% Memory: ✅ 36.608MB (SLO: <46.500MB 📉 -21.3%) vs baseline: +4.4% ✅ start-finish-telemetryTime: ✅ 83.616ms (SLO: <89.000ms -6.0%) vs baseline: +0.2% Memory: ✅ 36.726MB (SLO: <46.500MB 📉 -21.0%) vs baseline: +4.7% ✅ update-nameTime: ✅ 36.910ms (SLO: <45.150ms 📉 -18.2%) vs baseline: -0.4% Memory: ✅ 39.049MB (SLO: <47.000MB 📉 -16.9%) vs baseline: +5.0% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.927µs (SLO: <20.000µs 📉 -85.4%) vs baseline: +0.8% Memory: ✅ 34.623MB (SLO: <35.500MB -2.5%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 201.003µs (SLO: <220.000µs -8.6%) vs baseline: +0.3% Memory: ✅ 34.701MB (SLO: <35.500MB -2.2%) vs baseline: +5.2% ✅ 1-distribution-metric-1-timesTime: ✅ 3.273µs (SLO: <20.000µs 📉 -83.6%) vs baseline: +0.3% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.3% ✅ 1-distribution-metrics-100-timesTime: ✅ 214.183µs (SLO: <230.000µs -6.9%) vs baseline: -0.2% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +5.0% ✅ 1-gauge-metric-1-timesTime: ✅ 2.193µs (SLO: <20.000µs 📉 -89.0%) vs baseline: +0.7% Memory: ✅ 34.642MB (SLO: <35.500MB -2.4%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.217µs (SLO: <150.000µs -8.5%) vs baseline: +0.7% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +5.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.115µs (SLO: <20.000µs 📉 -84.4%) vs baseline: +2.4% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 214.224µs (SLO: <250.000µs 📉 -14.3%) vs baseline: ~same Memory: ✅ 34.682MB (SLO: <35.500MB -2.3%) vs baseline: +5.0% ✅ 100-count-metrics-100-timesTime: ✅ 20.236ms (SLO: <22.000ms -8.0%) vs baseline: -0.3% Memory: ✅ 34.642MB (SLO: <35.500MB -2.4%) vs baseline: +4.8% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.284ms (SLO: <2.300ms 🟡 -0.7%) vs baseline: +0.6% Memory: ✅ 34.623MB (SLO: <35.500MB -2.5%) vs baseline: +4.8% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.410ms (SLO: <1.550ms -9.0%) vs baseline: +0.2% Memory: ✅ 34.623MB (SLO: <35.500MB -2.5%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.215ms (SLO: <2.550ms 📉 -13.1%) vs baseline: -0.2% Memory: ✅ 34.682MB (SLO: <35.500MB -2.3%) vs baseline: +5.1% ✅ flush-1-metricTime: ✅ 4.479µs (SLO: <20.000µs 📉 -77.6%) vs baseline: +0.4% Memory: ✅ 34.721MB (SLO: <35.500MB -2.2%) vs baseline: +5.5% ✅ flush-100-metricsTime: ✅ 173.362µs (SLO: <250.000µs 📉 -30.7%) vs baseline: -0.5% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.5% ✅ flush-1000-metricsTime: ✅ 2.132ms (SLO: <2.500ms 📉 -14.7%) vs baseline: +0.3% Memory: ✅ 35.311MB (SLO: <36.500MB -3.3%) vs baseline: +4.6% 🟡 tracer - 6/6✅ largeTime: ✅ 28.704ms (SLO: <32.950ms 📉 -12.9%) vs baseline: -0.6% Memory: ✅ 35.783MB (SLO: <36.500MB 🟡 -2.0%) vs baseline: +4.9% ✅ mediumTime: ✅ 2.870ms (SLO: <3.200ms 📉 -10.3%) vs baseline: ~same Memory: ✅ 34.583MB (SLO: <35.500MB -2.6%) vs baseline: +4.8% ✅ smallTime: ✅ 325.552µs (SLO: <370.000µs 📉 -12.0%) vs baseline: -0.3% Memory: ✅ 34.623MB (SLO: <35.500MB -2.5%) vs baseline: +5.1%
|
Co-authored-by: T. Kowalski <[email protected]>
Co-authored-by: T. Kowalski <[email protected]>
KowalskiThomas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Limited context, but what I see makes sense to me.
Description
Previously, the tests directly tested the internal data-structures.
Modified the tests to instead create the actual pprof, then check its data.
This provides more realistic testing.
It also is a first step to enabling changing the data-structures from python to native.
Testing
Risks
Additional Notes