-
Notifications
You must be signed in to change notification settings - Fork 469
docs: add 4.0 upgrade section #15343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
brettlangdon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
funny that we only include the env var notes here, but it is consistent with the previous major versions
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 256 ± 5 ms. The average import time from base is: 265 ± 5 ms. The import time difference between this PR and base is: -8.7 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
mabdinur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call out some of the bigger changes to our api? Like the removal of set_tag_str, Python 3.8 support, and ddtrace.Pin.
Our release notes are a bit long so some of the more significant changes might be hard to detect
Performance SLOsComparing candidate emmett.butler/upgrade-docs (19f2b8d) with baseline main (33c52d1) 📈 Performance Regressions (1 suite)📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.925µs (SLO: <20.000µs 📉 -85.4%) vs baseline: -0.6% Memory: ✅ 34.583MB (SLO: <35.500MB -2.6%) vs baseline: +4.6% ✅ 1-count-metrics-100-timesTime: ✅ 204.046µs (SLO: <220.000µs -7.3%) vs baseline: +1.8% Memory: ✅ 34.623MB (SLO: <35.500MB -2.5%) vs baseline: +4.8% ✅ 1-distribution-metric-1-timesTime: ✅ 3.326µs (SLO: <20.000µs 📉 -83.4%) vs baseline: +1.5% Memory: ✅ 34.662MB (SLO: <35.500MB -2.4%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.142µs (SLO: <230.000µs -5.6%) vs baseline: +1.6% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +5.0% ✅ 1-gauge-metric-1-timesTime: ✅ 2.593µs (SLO: <20.000µs 📉 -87.0%) vs baseline: 📈 +17.0% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +5.1% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.525µs (SLO: <150.000µs -9.0%) vs baseline: ~same Memory: ✅ 34.642MB (SLO: <35.500MB -2.4%) vs baseline: +5.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.309µs (SLO: <20.000µs 📉 -83.5%) vs baseline: +7.2% Memory: ✅ 34.583MB (SLO: <35.500MB -2.6%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 215.608µs (SLO: <250.000µs 📉 -13.8%) vs baseline: +0.4% Memory: ✅ 34.623MB (SLO: <35.500MB -2.5%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.298ms (SLO: <22.000ms -7.7%) vs baseline: -0.5% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +4.8% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.268ms (SLO: <2.300ms 🟡 -1.4%) vs baseline: -0.6% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +4.8% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.418ms (SLO: <1.550ms -8.5%) vs baseline: +0.9% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +4.4% ✅ 100-rate-metrics-100-timesTime: ✅ 2.225ms (SLO: <2.550ms 📉 -12.7%) vs baseline: +0.7% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +4.6% ✅ flush-1-metricTime: ✅ 4.480µs (SLO: <20.000µs 📉 -77.6%) vs baseline: +1.0% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 173.724µs (SLO: <250.000µs 📉 -30.5%) vs baseline: +0.2% Memory: ✅ 34.701MB (SLO: <35.500MB -2.2%) vs baseline: +5.3% ✅ flush-1000-metricsTime: ✅ 2.123ms (SLO: <2.500ms 📉 -15.1%) vs baseline: -0.6% Memory: ✅ 35.330MB (SLO: <36.500MB -3.2%) vs baseline: +4.6% 🟡 Near SLO Breach (2 suites)🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.602ms (SLO: <4.750ms -3.1%) vs baseline: ~same Memory: ✅ 63.964MB (SLO: <66.500MB -3.8%) vs baseline: +4.7% ✅ appsec-postTime: ✅ 6.627ms (SLO: <6.750ms 🟡 -1.8%) vs baseline: ~same Memory: ✅ 64.476MB (SLO: <66.500MB -3.0%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.600ms (SLO: <4.750ms -3.2%) vs baseline: +0.2% Memory: ✅ 64.005MB (SLO: <66.500MB -3.8%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.858ms (SLO: <2.000ms -7.1%) vs baseline: +0.2% Memory: ✅ 47.849MB (SLO: <49.500MB -3.3%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.860ms (SLO: <2.000ms -7.0%) vs baseline: +0.1% Memory: ✅ 44.580MB (SLO: <49.000MB -9.0%) vs baseline: +4.6% ✅ profilerTime: ✅ 1.925ms (SLO: <2.100ms -8.3%) vs baseline: ~same Memory: ✅ 48.421MB (SLO: <50.000MB -3.2%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 3.379ms (SLO: <3.650ms -7.4%) vs baseline: +0.1% Memory: ✅ 54.672MB (SLO: <56.000MB -2.4%) vs baseline: +4.7% ✅ tracerTime: ✅ 3.361ms (SLO: <3.650ms -7.9%) vs baseline: -0.2% Memory: ✅ 54.730MB (SLO: <56.500MB -3.1%) vs baseline: +5.2% ✅ tracer-nativeTime: ✅ 3.367ms (SLO: <3.650ms -7.8%) vs baseline: ~same Memory: ✅ 54.634MB (SLO: <60.000MB -8.9%) vs baseline: +5.0% 🟡 span - 26/26✅ add-eventTime: ✅ 17.375ms (SLO: <22.500ms 📉 -22.8%) vs baseline: +1.2% Memory: ✅ 36.427MB (SLO: <53.000MB 📉 -31.3%) vs baseline: +4.5% ✅ add-metricsTime: ✅ 87.242ms (SLO: <93.500ms -6.7%) vs baseline: +0.5% Memory: ✅ 40.838MB (SLO: <53.000MB 📉 -22.9%) vs baseline: +4.7% ✅ add-tagsTime: ✅ 139.266ms (SLO: <155.000ms 📉 -10.2%) vs baseline: -0.1% Memory: ✅ 40.501MB (SLO: <53.000MB 📉 -23.6%) vs baseline: +4.7% ✅ get-contextTime: ✅ 16.124ms (SLO: <20.500ms 📉 -21.3%) vs baseline: ~same Memory: ✅ 36.249MB (SLO: <53.000MB 📉 -31.6%) vs baseline: +4.8% ✅ is-recordingTime: ✅ 16.295ms (SLO: <20.500ms 📉 -20.5%) vs baseline: -0.5% Memory: ✅ 36.341MB (SLO: <53.000MB 📉 -31.4%) vs baseline: +5.2% ✅ record-exceptionTime: ✅ 35.475ms (SLO: <40.000ms 📉 -11.3%) vs baseline: +0.2% Memory: ✅ 36.918MB (SLO: <53.000MB 📉 -30.3%) vs baseline: +5.3% ✅ set-statusTime: ✅ 17.798ms (SLO: <22.000ms 📉 -19.1%) vs baseline: +0.5% Memory: ✅ 36.305MB (SLO: <53.000MB 📉 -31.5%) vs baseline: +4.7% ✅ startTime: ✅ 16.095ms (SLO: <20.500ms 📉 -21.5%) vs baseline: +1.1% Memory: ✅ 36.307MB (SLO: <53.000MB 📉 -31.5%) vs baseline: +5.1% ✅ start-finishTime: ✅ 51.464ms (SLO: <52.500ms 🟡 -2.0%) vs baseline: +1.0% Memory: ✅ 34.623MB (SLO: <35.500MB -2.5%) vs baseline: +4.8% ✅ start-finish-telemetryTime: ✅ 52.425ms (SLO: <54.500ms -3.8%) vs baseline: ~same Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +4.8% ✅ start-finish-traceid128Time: ✅ 54.053ms (SLO: <57.000ms -5.2%) vs baseline: -0.5% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +5.0% ✅ start-traceid128Time: ✅ 16.324ms (SLO: <22.500ms 📉 -27.4%) vs baseline: -0.3% Memory: ✅ 36.316MB (SLO: <53.000MB 📉 -31.5%) vs baseline: +5.1% ✅ update-nameTime: ✅ 16.399ms (SLO: <22.000ms 📉 -25.5%) vs baseline: ~same Memory: ✅ 36.450MB (SLO: <53.000MB 📉 -31.2%) vs baseline: +5.0%
|
## Description This change adds a section to the upgrade documentation about how to upgrade from 3.0 to 4.0 (cherry picked from commit df81994)
|
@mabdinur I think that's a fine idea. i'll add those. |
Description
This change adds a section to the upgrade documentation about how to upgrade from 3.0 to 4.0