-
Notifications
You must be signed in to change notification settings - Fork 470
feat(debugger): disable exit spans for Code Origins #15344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 254 ± 3 ms. The average import time from base is: 261 ± 3 ms. The import time difference between this PR and base is: -6.5 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Exit spans have caused issues in Dotnet/Java, and we made the product decision to remove them from Code Origins for Spans, we'll match that behavior here.
796ce9c to
2838f99
Compare
c936a19 to
c4a860b
Compare
Performance SLOsComparing candidate tyler.finethy/remove-co-exit-spans (c4a860b) with baseline main (a82e9b1) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 5.073µs (SLO: <10.000µs 📉 -49.3%) vs baseline: 📈 +17.9% Memory: ✅ 40.324MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.6% ✅ ospathbasename_noaspectTime: ✅ 1.078µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -1.2% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.6% ✅ ospathjoin_aspectTime: ✅ 6.139µs (SLO: <10.000µs 📉 -38.6%) vs baseline: -1.0% Memory: ✅ 40.226MB (SLO: <41.000MB 🟡 -1.9%) vs baseline: +4.4% ✅ ospathjoin_noaspectTime: ✅ 2.292µs (SLO: <10.000µs 📉 -77.1%) vs baseline: +0.3% Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.4% ✅ ospathnormcase_aspectTime: ✅ 3.533µs (SLO: <10.000µs 📉 -64.7%) vs baseline: +1.1% Memory: ✅ 40.403MB (SLO: <41.000MB 🟡 -1.5%) vs baseline: +5.3% ✅ ospathnormcase_noaspectTime: ✅ 0.568µs (SLO: <10.000µs 📉 -94.3%) vs baseline: ~same Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.9% ✅ ospathsplit_aspectTime: ✅ 4.945µs (SLO: <10.000µs 📉 -50.5%) vs baseline: +1.7% Memory: ✅ 40.167MB (SLO: <41.000MB -2.0%) vs baseline: +4.5% ✅ ospathsplit_noaspectTime: ✅ 1.598µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +0.9% Memory: ✅ 40.344MB (SLO: <41.000MB 🟡 -1.6%) vs baseline: +4.7% ✅ ospathsplitdrive_aspectTime: ✅ 3.718µs (SLO: <10.000µs 📉 -62.8%) vs baseline: -0.7% Memory: ✅ 40.403MB (SLO: <41.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ ospathsplitdrive_noaspectTime: ✅ 0.698µs (SLO: <10.000µs 📉 -93.0%) vs baseline: ~same Memory: ✅ 40.305MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +4.7% ✅ ospathsplitext_aspectTime: ✅ 4.563µs (SLO: <10.000µs 📉 -54.4%) vs baseline: -1.4% Memory: ✅ 40.285MB (SLO: <41.000MB 🟡 -1.7%) vs baseline: +5.1% ✅ ospathsplitext_noaspectTime: ✅ 1.381µs (SLO: <10.000µs 📉 -86.2%) vs baseline: ~same Memory: ✅ 40.187MB (SLO: <41.000MB 🟡 -2.0%) vs baseline: +4.4% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.444µs (SLO: <20.000µs 📉 -82.8%) vs baseline: 📈 +17.9% Memory: ✅ 35.291MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 202.572µs (SLO: <220.000µs -7.9%) vs baseline: +1.2% Memory: ✅ 35.291MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +5.6% ✅ 1-distribution-metric-1-timesTime: ✅ 3.292µs (SLO: <20.000µs 📉 -83.5%) vs baseline: +1.2% Memory: ✅ 35.212MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +5.0% ✅ 1-distribution-metrics-100-timesTime: ✅ 214.960µs (SLO: <230.000µs -6.5%) vs baseline: +0.5% Memory: ✅ 35.232MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +5.3% ✅ 1-gauge-metric-1-timesTime: ✅ 2.180µs (SLO: <20.000µs 📉 -89.1%) vs baseline: -1.1% Memory: ✅ 35.291MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.619µs (SLO: <150.000µs -8.9%) vs baseline: +0.2% Memory: ✅ 35.291MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +5.6% ✅ 1-rate-metric-1-timesTime: ✅ 3.079µs (SLO: <20.000µs 📉 -84.6%) vs baseline: +0.4% Memory: ✅ 35.271MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +5.8% ✅ 1-rate-metrics-100-timesTime: ✅ 215.450µs (SLO: <250.000µs 📉 -13.8%) vs baseline: +0.5% Memory: ✅ 35.193MB (SLO: <35.500MB 🟡 -0.9%) vs baseline: +4.5% ✅ 100-count-metrics-100-timesTime: ✅ 20.377ms (SLO: <22.000ms -7.4%) vs baseline: +0.8% Memory: ✅ 35.232MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +4.6% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.246ms (SLO: <2.300ms -2.4%) vs baseline: -1.9% Memory: ✅ 35.271MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +4.7% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.408ms (SLO: <1.550ms -9.1%) vs baseline: +0.4% Memory: ✅ 35.311MB (SLO: <35.500MB 🟡 -0.5%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.202ms (SLO: <2.550ms 📉 -13.6%) vs baseline: +0.5% Memory: ✅ 35.291MB (SLO: <35.500MB 🟡 -0.6%) vs baseline: +5.2% ✅ flush-1-metricTime: ✅ 4.413µs (SLO: <20.000µs 📉 -77.9%) vs baseline: -0.4% Memory: ✅ 35.232MB (SLO: <35.500MB 🟡 -0.8%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 173.152µs (SLO: <250.000µs 📉 -30.7%) vs baseline: +0.3% Memory: ✅ 35.429MB (SLO: <35.500MB 🟡 -0.2%) vs baseline: +5.3% ✅ flush-1000-metricsTime: ✅ 2.177ms (SLO: <2.500ms 📉 -12.9%) vs baseline: -0.8% Memory: ✅ 36.117MB (SLO: <36.500MB 🟡 -1.0%) vs baseline: +5.0% 🟡 Near SLO Breach (19 suites)🟡 coreapiscenario - 10/10 (1 unstable)
|
Description
Exit spans have caused issues in Dotnet/Java, and we made the product decision to remove them from Code Origins for Spans, we'll match that behavior here.
Testing
Unittests
Risks
Decreases potential for performance regressions.
Additional Notes
N/A