-
Notifications
You must be signed in to change notification settings - Fork 469
chore(aap): improve internal api protocol [backport 4.0] #15357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
8d3e342 to
1a07672
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 253 ± 3 ms. The average import time from base is: 255 ± 3 ms. The import time difference between this PR and base is: -1.8 ± 0.1 ms. Import time breakdownThe following import paths have grown:
|
Performance SLOsComparing candidate backport-15332-to-4.0 (cbea864) with baseline 4.0 (0303e58) 📈 Performance Regressions (1 suite)📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.175µs (SLO: <20.000µs 📉 -84.1%) vs baseline: +5.5% Memory: ✅ 34.623MB (SLO: <35.500MB -2.5%) vs baseline: +5.0% ✅ 1-count-metrics-100-timesTime: ✅ 202.167µs (SLO: <220.000µs -8.1%) vs baseline: +1.2% Memory: ✅ 34.662MB (SLO: <35.500MB -2.4%) vs baseline: +4.9% ✅ 1-distribution-metric-1-timesTime: ✅ 3.316µs (SLO: <20.000µs 📉 -83.4%) vs baseline: -2.4% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +5.0% ✅ 1-distribution-metrics-100-timesTime: ✅ 216.610µs (SLO: <230.000µs -5.8%) vs baseline: +0.4% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +4.2% ✅ 1-gauge-metric-1-timesTime: ✅ 2.225µs (SLO: <20.000µs 📉 -88.9%) vs baseline: -0.4% Memory: ✅ 34.623MB (SLO: <35.500MB -2.5%) vs baseline: +5.3% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.481µs (SLO: <150.000µs -9.0%) vs baseline: -1.1% Memory: ✅ 34.642MB (SLO: <35.500MB -2.4%) vs baseline: +5.2% ✅ 1-rate-metric-1-timesTime: ✅ 3.496µs (SLO: <20.000µs 📉 -82.5%) vs baseline: 📈 +10.7% Memory: ✅ 34.583MB (SLO: <35.500MB -2.6%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 215.197µs (SLO: <250.000µs 📉 -13.9%) vs baseline: +0.9% Memory: ✅ 34.642MB (SLO: <35.500MB -2.4%) vs baseline: +5.0% ✅ 100-count-metrics-100-timesTime: ✅ 20.339ms (SLO: <22.000ms -7.5%) vs baseline: +0.6% Memory: ✅ 34.662MB (SLO: <35.500MB -2.4%) vs baseline: +5.2% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.262ms (SLO: <2.300ms 🟡 -1.6%) vs baseline: -2.3% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.6% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.407ms (SLO: <1.550ms -9.2%) vs baseline: -0.8% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +5.0% ✅ 100-rate-metrics-100-timesTime: ✅ 2.213ms (SLO: <2.550ms 📉 -13.2%) vs baseline: +1.1% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.426µs (SLO: <20.000µs 📉 -77.9%) vs baseline: -3.8% Memory: ✅ 34.662MB (SLO: <35.500MB -2.4%) vs baseline: +4.8% ✅ flush-100-metricsTime: ✅ 173.940µs (SLO: <250.000µs 📉 -30.4%) vs baseline: -0.8% Memory: ✅ 34.623MB (SLO: <35.500MB -2.5%) vs baseline: +5.0% ✅ flush-1000-metricsTime: ✅ 2.130ms (SLO: <2.500ms 📉 -14.8%) vs baseline: +0.3% Memory: ✅ 35.468MB (SLO: <36.500MB -2.8%) vs baseline: +5.0% 🟡 Near SLO Breach (2 suites)🟡 otelspan - 22/22✅ add-eventTime: ✅ 38.335ms (SLO: <47.150ms 📉 -18.7%) vs baseline: -0.4% Memory: ✅ 39.014MB (SLO: <47.000MB 📉 -17.0%) vs baseline: +4.7% ✅ add-metricsTime: ✅ 259.767ms (SLO: <344.800ms 📉 -24.7%) vs baseline: +0.9% Memory: ✅ 43.313MB (SLO: <47.500MB -8.8%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 314.852ms (SLO: <321.000ms 🟡 -1.9%) vs baseline: +0.2% Memory: ✅ 43.411MB (SLO: <47.500MB -8.6%) vs baseline: +5.0% ✅ get-contextTime: ✅ 80.969ms (SLO: <92.350ms 📉 -12.3%) vs baseline: +2.9% Memory: ✅ 39.244MB (SLO: <46.500MB 📉 -15.6%) vs baseline: +4.8% ✅ is-recordingTime: ✅ 36.008ms (SLO: <44.500ms 📉 -19.1%) vs baseline: +0.3% Memory: ✅ 38.919MB (SLO: <47.500MB 📉 -18.1%) vs baseline: +5.2% ✅ record-exceptionTime: ✅ 57.044ms (SLO: <67.650ms 📉 -15.7%) vs baseline: +1.2% Memory: ✅ 39.468MB (SLO: <47.000MB 📉 -16.0%) vs baseline: +4.6% ✅ set-statusTime: ✅ 42.525ms (SLO: <50.400ms 📉 -15.6%) vs baseline: -0.3% Memory: ✅ 38.920MB (SLO: <47.000MB 📉 -17.2%) vs baseline: +5.0% ✅ startTime: ✅ 36.343ms (SLO: <43.450ms 📉 -16.4%) vs baseline: +2.3% Memory: ✅ 38.770MB (SLO: <47.000MB 📉 -17.5%) vs baseline: +4.4% ✅ start-finishTime: ✅ 82.045ms (SLO: <88.000ms -6.8%) vs baseline: +0.2% Memory: ✅ 36.648MB (SLO: <46.500MB 📉 -21.2%) vs baseline: +4.5% ✅ start-finish-telemetryTime: ✅ 83.594ms (SLO: <89.000ms -6.1%) vs baseline: +0.1% Memory: ✅ 36.628MB (SLO: <46.500MB 📉 -21.2%) vs baseline: +4.9% ✅ update-nameTime: ✅ 36.993ms (SLO: <45.150ms 📉 -18.1%) vs baseline: +0.4% Memory: ✅ 38.939MB (SLO: <47.000MB 📉 -17.2%) vs baseline: +4.8% 🟡 packagespackageforrootmodulemapping - 4/4✅ cache_offTime: ✅ 341.056ms (SLO: <354.300ms -3.7%) vs baseline: -0.6% Memory: ✅ 40.836MB (SLO: <41.500MB 🟡 -1.6%) vs baseline: +3.9% ✅ cache_onTime: ✅ 0.381µs (SLO: <10.000µs 📉 -96.2%) vs baseline: ~same Memory: ✅ 39.784MB (SLO: <41.000MB -3.0%) vs baseline: +4.9%
|
Backport 8fd5887 from #15332 to 4.0.
Description
Add missing method in BlockConfig protocol use in our internal AAP API.
Add missing method in BlockConfig class.
Additional Notes
This should only impact lambda integration.