[SYNTH-18711] Update comment about sed syntax support #28482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview links (active after the
|
AntoineDona
force-pushed
the
antoine.donascimento/SYNTH-18711/remove-sed-syntax-from-doc
branch
from
636aba0 to
d18f7fc
Compare
teodor2312
approved these changes
Apr 1, 2025
| <div class="alert alert-info"> | ||
| Apart from the pipe <code>|</code> syntax presented above, <code>resourceUrlSubstitutionRegexes</code> also supports the sed syntax with modifiers: <code>s|<regex>|<rewriting rule>|<modifiers></code>.</br></br> The sed syntax is often used with a slash <code>/</code> separator, for example: <code>s/<regex>/<rewriting rule>/<modifier></code>. However, it can use any character as a delimiter. When working on a URL containing an abundant number of slashes, Datadog recommends using another character rather than escaping all slashes of the URL. | ||
| Only the pipe <code>|</code> syntax is supported for URL substitution regexes. Sed syntax and other delimiter characters are not supported. | ||
| </div> | ||
|
|
||
| ## Further reading |
There was a problem hiding this comment.
Not you but the what's next thing is broken and we should tell someone :D
There was a problem hiding this comment.
@teodor2312 Can you tell me more about what's broken?
Drarig29
reviewed
Apr 1, 2025
Drarig29
reviewed
Apr 1, 2025
Drarig29
requested changes
Apr 1, 2025
urseberry
approved these changes
Apr 1, 2025
Drarig29
reviewed
Apr 1, 2025
Drarig29
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
LGTM, let's see what @urseberry thinks about the wording added in 86652ed
urseberry
reviewed
Apr 2, 2025
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-mergequeue
bot
deleted the
antoine.donascimento/SYNTH-18711/remove-sed-syntax-from-doc
branch
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
This PR fixes incorrect documentation about URL substitution syntax in Continuous Testing. The documentation previously claimed support for sed syntax and different delimiters, which was incorrect. The changes remove this misleading information.
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes