Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated some of the wording and removed explicit callouts to RC Preview #28516

Merged

Conversation

sarjyusuf
Copy link
Contributor

No need to explicitly call out Remote Configuration.

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

No need to explicitly call out Remote Configuration.
@sarjyusuf sarjyusuf requested review from a team as code owners April 2, 2025 12:10
@sarjyusuf sarjyusuf requested a review from dmehala April 2, 2025 12:10
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some feedback mainly to comply with our style guide

@rtrieu rtrieu self-assigned this Apr 2, 2025
sarjyusuf and others added 3 commits April 3, 2025 16:53
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
@rtrieu
Copy link
Contributor

rtrieu commented Apr 3, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Apr 3, 2025

View all feedbacks in Devflow UI.

2025-04-03 14:56:28 UTC ℹ️ Start processing command /merge


2025-04-03 14:56:45 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-04-03 15:26:24 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 21m (p90).


2025-04-03 15:41:38 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit cebd2ac into master Apr 3, 2025
19 of 22 checks passed
@dd-mergequeue dd-mergequeue bot deleted the syed.sarjeelyusuf/Updated-wording-removed-RC-callout branch April 3, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants