adding new sdk methods #28752
Draft
adding new sdk methods #28752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview links (active after the
|
Taiki-San
reviewed
Apr 16, 2025
content/en/security/application_security/threats/add-user-info.md
Outdated
Show resolved
Hide resolved
|
|
||
| Starting in dd-trace-js v3.13.1, you can use the Node.js tracer API to track user events. In dd-trace-js v5.48.0, new methods were introduced under the `eventTrackingV2` namespace, while the existing ones were retained for compatibility. | ||
|
|
||
| Note that the legacy methods `trackUserLoginSuccessEvent` and `trackUserLoginFailureEvent` are now deprecated in favor of the new methods `eventTrackingV2.trackUserLoginSuccess` and `eventTrackingV2.trackUserLoginFailure`, respectively. |
There was a problem hiding this comment.
I'd suggest t moving this in the migration section. New users don't necessarily care about details about the legacy SDK
Co-authored-by: Taiki <[email protected]>
Taiki-San
reviewed
Apr 16, 2025
| const user = { | ||
| id: 'user-id', | ||
| email: '[email protected]' | ||
| } // same as before, but now the object is optional |
There was a problem hiding this comment.
Suggested change
| } // same as before, but now the object is optional | |
| } // same as before, but now the object is optional. Providing a user id will nonetheless help with post-compromised activity correlation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes