-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Uncaught error health event for DBMAsyncJob #21703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Uncaught error health event for DBMAsyncJob #21703
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
| line=exc.lineno, | ||
| function=exc.name, | ||
| exception_type=type(exception).__name__, | ||
| **kwargs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need a rebase + fix
What does this PR do?
Submits a health event for all uncaught exceptions during the execution of
DBMAsyncJob. These errors are not for presentation to users but will allow us to capture and fix unknown problems proactively.Motivation
Other teams have added similar functionality and discovered a large number of bugs to fix. The submitted fields are intentionally small to avoid leaking any sensitive information.
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged