Skip to content

Conversation

@sethsamuel
Copy link
Contributor

@sethsamuel sethsamuel commented Oct 20, 2025

What does this PR do?

Submits a health event for all uncaught exceptions during the execution of DBMAsyncJob. These errors are not for presentation to users but will allow us to capture and fix unknown problems proactively.

Motivation

Other teams have added similar functionality and discovered a large number of bugs to fix. The submitted fields are intentionally small to avoid leaking any sensitive information.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@datadog-official
Copy link
Contributor

datadog-official bot commented Oct 20, 2025

⚠️ Tests

⚠️ Warnings

🧪 1 Test failed

test_proxy_env_vars_skip from test_proxy.py (Datadog)
HTTPConnectionPool(host='www.google.com', port=80): Read timed out. (read timeout=10.0)

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 677915b | Docs | Was this helpful? Give us feedback!

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.12%. Comparing base (daccf8e) to head (677915b).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sethsamuel sethsamuel changed the title Unknown error event Uncaught error health event for DBMAsyncJob Oct 21, 2025
line=exc.lineno,
function=exc.name,
exception_type=type(exception).__name__,
**kwargs,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need a rebase + fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants