[ECOINT-154] Add Dagster+ integration #2655
Conversation
![dd-pub-platform[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
dagster/README.md
Outdated
| For any issues, visit [our support page.][1] | ||
|
|
||
|
|
||
| [1]: https://dagster.io/support |
There was a problem hiding this comment.
| [1]: https://dagster.io/support | |
| [1]: https://docs.dagster.io/guides/monitor/logging | |
| [2]: https://app.datadoghq.com/organization-settings/api-keys | |
| [3]: https://dagster.io/support | |
dagster/README.md
Outdated
|
|
||
| ### Validation | ||
|
|
||
| Within the next ten minutes, the Dagster Overview Dashboard will begin showing new log events if there are any active Dagster jobs emitting events. |
There was a problem hiding this comment.
| Within the next ten minutes, the Dagster Overview Dashboard will begin showing new log events if there are any active Dagster jobs emitting events. | |
| Within 10 minutes of completing the integration setup, the Dagster Overview Dashboard starts showing new log events, provided there are any active Dagster jobs emitting events. |
dd-dominic
changed the title
|
@estherk15 ready for another review, thanks! |
dagster/README.md
Outdated
|
|
||
| ## Setup | ||
|
|
||
| 1. Click **Connect Accounts** to launch the OAuth flow and link your Dagster and Datadog accounts. |
There was a problem hiding this comment.
Didn't catch this earlier, but where do you click from? Datadog integration tile or Dagster? If you have it, add a link here.
temporal-github-worker-1
bot
added
docs/approved
and removed
docs/review-requested
labels
dd-dominic
requested review from
a team and
james-eichelbaum
and removed request for
a team
temporal-github-worker-1
bot
dismissed
estherk15’s stale review
Review from estherk15 is dismissed. Related teams and files:
- documentation
- dagster/README.md
temporal-github-worker-1
bot
added
docs/review-requested
and removed
docs/approved
labels
|
This pull request has not been updated for more than 21 days. If there are no updates to this PR within 7 days, it will be closed. If you'd like to re-open this PR after it's been closed, you can start from the latest master branch or pull the latest changes into your branch and create a new pull request. |
temporal-github-worker-1
bot
added
docs/approved
and removed
docs/review-requested
labels
| @@ -0,0 +1,60 @@ | |||
| id: dagster-plus | |||
| # See app_id in your integration's manifest.json file to learn more: | |||
There was a problem hiding this comment.
Please remove all these comments, they are just here to help you create the integration
| - | ||
| sample: |- | ||
| { | ||
| "id" : "AQAAAZZFaQ9F2IkRTQAAAAAxNzY4OTkyNDIw", |
There was a problem hiding this comment.
The sample should be the RAW message you are sending to Datadog. Here you have provided the result we see in Datadog after we have processed your log. Nothing is getting tested. Can you replace with the proper original raw message?
temporal-github-worker-1
bot
dismissed
estherk15’s stale review
Review from estherk15 is dismissed. Related teams and files:
- documentation
- dagster/README.md
- dagster/assets/dashboards/dagster__overview.json
- dagster/manifest.json
temporal-github-worker-1
bot
added
docs/review-requested
and removed
docs/approved
labels
| "run_id" : "a3bcb088-1640-40dc-9701-4b554c0b9cac", | ||
| "event_type" : "STEP_WORKER_STARTED", | ||
| "job_name" : "diamond_asset_job", | ||
| "service" : "dagster-plus", |
There was a problem hiding this comment.
can you add a service remapper? So it sets this as a core attribute
| sourceType: attribute | ||
| target: dagster-plus.event_type | ||
| targetType: attribute | ||
| preserveSource: true |
There was a problem hiding this comment.
preserveSource should not be true. It will duplicate the property into two paths when it is not needed
| metric_id: dagster-plus | ||
| backend_only: false | ||
| facets: | ||
| - description: "" |
There was a problem hiding this comment.
nit: you can remove the empty description here
Integration Dagster+ has been created in publishing platform