-
Notifications
You must be signed in to change notification settings - Fork 784
Add new Warpstream integration #2661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
493d456
to
206fc94
Compare
206fc94
to
4ae0865
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's something broken in our linter job, it should've flagged all the extra empty lines at the top of a lot of python files.
And for python, we moved to python 3.12 a while ago, the scaffolding must be using an older template.
@epot can you confirm what ddev version you're using? |
Just flagging for the team that I'm the docs reviewer for this integration. Thank you! |
|
@NouemanKHAL for some reason github didn't let me commit your suggestions, but I updated the PR with your changes unless I have done something stupid. |
@epot we're working on unblocking you with the validations. When you get a chance, could you update your fork with the latest |
@iliakur done. But the CI is very sad and I am not sure if it's my fault or not :D |
warpstream/pyproject.toml
Outdated
[project] | ||
name = "datadog-warpstream" | ||
description = "The WarpStream check" | ||
readme = "README.md" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@epot you can comment this line out to get the tests to run/pass.
I'm working in parallel on the validation. Your PR is off the beaten path in some regards, our checks need some adjustments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR updated ✅
What does this PR do?
Add a new integration for Warpstream agents.
Motivation
Monitor the health and performance of your WarpStream Agents
Review checklist
no-changelog
label attachedAdditional Notes
Note that an official integration submission has been submitted as well. Please also note that we need to release a new agent version that updates the metrics naming convention to be compliant with the Datadog requirement. I am waiting for a first round of review to actually make the change.