Skip to content

Add new Warpstream integration #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

epot
Copy link

@epot epot commented Apr 22, 2025

What does this PR do?

Add a new integration for Warpstream agents.

Motivation

Monitor the health and performance of your WarpStream Agents

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

Note that an official integration submission has been submitted as well. Please also note that we need to release a new agent version that updates the metrics naming convention to be compliant with the Datadog requirement. I am waiting for a first round of review to actually make the change.

@epot epot requested a review from a team as a code owner April 22, 2025 06:54
@airlock-warpstreamlabs airlock-warpstreamlabs bot force-pushed the epot/tier branch 4 times, most recently from 493d456 to 206fc94 Compare April 22, 2025 08:17
@airlock-warpstreamlabs airlock-warpstreamlabs bot requested a review from a team as a code owner April 22, 2025 08:26
@maycmlee maycmlee added the editorial review Waiting on a more in-depth review from a docs team editor label Apr 22, 2025
Copy link
Member

@NouemanKHAL NouemanKHAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's something broken in our linter job, it should've flagged all the extra empty lines at the top of a lot of python files.

And for python, we moved to python 3.12 a while ago, the scaffolding must be using an older template.

@dd-dominic
Copy link
Collaborator

@epot can you confirm what ddev version you're using?

@jhgilbert jhgilbert self-requested a review May 16, 2025 16:23
@jhgilbert
Copy link
Contributor

Just flagging for the team that I'm the docs reviewer for this integration. Thank you!

@epot
Copy link
Author

epot commented May 16, 2025

@epot can you confirm what ddev version you're using?

$ ddev --version
ddev, version 11.2.0

@epot
Copy link
Author

epot commented May 16, 2025

@NouemanKHAL for some reason github didn't let me commit your suggestions, but I updated the PR with your changes unless I have done something stupid.

@iliakur
Copy link
Contributor

iliakur commented May 22, 2025

@epot we're working on unblocking you with the validations. When you get a chance, could you update your fork with the latest master and push it here?

@epot
Copy link
Author

epot commented May 23, 2025

@iliakur done. But the CI is very sad and I am not sure if it's my fault or not :D
If you have time to show me how I can reproduce this error that would help: https://github.com/DataDog/integrations-extras/actions/runs/15204445512/job/42764383682?pr=2661

[project]
name = "datadog-warpstream"
description = "The WarpStream check"
readme = "README.md"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@epot you can comment this line out to get the tests to run/pass.

I'm working in parallel on the validation. Your PR is off the beaten path in some regards, our checks need some adjustments.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR updated ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants