Add busy_threads metric to Puma integration
#2697
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1sherman
force-pushed
the
add-busy-threads-to-puma-integration
branch
from
b1655c8 to
142b249
Compare
|
I created a documentation request here |
f1sherman
force-pushed
the
add-busy-threads-to-puma-integration
branch
from
142b249 to
382bb73
Compare
This new stat was [added about 6 months ago](puma/puma#3517) to track "the overall current state of work to be done and the capacity to do it". It seems like it could be useful to track, potentially for autoscaling or other applications.
f1sherman
force-pushed
the
add-busy-threads-to-puma-integration
branch
from
cbb53b2 to
9c2adbb
Compare
Co-authored-by: May Lee <[email protected]>
maycmlee
approved these changes
May 21, 2025
|
Getting an eng review on this. |
steveny91
reviewed
May 23, 2025
|
@f1sherman Hello 👋 ! Looks good to me. Left a small correction for the metadata.csv. Thanks for the contribution! |
Co-authored-by: Steven Yuen <[email protected]>
|
@steveny91 thanks for the suggestion, I've made that change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new stat was added about 6 months ago to track "the overall current state of work to be done and the capacity to do it". It seems like it could be useful to track, potentially for autoscaling or other applications.
What does this PR do?
This adds the new(ish)
busy_threadsstat as a metric.Motivation
I want to track it and experiment with using it for autoscaling
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?