Skip to content

chore: rename serializers deserializers #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Apr 8, 2025

What does this PR do?

Addresses one more comment from @duncanista in #998 but I had clicked automerge so it went anyway

Motivation

Just a rename.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@astuyve astuyve requested review from a team as code owners April 8, 2025 01:56
@pr-commenter
Copy link

pr-commenter bot commented Apr 8, 2025

Benchmarks

Comparison

Benchmark execution time: 2025-04-08 02:08:40

Comparing candidate commit 669373f in PR branch aj/trace-pbuff-rename-deserializers with baseline commit a0b92b6 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 669373f 1744077407 aj/trace-pbuff-rename-deserializers
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 67.510µs 67.762µs ± 0.199µs 67.731µs ± 0.051µs 67.789µs 67.931µs 68.289µs 69.959µs 3.29% 7.198 73.387 0.29% 0.014µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [67.735µs; 67.790µs] or [-0.041%; +0.041%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 669373f 1744077407 aj/trace-pbuff-rename-deserializers
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 5.979ms 5.992ms ± 0.011ms 5.991ms ± 0.003ms 5.994ms 6.001ms 6.029ms 6.109ms 1.97% 7.340 73.867 0.18% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [5.991ms; 5.994ms] or [-0.024%; +0.024%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 669373f 1744077407 aj/trace-pbuff-rename-deserializers
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 54.316ms 54.895ms ± 0.281ms 54.983ms ± 0.068ms 55.037ms 55.265ms 55.510ms 55.872ms 1.62% -0.277 0.114 0.51% 0.020ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [54.856ms; 54.934ms] or [-0.071%; +0.071%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 669373f 1744077407 aj/trace-pbuff-rename-deserializers
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.736µs 209.102µs ± 0.145µs 209.094µs ± 0.084µs 209.167µs 209.360µs 209.547µs 209.666µs 0.27% 0.776 1.825 0.07% 0.010µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4769479.781op/s 4782362.462op/s ± 3321.096op/s 4782538.950op/s ± 1919.674op/s 4784553.865op/s 4786971.428op/s 4789901.407op/s 4790751.295op/s 0.17% -0.770 1.811 0.07% 234.837op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.629µs 18.677µs ± 0.029µs 18.672µs ± 0.015µs 18.693µs 18.730µs 18.758µs 18.807µs 0.72% 1.093 1.974 0.15% 0.002µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 53171667.432op/s 53541877.566op/s ± 82384.571op/s 53555336.846op/s ± 42112.480op/s 53592874.238op/s 53656350.655op/s 53677843.434op/s 53679087.310op/s 0.23% -1.080 1.924 0.15% 5825.469op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.925µs 10.995µs ± 0.115µs 10.987µs ± 0.018µs 11.004µs 11.034µs 11.061µs 12.568µs 14.39% 12.801 172.330 1.05% 0.008µs 1 200
normalization/normalize_name/normalize_name/good throughput 79569054.004op/s 90961817.767op/s ± 842195.931op/s 91020734.528op/s ± 147292.734op/s 91167212.085op/s 91433442.549op/s 91506423.095op/s 91529958.459op/s 0.56% -12.456 166.136 0.92% 59552.245op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [209.082µs; 209.122µs] or [-0.010%; +0.010%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4781902.190op/s; 4782822.734op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.673µs; 18.681µs] or [-0.021%; +0.021%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53530459.856op/s; 53553295.275op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.979µs; 11.011µs] or [-0.145%; +0.145%] None None None
normalization/normalize_name/normalize_name/good throughput [90845097.510op/s; 91078538.023op/s] or [-0.128%; +0.128%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 669373f 1744077407 aj/trace-pbuff-rename-deserializers
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.229µs 3.204µs ± 1.437µs 2.999µs ± 0.024µs 3.018µs 3.704µs 13.892µs 14.917µs 397.36% 7.269 54.222 44.73% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.005µs; 3.403µs] or [-6.215%; +6.215%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 669373f 1744077407 aj/trace-pbuff-rename-deserializers
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.304µs 2.368µs ± 0.018µs 2.368µs ± 0.007µs 2.375µs 2.401µs 2.407µs 2.407µs 1.67% -0.856 2.803 0.76% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.365µs; 2.370µs] or [-0.105%; +0.105%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 669373f 1744077407 aj/trace-pbuff-rename-deserializers
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.894µs 3.913µs ± 0.003µs 3.913µs ± 0.002µs 3.915µs 3.917µs 3.918µs 3.921µs 0.21% -1.464 6.665 0.08% 0.000µs 1 200
credit_card/is_card_number/ throughput 255009220.140op/s 255570925.636op/s ± 200062.581op/s 255544201.959op/s ± 101506.203op/s 255650299.251op/s 255913759.257op/s 256025587.494op/s 256823016.889op/s 0.50% 1.479 6.769 0.08% 14146.561op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 81.928µs 82.313µs ± 0.217µs 82.258µs ± 0.118µs 82.415µs 82.726µs 82.992µs 83.212µs 1.16% 1.242 1.961 0.26% 0.015µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12017505.763op/s 12148833.302op/s ± 31974.455op/s 12156941.332op/s ± 17436.474op/s 12170288.994op/s 12189272.101op/s 12199005.442op/s 12205896.669op/s 0.40% -1.223 1.893 0.26% 2260.935op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 76.564µs 77.142µs ± 0.300µs 77.133µs ± 0.198µs 77.317µs 77.592µs 77.982µs 78.407µs 1.65% 0.759 1.272 0.39% 0.021µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12754038.370op/s 12963228.323op/s ± 50276.437op/s 12964651.888op/s ± 33285.157op/s 13000809.790op/s 13034758.882op/s 13056452.936op/s 13061000.095op/s 0.74% -0.728 1.170 0.39% 3555.081op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.893µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.915µs 3.917µs 3.921µs 3.923µs 0.25% -1.813 13.535 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254912958.594op/s 255546419.919op/s ± 186580.043op/s 255538657.945op/s ± 78789.177op/s 255611355.535op/s 255849717.057op/s 255959672.741op/s 256902908.792op/s 0.53% 1.840 13.731 0.07% 13193.201op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 72.897µs 73.656µs ± 0.424µs 73.585µs ± 0.256µs 73.908µs 74.415µs 74.929µs 75.201µs 2.20% 0.708 0.502 0.57% 0.030µs 1 200
credit_card/is_card_number/378282246310005 throughput 13297653.903op/s 13577138.491op/s ± 77758.947op/s 13589713.270op/s ± 47287.190op/s 13633221.776op/s 13688527.128op/s 13712211.485op/s 13717960.744op/s 0.94% -0.674 0.421 0.57% 5498.388op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.869µs 52.132µs ± 0.078µs 52.145µs ± 0.049µs 52.186µs 52.246µs 52.262µs 52.286µs 0.27% -0.770 0.808 0.15% 0.005µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19125445.190op/s 19182068.006op/s ± 28590.156op/s 19177227.044op/s ± 18009.354op/s 19200203.046op/s 19229678.509op/s 19275344.723op/s 19279189.270op/s 0.53% 0.780 0.833 0.15% 2021.629op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.470µs 6.626µs ± 0.066µs 6.627µs ± 0.041µs 6.673µs 6.737µs 6.771µs 6.808µs 2.72% 0.114 -0.065 0.99% 0.005µs 1 200
credit_card/is_card_number/x371413321323331 throughput 146889619.494op/s 150935439.192op/s ± 1504252.749op/s 150886888.707op/s ± 945852.823op/s 151797264.139op/s 153492723.930op/s 154386713.739op/s 154556529.126op/s 2.43% -0.057 -0.080 0.99% 106366.732op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.897µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.915µs 3.917µs 3.919µs 3.930µs 0.42% -0.282 9.124 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254427825.565op/s 255517055.145op/s ± 193177.343op/s 255508208.683op/s ± 90608.961op/s 255597610.164op/s 255806194.154op/s 256010960.830op/s 256603782.677op/s 0.43% 0.307 9.115 0.08% 13659.701op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 63.795µs 63.943µs ± 0.077µs 63.928µs ± 0.041µs 63.985µs 64.081µs 64.165µs 64.258µs 0.52% 0.944 1.250 0.12% 0.005µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15562371.059op/s 15638855.185op/s ± 18923.993op/s 15642694.553op/s ± 10063.078op/s 15651425.800op/s 15664456.800op/s 15673042.790op/s 15675178.355op/s 0.21% -0.935 1.224 0.12% 1338.128op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.403µs 57.558µs ± 0.071µs 57.537µs ± 0.029µs 57.584µs 57.680µs 57.850µs 57.878µs 0.59% 1.873 5.268 0.12% 0.005µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17277662.058op/s 17373767.449op/s ± 21448.630op/s 17380072.877op/s ± 8653.119op/s 17386247.478op/s 17394774.962op/s 17409537.380op/s 17420760.320op/s 0.23% -1.860 5.202 0.12% 1516.647op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.913µs ± 0.003µs 3.913µs ± 0.001µs 3.915µs 3.917µs 3.918µs 3.925µs 0.30% -1.033 6.070 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254784917.570op/s 255564901.722op/s ± 202282.966op/s 255539002.843op/s ± 92564.457op/s 255650459.064op/s 255918421.390op/s 256030617.127op/s 256759603.397op/s 0.48% 1.049 6.141 0.08% 14303.566op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.567µs 54.709µs ± 0.163µs 54.658µs ± 0.025µs 54.689µs 55.103µs 55.441µs 55.720µs 1.94% 3.236 11.726 0.30% 0.012µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17946755.800op/s 18278797.269op/s ± 53834.748op/s 18295647.466op/s ± 8243.983op/s 18301721.277op/s 18312970.078op/s 18321438.562op/s 18326019.282op/s 0.17% -3.208 11.462 0.29% 3806.692op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.899µs 52.135µs ± 0.078µs 52.139µs ± 0.060µs 52.198µs 52.247µs 52.271µs 52.312µs 0.33% -0.264 -0.566 0.15% 0.006µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19116190.796op/s 19180952.358op/s ± 28781.615op/s 19179677.225op/s ± 21915.490op/s 19201148.243op/s 19230797.837op/s 19243850.715op/s 19268315.814op/s 0.46% 0.270 -0.559 0.15% 2035.167op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.479µs 6.596µs ± 0.061µs 6.593µs ± 0.044µs 6.637µs 6.696µs 6.725µs 6.740µs 2.23% 0.251 -0.816 0.92% 0.004µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 148370800.470op/s 151625059.790op/s ± 1395630.629op/s 151676703.360op/s ± 998120.088op/s 152663982.878op/s 153615799.604op/s 154052848.307op/s 154333737.182op/s 1.75% -0.220 -0.837 0.92% 98685.988op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.912µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ throughput [255543198.886op/s; 255598652.385op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [82.283µs; 82.343µs] or [-0.037%; +0.037%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12144401.950op/s; 12153264.654op/s] or [-0.036%; +0.036%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [77.101µs; 77.184µs] or [-0.054%; +0.054%] None None None
credit_card/is_card_number/ 378282246310005 throughput [12956260.493op/s; 12970196.154op/s] or [-0.054%; +0.054%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255520561.719op/s; 255572278.118op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [73.597µs; 73.714µs] or [-0.080%; +0.080%] None None None
credit_card/is_card_number/378282246310005 throughput [13566361.849op/s; 13587915.134op/s] or [-0.079%; +0.079%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.121µs; 52.143µs] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19178105.685op/s; 19186030.327op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.617µs; 6.635µs] or [-0.138%; +0.138%] None None None
credit_card/is_card_number/x371413321323331 throughput [150726964.229op/s; 151143914.156op/s] or [-0.138%; +0.138%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.913µs; 3.914µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255490282.624op/s; 255543827.667op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [63.933µs; 63.954µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15636232.502op/s; 15641477.868op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [57.548µs; 57.568µs] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17370794.875op/s; 17376740.022op/s] or [-0.017%; +0.017%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.912µs; 3.913µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255536867.248op/s; 255592936.195op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.686µs; 54.731µs] or [-0.041%; +0.041%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18271336.291op/s; 18286258.248op/s] or [-0.041%; +0.041%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.124µs; 52.146µs] or [-0.021%; +0.021%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19176963.503op/s; 19184941.213op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.587µs; 6.604µs] or [-0.128%; +0.128%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [151431638.808op/s; 151818480.773op/s] or [-0.128%; +0.128%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 669373f 1744077407 aj/trace-pbuff-rename-deserializers
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 243.767ns 253.358ns ± 12.274ns 247.890ns ± 1.903ns 252.361ns 279.207ns 293.282ns 295.165ns 19.07% 1.951 2.783 4.83% 0.868ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [251.657ns; 255.059ns] or [-0.671%; +0.671%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 669373f 1744077407 aj/trace-pbuff-rename-deserializers
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.055µs 34.194µs ± 1.518µs 33.263µs ± 0.140µs 36.309µs 36.768µs 36.906µs 36.926µs 11.01% 0.908 -1.129 4.43% 0.107µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.984µs; 34.405µs] or [-0.615%; +0.615%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 669373f 1744077407 aj/trace-pbuff-rename-deserializers
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 147.574µs 148.126µs ± 0.363µs 148.047µs ± 0.177µs 148.283µs 148.629µs 149.351µs 150.670µs 1.77% 2.647 13.141 0.24% 0.026µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [148.076µs; 148.177µs] or [-0.034%; +0.034%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 669373f 1744077407 aj/trace-pbuff-rename-deserializers
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.572µs 25.804µs ± 11.375µs 17.827µs ± 0.137µs 35.161µs 43.914µs 55.693µs 95.576µs 436.12% 2.025 7.656 43.97% 0.804µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.227µs; 27.380µs] or [-6.109%; +6.109%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 669373f 1744077407 aj/trace-pbuff-rename-deserializers
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 504.165µs 505.498µs ± 0.603µs 505.499µs ± 0.238µs 505.727µs 506.102µs 506.402µs 510.855µs 1.06% 4.034 33.310 0.12% 0.043µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1957501.767op/s 1978248.285op/s ± 2350.385op/s 1978242.520op/s ± 930.417op/s 1979208.198op/s 1981347.234op/s 1982784.740op/s 1983476.539op/s 0.26% -3.967 32.602 0.12% 166.197op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 453.679µs 455.149µs ± 0.961µs 455.066µs ± 0.350µs 455.388µs 456.005µs 456.817µs 465.819µs 2.36% 7.287 75.827 0.21% 0.068µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2146757.301op/s 2197089.912op/s ± 4569.466op/s 2197483.315op/s ± 1690.350op/s 2199306.923op/s 2201001.722op/s 2203010.367op/s 2204199.348op/s 0.31% -7.132 73.499 0.21% 323.110op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 177.272µs 177.614µs ± 0.133µs 177.608µs ± 0.081µs 177.696µs 177.838µs 177.962µs 177.979µs 0.21% 0.120 0.247 0.07% 0.009µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5618634.242op/s 5630188.468op/s ± 4204.191op/s 5630367.732op/s ± 2567.000op/s 5632516.877op/s 5637667.340op/s 5639148.280op/s 5641043.351op/s 0.19% -0.115 0.244 0.07% 297.281op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.543µs 37.623µs ± 0.045µs 37.615µs ± 0.027µs 37.649µs 37.704µs 37.748µs 37.792µs 0.47% 0.809 0.769 0.12% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26460547.473op/s 26579513.011op/s ± 31464.702op/s 26584907.313op/s ± 19436.049op/s 26602271.135op/s 26623265.234op/s 26628830.987op/s 26635783.203op/s 0.19% -0.802 0.748 0.12% 2224.890op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.171µs 48.304µs ± 0.052µs 48.298µs ± 0.030µs 48.333µs 48.392µs 48.423µs 48.631µs 0.69% 1.304 6.616 0.11% 0.004µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20562847.188op/s 20702163.526op/s ± 22465.245op/s 20704579.184op/s ± 12650.909op/s 20714750.704op/s 20736266.351op/s 20743164.409op/s 20759382.946op/s 0.26% -1.281 6.469 0.11% 1588.533op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [505.415µs; 505.582µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1977922.545op/s; 1978574.026op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [455.016µs; 455.283µs] or [-0.029%; +0.029%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2196456.628op/s; 2197723.196op/s] or [-0.029%; +0.029%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [177.596µs; 177.632µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5629605.808op/s; 5630771.129op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.617µs; 37.629µs] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26575152.306op/s; 26583873.716op/s] or [-0.016%; +0.016%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.297µs; 48.311µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20699050.059op/s; 20705276.993op/s] or [-0.015%; +0.015%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 669373f 1744077407 aj/trace-pbuff-rename-deserializers
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.914µs 4.994µs ± 0.050µs 4.980µs ± 0.038µs 5.047µs 5.077µs 5.080µs 5.082µs 2.04% 0.358 -1.344 1.01% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [4.987µs; 5.001µs] or [-0.140%; +0.140%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.46%. Comparing base (a0b92b6) to head (669373f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1007      +/-   ##
==========================================
- Coverage   71.48%   71.46%   -0.02%     
==========================================
  Files         337      337              
  Lines       50509    50509              
==========================================
- Hits        36104    36098       -6     
- Misses      14405    14411       +6     
Components Coverage Δ
crashtracker 42.66% <ø> (ø)
crashtracker-ffi 6.30% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.74% <ø> (ø)
data-pipeline-ffi 90.35% <ø> (ø)
ddcommon 79.95% <ø> (ø)
ddcommon-ffi 66.37% <ø> (ø)
ddtelemetry 60.28% <ø> (ø)
ddtelemetry-ffi 21.43% <ø> (ø)
dogstatsd-client 82.57% <ø> (ø)
ipc 82.42% <ø> (-0.11%) ⬇️
profiling 77.45% <ø> (-0.13%) ⬇️
profiling-ffi 62.28% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.95% <ø> (ø)
sidecar-ffi 0.58% <ø> (ø)
spawn-worker 54.37% <ø> (ø)
tinybytes 91.59% <ø> (ø)
trace-mini-agent 73.82% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 96.00% <ø> (ø)
trace-protobuf 78.50% <ø> (ø)
trace-utils 93.05% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@r1viollet
Copy link
Contributor

r1viollet commented Apr 8, 2025

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 23.99 MB 23.99 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 77.63 MB 77.63 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 7.78 MB 7.78 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 22.56 MB 22.56 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 71.86 MB 71.86 MB 0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 7.71 MB 7.71 MB 0% (0 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 16.85 MB 16.85 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 61.83 KB 61.83 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 113.05 MB 113.05 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 630.61 MB 630.61 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 5.04 MB 5.04 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 61.83 KB 61.83 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 16.06 MB 16.06 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 26.71 MB 26.71 MB 0% (0 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 14.25 MB 14.25 MB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 62.78 KB 62.78 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 115.03 MB 115.02 MB -0% (-8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 622.55 MB 622.55 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 3.81 MB 3.81 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 62.78 KB 62.78 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 16.68 MB 16.68 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 24.61 MB 24.61 MB 0% (0 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 66.92 MB 66.92 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 8.25 MB 8.25 MB 0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so.debug 23.15 MB 23.15 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 67.84 MB 67.84 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 8.13 MB 8.13 MB 0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so.debug 20.77 MB 20.77 MB 0% (0 B) 👌

@astuyve astuyve merged commit b14e541 into main Apr 8, 2025
35 checks passed
@astuyve astuyve deleted the aj/trace-pbuff-rename-deserializers branch April 8, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants