feat(profiling): add ProfilesDictionary #1349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksComparisonBenchmark execution time: 2025-12-03 21:47:17 Comparing candidate commit eae2db2 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
BaselineOmitted due to size. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1349 +/- ##
==========================================
+ Coverage 71.17% 71.19% +0.02%
==========================================
Files 395 399 +4
Lines 63389 63559 +170
==========================================
+ Hits 45114 45248 +134
- Misses 18275 18311 +36
🚀 New features to boost your workflow:
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
KowalskiThomas
left a comment
KowalskiThomas
left a comment
There was a problem hiding this comment.
What I see makes sense to me but I'll let someone better versed in Rust make review!
danielsn
reviewed
Nov 18, 2025
| } | ||
| } | ||
|
|
||
| impl From<Function2> for Function { |
Contributor
There was a problem hiding this comment.
Not for this PR, but it feels like someone OUGHT to have a crate to do this
| /// `FunctionId2` converts to a `None`. | ||
| /// | ||
| /// # Safety | ||
| /// The pointer object must still be alive. In general this means the |
Contributor
Author
There was a problem hiding this comment.
I don't think so. If the profiles dictionary is alive, this should be safe.
danielsn
reviewed
Nov 21, 2025
Comment on lines
+55
to
+57
| /// performed on; it is not generally guaranteed that ids from one dictionary | ||
| /// can be used in another dictionary, even if it happens to work by | ||
| /// implementation detail. |
Contributor
There was a problem hiding this comment.
Is there any way to detect this error?
Contributor
Author
There was a problem hiding this comment.
Probably. Doing it with desirable CPU and memory characteristics? Probably not.
danielsn
approved these changes
Dec 3, 2025
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds the ProfilesDictionary data structure, which holds deduplicated functions, mappings, and strings and gives back IDs to the inserted elements.
Motivation
This is another stepping stone for my new profiling API with long-lived functions, mappings, and strings.
Additional Notes
This is stacked on top of PR #1347.
How to test the change?
Regular testing applies, just additions here (that are currently unused).