-
Notifications
You must be signed in to change notification settings - Fork 15
profiler: use reqwest based exporter #1383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
9837dcd to
a529caa
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1383 +/- ##
==========================================
+ Coverage 70.96% 71.11% +0.14%
==========================================
Files 400 401 +1
Lines 63691 63875 +184
==========================================
+ Hits 45199 45425 +226
+ Misses 18492 18450 -42
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2025-12-05 18:22:22 Comparing candidate commit 0e5a4d8 in PR branch Found 4 performance improvements and 12 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. scenario:credit_card/is_card_number/ 378282246310005
scenario:credit_card/is_card_number/378282246310005
scenario:credit_card/is_card_number/37828224631000521389798
scenario:credit_card/is_card_number/x371413321323331
scenario:credit_card/is_card_number_no_luhn/ 378282246310005
scenario:credit_card/is_card_number_no_luhn/378282246310005
scenario:credit_card/is_card_number_no_luhn/37828224631000521389798
scenario:credit_card/is_card_number_no_luhn/x371413321323331
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
BaselineOmitted due to size. |
a529caa to
0c12dc1
Compare
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
0c12dc1 to
8fc6fa9
Compare
8fc6fa9 to
0e5a4d8
Compare
What does this PR do?
Uses reqwest to send profiles instead of hyper.
Motivation
The hyper code has to handle a lot of lower level issues and is therefore more complex.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.