Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PROF-11524] Minor tweak: Set profile start_time after resetting #987

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[PROF-11524] Minor tweak: Set profile start_time after resetting #987

wants to merge 1 commit into from

Conversation

ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Mar 31, 2025

What does this PR do?

This PR applies a suggestion from #963 (comment) to set the start_time after obtaining the old profile.

This will hopefully make it more clear that the start_time is used for the old profile, not the new one.

Motivation

Make code more readable.

Additional Notes

N/A

How to test the change?

Existing test coverage should be enough to validate this change (for instance, the Ruby profiler test suite explicitly tests the timestamps on profiles).

@ivoanjo
[PROF-11524] Minor tweak: Set profile start_time after resetting
80413e7 
**What does this PR do?**

This PR applies a suggestion from
#963 (comment)
to set the `start_time` after obtaining the old profile.

This will hopefully make it more clear that the `start_time` is used
for the old profile, not the new one.

**Motivation:**

Make code more readable.

**Additional Notes:**

N/A

**How to test the change?**

Existing test coverage should be enough to validate this change
(for instance, the Ruby profiler test suite explicitly tests the
timestamps on profiles).
@ivoanjo ivoanjo requested a review from a team as a code owner March 31, 2025 12:23
@github-actions github-actions bot added the profiling Relates to the profiling* modules. label Mar 31, 2025
@ivoanjo ivoanjo mentioned this pull request Mar 31, 2025
Merged
@pr-commenter
Copy link

pr-commenter bot commented Mar 31, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-03-31 12:34:43

Comparing candidate commit 80413e7 in PR branch ivoanjo/prof-11524-small-tweak with baseline commit 4c2a5a2 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 80413e7 1743423650 ivoanjo/prof-11524-small-tweak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 6.010ms 6.022ms ± 0.008ms 6.021ms ± 0.004ms 6.025ms 6.032ms 6.041ms 6.089ms 1.13% 4.160 29.827 0.13% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [6.021ms; 6.023ms] or [-0.018%; +0.018%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 80413e7 1743423650 ivoanjo/prof-11524-small-tweak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.189µs 3.169µs ± 1.432µs 2.974µs ± 0.024µs 2.996µs 3.613µs 13.902µs 14.884µs 400.45% 7.400 55.662 45.07% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.970µs; 3.367µs] or [-6.262%; +6.262%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 80413e7 1743423650 ivoanjo/prof-11524-small-tweak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 67.621µs 67.803µs ± 0.194µs 67.779µs ± 0.038µs 67.820µs 67.909µs 68.119µs 70.189µs 3.55% 9.856 114.978 0.29% 0.014µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [67.776µs; 67.830µs] or [-0.040%; +0.040%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 80413e7 1743423650 ivoanjo/prof-11524-small-tweak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 32.953µs 33.603µs ± 1.001µs 33.174µs ± 0.089µs 33.264µs 35.722µs 35.892µs 37.078µs 11.77% 1.717 1.170 2.97% 0.071µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.464µs; 33.741µs] or [-0.413%; +0.413%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 80413e7 1743423650 ivoanjo/prof-11524-small-tweak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.576µs 25.745µs ± 11.576µs 17.942µs ± 0.296µs 35.326µs 45.380µs 50.172µs 107.545µs 499.41% 2.431 11.889 44.85% 0.819µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.141µs; 27.350µs] or [-6.232%; +6.232%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 80413e7 1743423650 ivoanjo/prof-11524-small-tweak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 55.850ms 56.285ms ± 0.202ms 56.301ms ± 0.121ms 56.387ms 56.624ms 56.785ms 57.242ms 1.67% 0.701 2.027 0.36% 0.014ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [56.257ms; 56.313ms] or [-0.050%; +0.050%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 80413e7 1743423650 ivoanjo/prof-11524-small-tweak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 208.950µs 209.205µs ± 0.132µs 209.198µs ± 0.089µs 209.288µs 209.446µs 209.512µs 209.592µs 0.19% 0.376 -0.272 0.06% 0.009µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4771173.840op/s 4779997.065op/s ± 3017.404op/s 4780160.105op/s ± 2028.244op/s 4782120.766op/s 4784775.133op/s 4785603.475op/s 4785842.839op/s 0.12% -0.373 -0.275 0.06% 213.363op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.607µs 18.688µs ± 0.043µs 18.683µs ± 0.019µs 18.705µs 18.732µs 18.777µs 19.154µs 2.52% 6.308 65.122 0.23% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 52207930.916op/s 53510032.980op/s ± 122340.797op/s 53525492.885op/s ± 53061.672op/s 53563723.926op/s 53639094.364op/s 53657365.391op/s 53744242.990op/s 0.41% -6.120 62.471 0.23% 8650.801op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.939µs 10.994µs ± 0.025µs 10.989µs ± 0.014µs 11.010µs 11.041µs 11.063µs 11.068µs 0.72% 0.658 0.488 0.22% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 90348927.558op/s 90957007.339op/s ± 203636.302op/s 91000282.101op/s ± 113452.486op/s 91089246.967op/s 91257487.237op/s 91342869.256op/s 91412627.459op/s 0.45% -0.644 0.468 0.22% 14399.261op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [209.187µs; 209.224µs] or [-0.009%; +0.009%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4779578.881op/s; 4780415.248op/s] or [-0.009%; +0.009%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.682µs; 18.694µs] or [-0.032%; +0.032%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53493077.722op/s; 53526988.238op/s] or [-0.032%; +0.032%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.991µs; 10.998µs] or [-0.031%; +0.031%] None None None
normalization/normalize_name/normalize_name/good throughput [90928785.307op/s; 90985229.372op/s] or [-0.031%; +0.031%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 80413e7 1743423650 ivoanjo/prof-11524-small-tweak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 146.725µs 147.708µs ± 0.338µs 147.699µs ± 0.192µs 147.879µs 148.251µs 148.530µs 149.437µs 1.18% 0.892 3.862 0.23% 0.024µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [147.661µs; 147.755µs] or [-0.032%; +0.032%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 80413e7 1743423650 ivoanjo/prof-11524-small-tweak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.312µs 2.367µs ± 0.018µs 2.364µs ± 0.009µs 2.376µs 2.399µs 2.404µs 2.407µs 1.81% -0.371 1.258 0.74% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.364µs; 2.369µs] or [-0.103%; +0.103%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 80413e7 1743423650 ivoanjo/prof-11524-small-tweak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.893µs 3.914µs ± 0.002µs 3.914µs ± 0.001µs 3.915µs 3.918µs 3.919µs 3.922µs 0.19% -2.851 25.207 0.06% 0.000µs 1 200
credit_card/is_card_number/ throughput 255001650.275op/s 255478655.025op/s ± 162336.365op/s 255490572.399op/s ± 78434.174op/s 255547742.723op/s 255663311.332op/s 255876332.453op/s 256863534.386op/s 0.54% 2.887 25.564 0.06% 11478.914op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 81.972µs 82.282µs ± 0.202µs 82.239µs ± 0.110µs 82.364µs 82.650µs 82.807µs 83.540µs 1.58% 1.849 6.830 0.24% 0.014µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11970244.327op/s 12153349.024op/s ± 29702.209op/s 12159614.273op/s ± 16252.127op/s 12173282.385op/s 12186867.450op/s 12195490.474op/s 12199333.916op/s 0.33% -1.810 6.530 0.24% 2100.263op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 76.120µs 76.916µs ± 0.314µs 76.894µs ± 0.213µs 77.116µs 77.436µs 77.723µs 77.982µs 1.41% 0.433 0.221 0.41% 0.022µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 12823446.785op/s 13001444.611op/s ± 53006.537op/s 13004867.723op/s ± 35941.923op/s 13038475.238op/s 13081476.837op/s 13097693.760op/s 13137195.676op/s 1.02% -0.408 0.185 0.41% 3748.128op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.899µs 3.914µs ± 0.003µs 3.914µs ± 0.001µs 3.916µs 3.918µs 3.920µs 3.923µs 0.23% -0.738 5.857 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 254900779.248op/s 255481926.142op/s ± 166873.702op/s 255489805.963op/s ± 91008.692op/s 255569233.708op/s 255722061.546op/s 255892556.075op/s 256469892.191op/s 0.38% 0.752 5.926 0.07% 11799.753op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 72.871µs 73.820µs ± 0.439µs 73.809µs ± 0.305µs 74.101µs 74.535µs 74.992µs 75.393µs 2.15% 0.390 0.268 0.59% 0.031µs 1 200
credit_card/is_card_number/378282246310005 throughput 13263908.476op/s 13546925.555op/s ± 80339.531op/s 13548473.124op/s ± 55711.569op/s 13609948.251op/s 13674143.584op/s 13699603.492op/s 13722972.933op/s 1.29% -0.353 0.196 0.59% 5680.863op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 51.851µs 52.153µs ± 0.080µs 52.158µs ± 0.054µs 52.216µs 52.257µs 52.277µs 52.301µs 0.27% -0.818 0.767 0.15% 0.006µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19120118.059op/s 19174488.983op/s ± 29362.426op/s 19172696.164op/s ± 19970.457op/s 19189435.738op/s 19234591.009op/s 19255775.860op/s 19285893.584op/s 0.59% 0.828 0.793 0.15% 2076.237op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.439µs 6.596µs ± 0.063µs 6.595µs ± 0.041µs 6.636µs 6.701µs 6.740µs 6.752µs 2.38% 0.132 -0.385 0.95% 0.004µs 1 200
credit_card/is_card_number/x371413321323331 throughput 148097894.255op/s 151616814.997op/s ± 1436617.258op/s 151626030.842op/s ± 928306.279op/s 152538323.122op/s 153941682.857op/s 154662908.913op/s 155300847.748op/s 2.42% -0.087 -0.389 0.95% 101584.181op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.901µs 3.915µs ± 0.003µs 3.915µs ± 0.002µs 3.916µs 3.920µs 3.924µs 3.928µs 0.34% 0.337 2.478 0.09% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 254602290.006op/s 255459541.936op/s ± 218333.912op/s 255457786.657op/s ± 106798.215op/s 255573925.071op/s 255792843.582op/s 255930881.265op/s 256316481.461op/s 0.34% -0.326 2.471 0.09% 15438.539op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 63.814µs 63.943µs ± 0.071µs 63.933µs ± 0.034µs 63.971µs 64.067µs 64.186µs 64.290µs 0.56% 1.547 4.707 0.11% 0.005µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15554466.193op/s 15638891.246op/s ± 17421.075op/s 15641367.552op/s ± 8347.225op/s 15649180.070op/s 15661344.831op/s 15668530.963op/s 15670431.463op/s 0.19% -1.532 4.635 0.11% 1231.856op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.439µs 57.579µs ± 0.078µs 57.557µs ± 0.031µs 57.601µs 57.734µs 57.894µs 58.054µs 0.86% 2.384 8.681 0.14% 0.006µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17225384.554op/s 17367534.788op/s ± 23448.490op/s 17374112.572op/s ± 9364.433op/s 17381843.362op/s 17388675.799op/s 17395801.853op/s 17409629.266op/s 0.20% -2.364 8.530 0.13% 1658.059op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.896µs 3.915µs ± 0.003µs 3.915µs ± 0.001µs 3.916µs 3.919µs 3.921µs 3.927µs 0.31% -1.239 12.866 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 254650942.826op/s 255438056.037op/s ± 174221.064op/s 255439524.693op/s ± 76399.327op/s 255507256.420op/s 255678985.808op/s 255859936.606op/s 256658402.032op/s 0.48% 1.266 13.012 0.07% 12319.290op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.572µs 54.717µs ± 0.134µs 54.682µs ± 0.028µs 54.710µs 55.116µs 55.190µs 55.313µs 1.16% 2.649 6.388 0.24% 0.009µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 18078850.462op/s 18276054.534op/s ± 44334.650op/s 18287680.504op/s ± 9199.736op/s 18296471.069op/s 18309473.139op/s 18319426.031op/s 18324516.370op/s 0.20% -2.639 6.338 0.24% 3134.933op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 51.963µs 52.155µs ± 0.074µs 52.155µs ± 0.052µs 52.209µs 52.268µs 52.325µs 52.384µs 0.44% 0.045 -0.247 0.14% 0.005µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19089637.081op/s 19173706.290op/s ± 27360.258op/s 19173680.291op/s ± 19086.920op/s 19192156.167op/s 19218476.163op/s 19232515.956op/s 19244456.619op/s 0.37% -0.037 -0.251 0.14% 1934.662op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.438µs 6.634µs ± 0.064µs 6.634µs ± 0.045µs 6.678µs 6.730µs 6.770µs 6.841µs 3.12% 0.046 0.100 0.96% 0.004µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 146173999.305op/s 150744030.506op/s ± 1444351.127op/s 150738480.300op/s ± 1020899.128op/s 151759440.152op/s 153100934.480op/s 153621860.209op/s 155322449.405op/s 3.04% 0.014 0.091 0.96% 102131.048op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.914µs; 3.915µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [255456156.766op/s; 255501153.284op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [82.254µs; 82.310µs] or [-0.034%; +0.034%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12149232.583op/s; 12157465.464op/s] or [-0.034%; +0.034%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [76.872µs; 76.959µs] or [-0.057%; +0.057%] None None None
credit_card/is_card_number/ 378282246310005 throughput [12994098.415op/s; 13008790.808op/s] or [-0.057%; +0.057%] None None None
credit_card/is_card_number/37828224631 execution_time [3.914µs; 3.915µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631 throughput [255458799.052op/s; 255505053.232op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/378282246310005 execution_time [73.759µs; 73.881µs] or [-0.082%; +0.082%] None None None
credit_card/is_card_number/378282246310005 throughput [13535791.269op/s; 13558059.842op/s] or [-0.082%; +0.082%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.142µs; 52.164µs] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19170419.633op/s; 19178558.333op/s] or [-0.021%; +0.021%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.587µs; 6.605µs] or [-0.131%; +0.131%] None None None
credit_card/is_card_number/x371413321323331 throughput [151417713.662op/s; 151815916.332op/s] or [-0.131%; +0.131%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.914µs; 3.915µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ throughput [255429282.955op/s; 255489800.916op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [63.933µs; 63.953µs] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15636476.852op/s; 15641305.639op/s] or [-0.015%; +0.015%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [57.568µs; 57.590µs] or [-0.019%; +0.019%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17364285.053op/s; 17370784.524op/s] or [-0.019%; +0.019%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.914µs; 3.915µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255413910.673op/s; 255462201.400op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.698µs; 54.735µs] or [-0.034%; +0.034%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18269910.178op/s; 18282198.890op/s] or [-0.034%; +0.034%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.145µs; 52.165µs] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19169914.422op/s; 19177498.159op/s] or [-0.020%; +0.020%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.626µs; 6.643µs] or [-0.133%; +0.133%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [150543857.331op/s; 150944203.681op/s] or [-0.133%; +0.133%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 80413e7 1743423650 ivoanjo/prof-11524-small-tweak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 502.812µs 504.475µs ± 0.525µs 504.445µs ± 0.358µs 504.847µs 505.300µs 505.675µs 505.936µs 0.30% -0.065 0.133 0.10% 0.037µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1976535.233op/s 1982260.072op/s ± 2064.004op/s 1982377.217op/s ± 1405.014op/s 1983636.542op/s 1985646.194op/s 1986869.370op/s 1988816.004op/s 0.32% 0.072 0.136 0.10% 145.947op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 453.508µs 454.963µs ± 0.556µs 454.998µs ± 0.378µs 455.330µs 455.829µs 456.153µs 457.763µs 0.61% 0.493 2.313 0.12% 0.039µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2184535.108op/s 2197984.263op/s ± 2683.553op/s 2197810.409op/s ± 1827.087op/s 2199830.756op/s 2202283.858op/s 2203683.666op/s 2205032.281op/s 0.33% -0.478 2.252 0.12% 189.756op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 177.387µs 177.862µs ± 0.123µs 177.855µs ± 0.071µs 177.945µs 178.033µs 178.149µs 178.199µs 0.19% -0.454 1.287 0.07% 0.009µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5611692.248op/s 5622338.790op/s ± 3883.600op/s 5622563.870op/s ± 2256.625op/s 5624316.637op/s 5629309.156op/s 5632123.535op/s 5637379.290op/s 0.26% 0.461 1.298 0.07% 274.612op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.519µs 37.597µs ± 0.040µs 37.591µs ± 0.027µs 37.620µs 37.678µs 37.708µs 37.732µs 0.37% 0.793 0.658 0.11% 0.003µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26502739.194op/s 26598114.366op/s ± 28284.905op/s 26601969.468op/s ± 19109.294op/s 26617171.834op/s 26635710.322op/s 26647102.889op/s 26653162.398op/s 0.19% -0.786 0.643 0.11% 2000.045op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 48.187µs 48.310µs ± 0.047µs 48.303µs ± 0.025µs 48.331µs 48.392µs 48.423µs 48.628µs 0.67% 1.912 9.989 0.10% 0.003µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 20564255.118op/s 20699671.744op/s ± 19920.734op/s 20702769.631op/s ± 10805.298op/s 20712200.796op/s 20723846.760op/s 20734007.827op/s 20752543.837op/s 0.24% -1.888 9.799 0.10% 1408.609op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [504.402µs; 504.548µs] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1981974.021op/s; 1982546.123op/s] or [-0.014%; +0.014%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [454.886µs; 455.040µs] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2197612.348op/s; 2198356.178op/s] or [-0.017%; +0.017%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [177.845µs; 177.879µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5621800.560op/s; 5622877.019op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.591µs; 37.602µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26594194.350op/s; 26602034.382op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [48.304µs; 48.316µs] or [-0.013%; +0.013%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [20696910.922op/s; 20702432.566op/s] or [-0.013%; +0.013%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 80413e7 1743423650 ivoanjo/prof-11524-small-tweak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 4.941µs 4.993µs ± 0.032µs 4.991µs ± 0.030µs 5.021µs 5.041µs 5.054µs 5.056µs 1.32% 0.271 -1.308 0.64% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [4.988µs; 4.997µs] or [-0.089%; +0.089%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 80413e7 1743423650 ivoanjo/prof-11524-small-tweak
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 245.004ns 255.818ns ± 12.235ns 249.623ns ± 3.888ns 262.873ns 283.799ns 285.840ns 286.553ns 14.79% 1.164 0.096 4.77% 0.865ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [254.123ns; 257.514ns] or [-0.663%; +0.663%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.88%. Comparing base (e8053aa) to head (80413e7).
Report is 21 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #987      +/-   ##
==========================================
- Coverage   72.73%   71.88%   -0.86%     
==========================================
  Files         335      334       -1     
  Lines       51089    50291     -798     
==========================================
- Hits        37161    36152    -1009     
- Misses      13928    14139     +211
Components Coverage Δ
crashtracker 42.88% <ø> (+0.02%) ⬆️
crashtracker-ffi 6.25% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.70% <100.00%> (-0.19%) ⬇️
data-pipeline-ffi 90.29% <ø> (ø)
ddcommon 81.04% <61.84%> (-0.92%) ⬇️
ddcommon-ffi 68.64% <58.27%> (-1.49%) ⬇️
ddtelemetry 61.76% <ø> (ø)
ddtelemetry-ffi 22.46% <ø> (ø)
dogstatsd-client 82.57% <ø> (ø)
ipc 82.42% <66.66%> (+<0.01%) ⬆️
profiling 77.58% <7.03%> (-4.17%) ⬇️
profiling-ffi 62.28% <2.29%> (-7.63%) ⬇️
serverless 0.00% <ø> (ø)
sidecar 42.54% <ø> (+1.40%) ⬆️
sidecar-ffi 13.52% <ø> (+11.02%) ⬆️
spawn-worker 54.37% <ø> (ø)
tinybytes 91.59% <ø> (ø)
trace-mini-agent 73.82% <ø> (ø)
trace-normalization 98.24% <ø> (ø)
trace-obfuscation 96.00% <ø> (ø)
trace-protobuf 78.13% <ø> (ø)
trace-utils 93.05% <84.21%> (+0.05%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ivoanjo ivoanjo requested a review from danielsn April 1, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielsn danielsn Awaiting requested review from danielsn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
profiling Relates to the profiling* modules.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivoanjo @codecov-commenter