chore(ci): build for [email protected] for AL2 #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmazonLinux2 (AL2) silently upgraded from [email protected] to [email protected] which lead to an error while testing on AL2. This commit change the version of nginx to build for AL2. NOTE: AL2 extra list (https://docs.aws.amazon.com/linux/al2/ug/al2-extras-list.html)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
=======================================
Coverage 70.26% 70.26%
=======================================
Files 47 47
Lines 6224 6224
Branches 882 882
=======================================
Hits 4373 4373
Misses 1423 1423
Partials 428 428 🚀 New features to boost your workflow:
|
dubloom
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AmazonLinux2 (AL2)
silently upgraded from [email protected] to [email protected]added 1.26.3, which the latest point to. Since we install the latest version of nginx for AL2, this lead to an error while testing on AL2. This commit change the version of nginx to build for AL2.NOTE: AL2 extra list (https://docs.aws.amazon.com/linux/al2/ug/al2-extras-list.html)
Note to reviewer
This is a bandaid. A better approach is to find the version of NGINX for AmazonLinux and build the module for the corresponding version.