Skip to content

doc: add introductions to enable appsec #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robertpi
Copy link
Member

No description provided.

@robertpi robertpi requested a review from a team as a code owner May 26, 2025 15:25
@robertpi robertpi requested review from Anilm3 and removed request for a team May 26, 2025 15:25
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.97%. Comparing base (cf1a29a) to head (04805ac).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #214   +/-   ##
=======================================
  Coverage   70.97%   70.97%           
=======================================
  Files          50       50           
  Lines        6381     6381           
  Branches      905      905           
=======================================
  Hits         4529     4529           
  Misses       1403     1403           
  Partials      449      449           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dmehala dmehala changed the title docs for app doc: add introductions to enable appsec May 26, 2025
Copy link
Contributor

@dmehala dmehala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure just setting the env var is enough? If I recall correctly, it's also required to set up a thread pool.

@@ -19,3 +19,6 @@ controller:
valueFrom:
fieldRef:
fieldPath: status.hostIP
# add this env var to enable the App and API Security product
- name: DD_APPSEC_ENABLED
value: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
value: true
value: true

Copy link
Contributor

@dubloom dubloom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small nit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants