fix: required-version respawning of orchestrion causes build failures #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The automatic version check incurring a re-spawn of orchestrion with the `go.mod` version cannot happen in all situations, and this results in inconsistent build IDs being generated when manually specifying `-toolexec` (instead of using `orchestrion go ...`). Since we cannot always do the version check, we cannot re-spawn in all situations. For now, we decided to no longer re-spawn but instead produce specific error messages when the running version is not the one required by `go.mod`, instructing users what to do to fix that. Fixes #507
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The automatic version check incurring a re-spawn of orchestrion with the
go.modversion cannot happen in all situations, and this results in inconsistent build IDs being generated when manually specifying-toolexec(instead of usingorchestrion go ...).Since we cannot always do the version check, we cannot re-spawn in all situations. For now, we decided to no longer re-spawn but instead produce specific error messages when the running version is not the one required by
go.mod, instructing users what to do to fix that.Fixes #507