fix(alias): use POSIX shell word splitting for alias expansion#509
Merged
platinummonkey merged 1 commit intoMay 15, 2026
Merged
Conversation
Replace split_whitespace() with shell_words::split() so that quoted strings in alias values (e.g. --query "SELECT ...") are preserved as a single token rather than split on interior whitespace. - Add shell-words crate to Cargo.toml - Replace split_whitespace() in apply_expansion with shell_words::split() - Fall back to original args unchanged on malformed aliases (unclosed quotes) - Add tests for quoted spaces, multiline quoted queries, and unclosed quote fallback Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
platinummonkey
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
split_whitespace()withshell_words::split()in alias expansion so that quoted strings (e.g.--query "SELECT COUNT(*) FROM dd.hosts") are preserved as a single token rather than split on interior whitespace, enabling DDSQL aliases with SQL queries to execute correctly.Changes
shell-words = "1"toCargo.toml(Cargo.toml)split_whitespace()withshell_words::split()inapply_expansion(src/commands/alias.rs:92)src/commands/alias.rs:94)test_apply_expansion_preserves_quoted_spacesto verify single-line quoted SQL queries expand correctly (src/commands/alias.rs)test_apply_expansion_preserves_multiline_quoted_queryto verify multiline YAML block scalar queries expand correctly (src/commands/alias.rs)test_apply_expansion_unclosed_quote_returns_unchangedto verify malformed aliases fall back safely (src/commands/alias.rs)Testing
aliases.yamlwith DDSQL queries using|-block scalar formattingcargo clippy -- -D warningsclean,cargo fmt --checkcleanRelated Issues
N/A
🤖 Generated with Claude Code