Skip to content

[ruby] Rewrite setup for Devise gem #4352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Apr 3, 2025
Merged

[ruby] Rewrite setup for Devise gem #4352

merged 28 commits into from
Apr 3, 2025

Conversation

Strech
Copy link
Member

@Strech Strech commented Mar 20, 2025 •
edited
Loading

Motivation

Devise setup is not using real devise provided controllers

Changes

Rails got 2 new controllers

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@Strech Strech force-pushed the appsec-56683-rewrite-rails-devise-application branch from a49f115 to 66aac27 Compare March 20, 2025 13:02
y9v and others added 20 commits March 21, 2025 12:17
@y9v
Disable automated login tests for sinatra and rack
35971a4
@y9v
Enable passing tests for event tracking for Ruby
db66c7f
@y9v
Remove trailing whitespace from manifests/ruby.yml
82e8a53
@y9v
Run format.sh
b21eb34
@y9v
Disable automated user tracking tests for sinatra and rack
2a1630e
@y9v
Rewrite Devise setup for Rails 7.1
c39bd02
@y9v
Rewrite devise setup for Rails 7.2
f9fd35d
@y9v
Rewrite Devise set up for Rails 8.0
e71a826
@y9v
Rewrite devise setup for Rails 5.2
528df72
@y9v
Rewrite devise setup for Rails 5.1
bec2dc3
@y9v
Rewrite Devise setup for Rails 5.0
44fdf9d
@y9v
Rewrite Devise setup for Rails 6.1
cccda40
@y9v
Rewrite Devise setup for Rails 6.0
2db7a0b
@y9v
Rewrite Devise setup for Rails 4.2
9389cd0
@y9v
Fix typo in Rails 5.2 routes file
8d2a246
@y9v
Remove script to run ATO tests
9bf7d28
@y9v
Disable irrelevant ATO tests for Ruby
3db2460
@y9v
Fix authentication endpoint in Rails 4.2 weblog
0ad15f0
@Strech
Merge branch 'main' into appsec-56683-rewrite-rails-devise-application
7476e54
@Strech
Merge branch 'main' into appsec-56683-rewrite-rails-devise-application
2142a7c
@Strech Strech marked this pull request as ready for review March 31, 2025 14:54
@Strech Strech requested review from a team as code owners March 31, 2025 14:54
@Strech Strech force-pushed the appsec-56683-rewrite-rails-devise-application branch from 573f919 to 36d36f6 Compare April 1, 2025 08:39
@Strech Strech force-pushed the appsec-56683-rewrite-rails-devise-application branch from 62f4b2a to 7304a9e Compare April 1, 2025 15:47
@Strech Strech merged commit 60937e7 into main Apr 3, 2025
163 checks passed
@Strech Strech deleted the appsec-56683-rewrite-rails-devise-application branch April 3, 2025 08:12
@Strech Strech restored the appsec-56683-rewrite-rails-devise-application branch April 3, 2025 08:12
@Strech Strech deleted the appsec-56683-rewrite-rails-devise-application branch April 3, 2025 09:58
mtoffl01 pushed a commit that referenced this pull request Apr 3, 2025
@Strech @y9v @mtoffl01
[ruby] Rewrite setup for Devise gem (#4352)
4897973 
Co-authored-by: Yury Lebedev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbeauchesne cbeauchesne cbeauchesne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Strech @cbeauchesne @y9v