Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 44 additions & 3 deletions datadog/data_source_datadog_role.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,14 @@ func dataSourceDatadogRole() *schema.Resource {
Type: schema.TypeInt,
Computed: true,
},
"permissions": {
Description: "Map of permissions granted to this role, keyed by permission name and returning the permission ID.",
Type: schema.TypeMap,
Computed: true,
Elem: &schema.Schema{
Type: schema.TypeString,
},
},
}
},
}
Expand Down Expand Up @@ -82,13 +90,46 @@ func dataSourceDatadogRoleRead(ctx context.Context, d *schema.ResourceData, meta
}

r := roles[roleIndex]
d.SetId(r.GetId())
if err := d.Set("name", r.Attributes.GetName()); err != nil {
roleID := r.GetId()
d.SetId(roleID)

roleResp, httpResp, err := apiInstances.GetRolesApiV2().GetRole(auth, roleID)
if err != nil {
return utils.TranslateClientErrorDiag(err, httpResp, "error getting role details")
}

if err := utils.CheckForUnparsed(roleResp); err != nil {
return diag.FromErr(err)
}
if err := d.Set("user_count", r.Attributes.GetUserCount()); err != nil {

roleData := roleResp.GetData()
if err := d.Set("name", roleData.Attributes.GetName()); err != nil {
return diag.FromErr(err)
}
if err := d.Set("user_count", roleData.Attributes.GetUserCount()); err != nil {
return diag.FromErr(err)
}

permResp, httpResp, err := apiInstances.GetRolesApiV2().ListRolePermissions(auth, roleID)
if err != nil {
return utils.TranslateClientErrorDiag(err, httpResp, "error getting role permissions")
}

if err := utils.CheckForUnparsed(permResp); err != nil {
return diag.FromErr(err)
}

return updateRolePermissionsStateDataSource(ctx, d, permResp.GetData(), apiInstances)
}

func updateRolePermissionsStateDataSource(ctx context.Context, d *schema.ResourceData, rolePerms []datadogV2.Permission, apiInstances *utils.ApiInstances) diag.Diagnostics {
permsMap := make(map[string]string)
for _, perm := range rolePerms {
permsMap[perm.Attributes.GetName()] = perm.GetId()
}

if err := d.Set("permissions", permsMap); err != nil {
return diag.FromErr(err)
}
return nil
}
10 changes: 8 additions & 2 deletions datadog/tests/data_source_datadog_role_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ func TestAccDatadogRoleDatasource(t *testing.T) {
Steps: []resource.TestStep{
{
Config: testAccDatasourceRoleConfig(),
Check: resource.TestCheckResourceAttr("data.datadog_role.foo", "name", "Datadog Standard Role"),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("data.datadog_role.foo", "name", "Datadog Standard Role"),
resource.TestCheckResourceAttrSet("data.datadog_role.foo", "permissions.#"),
),
},
},
})
Expand All @@ -44,7 +47,10 @@ func TestAccDatadogRoleDatasourceExactMatch(t *testing.T) {
},
{
Config: testAccDatasourceRoleExactMatchConfig(rolename),
Check: resource.TestCheckResourceAttr("data.datadog_role.exact_match", "name", rolename+" main"),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("data.datadog_role.exact_match", "name", rolename+" main"),
resource.TestCheckResourceAttrSet("data.datadog_role.exact_match", "permissions.#"),
),
},
},
})
Expand Down
1 change: 1 addition & 0 deletions docs/data-sources/role.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,5 @@ data "datadog_role" "test" {

- `id` (String) The ID of this resource.
- `name` (String) Name of the role.
- `permissions` (Map of String) Map of permissions granted to this role, keyed by permission name and returning the permission ID.
- `user_count` (Number) Number of users assigned to this role.