Skip to content

Fix registry center 'Unknown column a.undefined' error and Oracle DDL null/not null logic inversion #4510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fix registry center 'Unknown column a.undefined' error and Oracle DDL null/not null logic inversion #4510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92aa092
Oracle 数据源生成 DDL 时字段 null/not null 逻辑颠倒
safishhh Nov 21, 2025
61055c2
注册中心-文档 查看报 Unknown column 'a.undefined' 错误
safishhh Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions dinky-admin/src/main/resources/mapper/DocumentMapper.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,14 @@
<if test='param.updateTime!=null and param.updateTime!=""'>
and a.update_time <![CDATA[>=]]> str_to_date( #{param.updateTime},'%Y-%m-%d %H:%i:%s')
</if>
<if test='ew.sqlSegment!=null and ew.sqlSegment!="" and !ew.sqlSegment.startsWith(" ORDER BY")'>
<!-- If SQL segment is present and doesn't start with ORDER BY and does not contain 'undefined', prepend 'and' -->
<if test='ew.sqlSegment!=null and ew.sqlSegment!="" and !ew.sqlSegment.startsWith(" ORDER BY") and ew.sqlSegment.indexOf("undefined")==-1'>
and
</if>
<if test='ew.sqlSegment!=null and ew.sqlSegment!=""'>
<!-- Only include the dynamic segment if it does not contain the literal 'undefined' -->
<if test='ew.sqlSegment!=null and ew.sqlSegment!="" and ew.sqlSegment.indexOf("undefined")==-1'>
${ew.sqlSegment}
</if>
</where>
</select>
</mapper>
</mapper>
2 changes: 1 addition & 1 deletion ...-metadata/dinky-metadata-oracle/src/main/java/org/dinky/metadata/driver/OracleDriver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ public String getCreateTableSql(Table table) {
}
sb.append("\"" + columns.get(i).getName() + "\" "
+ getTypeConvert().convertToDB(columns.get(i).getDataType()));
if (columns.get(i).isNullable()) {
if (!columns.get(i).isNullable()) {
sb.append(" NOT NULL");
}
}
Expand Down
Loading