Optimize Get/SetFieldValue() to use integer indexes instead of search in Dictionary by string field name
#365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of search in Dictionary by string field name (#158) * ARCH-6354: Optimize Get/SetFieldValue() to use integer indexes instead of search by string key * Correct for IssueJira0538 test case * Refactor * Refactor * non-Public fields too * add comment * rename * Fix issue witn `new` property specifier * Fix Flaky test * Fix BuildPersistentFields() * Skip overridden persistent properties * Correctly process overriddent properties * DOn't ignore abstract props * Add EOL * Upgrade to Ubuntu 22.04 * Fix assigning prop index * Fix processing virtual fields * Minor fix * process IsStructure bases * Fix a few cases * Fix QueryCompositeTest case * Process Recycled fields * Optimize Field mapping * Refactor
SergeiPavlov
changed the title
Get/SetFieldValue() to use integer indexes inst…Get/SetFieldValue() to use integer indexes instead of search in Dictionary by string field name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The [Field] properties inside class are sorted in order of MetadataToken value.
Properties, inherited from base class are first.